The source project of this merge request has been removed.
WIP: Allow renderjs from JS only, without initial gadget-tag/script-tag
In order to integrate renderjs and jupyter I need to be able to load everything-renderjs from a javascript interface. The inital loaded HTML does not contain anything of renderjs and gets added only after pageload.
I thus added functionallity to renderjs to initialize manually, after pageload. See the forum entry here.Instead of registering
init()for theDOMContentLoadedevent directly, a deferred promise is used which gets resolve either by the event, or by a manual call ofrJS.manualBootstrap().An additional change is required to prevent renderjs bootstrapping multiple times when first loaded via
$.getScript, and later included in a gadget via<script>(Line 685). I am not sure if this is the best way to do things though and if it breaks other stuff.I am generally new to this library and RSVP so this might be flawed and so, please comment. @romain @klaus
-
Please do not need to commit "dist" files.
Could you please add a test to ensure you get the expected result with your change?
-
676 676 Node, FileReader, Blob, navigator, Event) { 677 677 "use strict"; 678 678 679 -
This change is about another issue. Please add it in another commit if really needed, with related tests.
But I think it is more an issue of the Jupyter plugin. One way to easily bypass this is to load the renderJS gadget with an iframe. Otherwise, the gadget will also load CSS for example.
-
-
Alright I discussed with Klaus and we concluded that using an iframe is better. In that case no modifications are necessary as far as I can tell now.
Are you interested in the modificatios I made here or should I close the merge request once the iframe approach is working? -
Yes, I'm interested in the manual bootstrap method.
When I said use iframe, I meant use: declareGadget(... sandbox: iframe ...). That will be the only way to call gadget method with parameter date calculated from Jupyter. In this case, you still need to inject RSVP and renderJS in the page manually (if you can not include it by default in Jupyter page).
-
Status changed to closed
Toggle commit list
-
Please register or sign in to post a comment