Commit 84450dad authored by Xavier Thompson's avatar Xavier Thompson

software/theia: Disable integrated git credentials prompt

parent 42d9aea5
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
[instance-theia] [instance-theia]
_update_hash_filename_ = instance-theia.cfg.jinja.in _update_hash_filename_ = instance-theia.cfg.jinja.in
md5sum = 562acf69f344fa9f6d03992d696462d0 md5sum = e39925b69a8bc17d17be54c075ae2f88
[instance] [instance]
_update_hash_filename_ = instance.cfg.in _update_hash_filename_ = instance.cfg.in
......
...@@ -594,7 +594,8 @@ template = ...@@ -594,7 +594,8 @@ template =
"**/node_modules/**": true, "**/node_modules/**": true,
"$${directory:runner}/**":true, "$${directory:runner}/**":true,
"$${directory:project}/runner/**":true "$${directory:project}/runner/**":true
} },
"git.terminalAuthentication": false
} }
[runner-link] [runner-link]
......
  • I have been using before this change and in my experience it was working fine. Is there something not working ?

  • ( it was working fine but the user experience was a bit surprising, I guess it's like this in vscode for integration with system keyring )

  • I've received feedback against it from several users, that's why I deactivated it. Some didn't even notice the credential prompt at first, and another issue is that when you type your password it's in the clear.

  • Thanks @xavier_thompson for explanation. I believe you were right making this change. This feature was a bit surprising, when using git commands in the terminal, users expect to have their credential prompted for in the terminal.

    For the records, I think was a password input field, not text input when I used it.

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment