Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 130
    • Merge requests 130
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1330
You need to sign in or sign up before continuing.

software/helloworld: Switch to default go version

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Levin Zimmermann requested to merge levin.zimmermann/slapos:helloworld-default-go into master Jan 24, 2023
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Hello @kirr,

as we discussed it here this patch changes the helloworld SR, so that it uses go1.18.

Tests were successful expect for one failure of seleniumserver which I believe to be unrelated, because it also happens from time to time with nexedi/master test results (please see 1, 2).


Full commit message:

Patch 15e26abd explicitly declared go version 1.17 for the 'helloworld' SR.

This was done at a time when we already had [golang1.17] in component/golang, but the default was still go1.16. The explicit declaration allowed the 'helloworld' SR to already switch to the newest go version.

Since patch d32524c3 we use go1.18 as our default version. In order to allow 'helloworld' to use our newest SlapOS supported go version, it's therefore sufficient nowadays to simply remove the explicit declaration.


Are there any objections? Thanks and

Best, Levin

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: helloworld-default-go
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7