nexedi / slapos

cc @tomo @bk @vpelletier @alain.takoudjou

closed

changed title from Use husky and lint-staged to set manage commit hooks to Use husky and lint-staged to manage commit hooks

reopening... I closed by mistake I just wanted to fix typo on the title

reopened

Hum, it is not my thing (or may are of knowledge) but it looks ok to have (unless someones objects).

It's not installed automatically, as we can see in the screencast, one have to run npm install to enable it. Running npm install also install the hooks, npm uninstall husky uninstalls hooks.

I see it as something nice to have for people who want to use it and something that people who don't want to use can easily ignore.

https://github.com/creationix/nvm#installation is an easy way to get node for people who don't have it already

merged

I just realised you assigned to me, so I merged. 👍

see nexedi/slapos!424 (merged)

mentioned in commit jerome/slapos@a18b06d6

Thanks !

BTW, I feel a merge as topic would have been a bit better because there was a bit of description in the MR that would have been nice to have in the git history.

BTW, I feel a merge as topic would have been a bit better because there was a bit of description in the MR that would have been nice to have in the git history.

Then it should either be a commit message or in a committed file.

mentioned in merge request !517 (merged)

mentioned in merge request !522 (merged)

mentioned in commit ce6c8a60

mentioned in merge request !631 (merged)

mentioned in merge request !655