component/caddy: Upgrade to v1.0.0-beta1
This also means that caddy source is fetched directly from upstream, as all required fixes has been incorporated into the upstream.
Since https://github.com/mholt/caddy/releases/tag/v0.11.4 TLS-SNI challenge is replaced by ACME TLS-ALPN challenge, so switch has changed.
Drop direct usage of gowork for now, in order to have caddy built using go module, support for gowork with go modules might come later.
-
MasterIt's working nice, I merge,it will unblock a lot of development.
-
merged
Toggle commit list -
Owner
https://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/seleniumserver/software.cfg also uses caddy and it seems something needs to be adjusted there as well. Any idea what's missing ?
https://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/erp5testnode/software.cfg#L9 also uses caddy . There is no test for this SR.
https://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/theia/software.cfg reused this caddy component, but installing old version of caddy from its own
goworkhttps://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/theia/gowork.cfg#L229-233 so I guess it will still work but use the old version of caddy - which is fine for now. I have not confirmed, but it's probably OK. We don't have test for that SR either. -
Master
https://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/seleniumserver/software.cfg also uses caddy and it seems something needs to be adjusted there as well. Any idea what's missing ?
I will handle this today.
https://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/erp5testnode/software.cfg#L9 also uses caddy . There is no test for this SR.
Who could be assigned to this?
https://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/theia/software.cfg reused this caddy component, but installing old version of caddy from its own
goworkhttps://lab.nexedi.com/nexedi/slapos/blob/6d2019b965f4a3521b651f2cb9ef241dce29af55/software/theia/gowork.cfg#L229-233 so I guess it will still work but use the old version of caddy - which is fine for now. I have not confirmed, but it's probably OK. We don't have test for that SR either.Ok, I leave it as is.
-
Owner
Thanks @luke ! so apparently only seleniumserver had an issue and it's now solved by !546 (merged)
About erp5testnode test, won't it be a problem to run this test inside erp5testnode ? because we run erp5testnode in erp5testnode the port number will clash, I don't think we have a solution to that ( can we format to allocate more than one ip or something ? ). I remember that @rafael at some point said it would be nice to have test for erp5testnode, when I worked on firefox/selenium I accidentally created problems that we only noticed after deployment - a SR test would cover the integration of building firefox in testnode.
Anyway for now problem solved. Thanks again.
