Feature/caddy frontend websocket
Merged
by 
The changes were merged into master. The source branch has been removed.
-
added 5 commits
Toggle commit list -
unmarked as a Work In Progress
Toggle commit list -
Generally it's about implementing
type:websocket. Implementation is simple: by default the whole slave will switch toWSSprotocol, but as lot of apps use specially crafted path, thewebsocket-pathcan be used to point to it.Please note that the diff for MR is big, as simplification was done here, but commits are (hopefully) explanatory.
Test are passing on my local instance, as soon as they will pass on the test runner I'll merge it.
type:notebookstays as it is, as it needs specially crafted access. -
Awaiting the test result to check.
-
Seems all ok after a quick read.
-
-
-
Edited
If I understand correctly, to make a frontend for slapos's theia ( which uses this config on backend ), it would be:
request( caddy_frontend_sr_url, 'theia frontend', software_type='', partition_parameters_kw={ 'type': 'websocket', 'websocket-path': '/services', 'url': ..., })would be interesting to try if it works.
-
software/caddy-frontend/instance-slave-caddy-input-schema.json
107 107 "title": "type:zope Backend Path", 108 108 "type": "string" 109 109 }, 110 "websocket-path": { -
For the records, erp5!761 will bring an excellent parameter editor which will allow to use "conditional branches" in the json schema, so one day we'll be able to have dynamic form and show websocket-path only if type is websocket.
See this demo - you can try with https://lab.nexedi.com/nexedi/slapos/raw/master/software/jstestnode/instance-jstestnode-input-schema.json ( pasting the url does not update the form you have to type in the url field for editor to refresh itself ).
I don't know why it's not merged.
-
-
If I understand correctly, to make a frontend for slapos's theia ( which uses this config on backend ), it would be:
request( caddy_frontend_sr_url, 'theia frontend', software_type='', partition_parameters_kw={ 'type': 'websocket', 'websocket-path': '/services', 'url': ..., })would be interesting to try if it works.
Excellent. I am experiment with this websocket backend.
-
Toggle commit list
-
added 5 commits
Toggle commit list -
Toggle commit list
-
All is done, thus awaiting test result 20190419-5A2AD7A2. Passed on my local environment, so it is high chance it will work here too.
-
added 11 commits
-
658a8e38...016e815e - 7 commits from branch
nexedi:master - c23cf3b7 - caddy-frontend: Fix documentation
- 0637f10d - caddy-frontend: Simplify slave configuration generation
- 2590b062 - caddy-frontend: Serve notebook in main process
- 73104feb - caddy-frontend: Implement type:websocket
Toggle commit list -
658a8e38...016e815e - 7 commits from branch
-
unmarked as a Work In Progress
Toggle commit list -
All is done, thus awaiting test result 20190419-5A2AD7A2.
Passed, merging.
-
merged
Toggle commit list
-
Please register or sign in to post a comment