Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !951

Merged
Created Mar 29, 2021 by Xavier Thompson@xavier_thompsonOwner

software/theia: Fix shell bug

  • Overview 2
  • Commits 2
  • Changes 5

Fix a bug that prevents a new shell from being opened in theia. The immediate cause is that the PATH of the shell process is overwritten (it then only contains the path of go), which caused the script that launches the shell to crash because is relied on the env command being in the PATH.

This first rewrites the shell script without using env, so that the shell should be able to start even if the PATH is completely broken.

Further investigation shows that the overwritten PATH seems to be caused by the golang.go extension. So this then removes the golang.go extension from the ones installed by default.

EDIT: to reproduce the bug simply create a .go file and open it in the theia editor.

Edited Mar 29, 2021 by Xavier Thompson
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: theia_fix_shell_path
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7