Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos
slapos
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 84
    • Merge Requests 84
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • nexedi
  • slaposslapos
  • Merge Requests
  • !951

Merged
Opened Mar 29, 2021 by Xavier Thompson@xavier_thompson
  • Report abuse
Report abuse

software/theia: Fix shell bug

Fix a bug that prevents a new shell from being opened in theia. The immediate cause is that the PATH of the shell process is overwritten (it then only contains the path of go), which caused the script that launches the shell to crash because is relied on the env command being in the PATH.

This first rewrites the shell script without using env, so that the shell should be able to start even if the PATH is completely broken.

Further investigation shows that the overwritten PATH seems to be caused by the golang.go extension. So this then removes the golang.go extension from the ones installed by default.

EDIT: to reproduce the bug simply create a .go file and open it in the theia editor.

Edited Mar 29, 2021 by Xavier Thompson

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://lab.nexedi.com/xavier_thompson/slapos.git theia_fix_shell_path
git checkout -b xavier_thompson/slapos-theia_fix_shell_path FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff xavier_thompson/slapos-theia_fix_shell_path

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 2
  • Changes 5
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: nexedi/slapos!951

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7