'live_test.js' no longer needed.

bt5/erp5_wendelin_development/SkinTemplateItem/portal_skins/erp5_wendelin_development/ERP5Site_getJavaScriptRelativeUrlList.py

@@ -7,5 +7,5 @@
 #
 # BBB: For the history, erp5_xhtml_appearance.js is included by default when
 #      js_list is not pre-defined before the global definitions.
-js_list = ('jquery/core/jquery.min.js', 'jquery/ui/js/jquery-ui.min.js', 'erp5.js', 'erp5_knowledge_box.js', 'erp5_dhtml_style.js','live_test.js')
+js_list = ('jquery/core/jquery.min.js', 'jquery/ui/js/jquery-ui.min.js', 'erp5.js', 'erp5_knowledge_box.js', 'erp5_dhtml_style.js')
 return js_list

[Kirill Smelkov]

@Tyagov, I was debugging why activity report top-like tool stopped to work after recent NEO-clone (& production) upgrade and noted the following in JS-console:

Failed to load resource: the server responded with a status of 404 (Not Found) https://softinst69010.host.vifib.net/erp5/live_test.js

though after I grepped it all around, indeed live_test.js is not present anywhere in erp5.git, wendelin.git and the like, so on our neo clone there are following scripts that return site JS list:

portal_skins/custom/ERP5Site_getJavaScriptRelativeUrlList
portal_skins/erp5_knowledge_pad/ERP5Site_getJavaScriptRelativeUrlList
portal_skins/erp5_xhtml_style/ERP5Site_getJavaScriptRelativeUrlList

but only custom one has live_test.js there (https://softinst69010.host.vifib.net/erp5/portal_skins/custom/ERP5Site_getJavaScriptRelativeUrlList/ZPythonScriptHTML_editForm):

js_list = ('jquery/core/jquery.min.js', 'jquery/ui/js/jquery-ui.min.js', 'erp5.js', 'erp5_knowledge_box.js', 'erp5_dhtml_style.js','live_test.js')

and live_test.js is still being loaded by site, e.g.

    ...
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/jquery/core/jquery.min.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/jquery/ui/js/jquery-ui.min.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/erp5.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/erp5_knowledge_box.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/erp5_dhtml_style.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/live_test.js"></script>                      <-- NOTE here
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/erp5_xhtml_appearance.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/rsvp.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/renderjs.js"></script>
    <script type="text/javascript"
            src="https://softinst69010.host.vifib.net/erp5/erp5_gadgetfield.js"></script>

I'm js newbie, but for load monitoring of both neo clone & production, it is better to restore activities top. So any advice on this topic is welcome.

Thanks beforehand,
Kirill

/cc @klaus

[Kirill Smelkov]

Probably live_test.js was removed in favour ofrenderjs in erp5@7b5083e3.

From the point of view the error should be harmless and we only need to adjust portal_skins/custom/ERP5Site_getJavaScriptRelativeUrlList.

I still wonder why activities top-reporting does not work.

[Ivan Tyagov]

@kirr , looks like you're right. I think we can safely exclude this removed file. Can you please do?

[Kirill Smelkov]

@Tyagov thanks for feedback. I've removed live_test.js from portal_skins/custom/ERP5Site_getJavaScriptRelativeUrlList on both neo clone and production instances. @klaus if this maybe (p < 0.01%) cause problems please report back or revert the change.