pylinting

slapos/tests/slap.py

@@ -209,8 +209,7 @@ class TestSlap(SlapMixin):
       if parsed_url.path == 'registerComputerPartition' and \
          parsed_qs['computer_reference'][0] == computer_guid and \
          parsed_qs['computer_partition_reference'][0] == partition_id:
-        partition = slapos.slap.ComputerPartition(
-            computer_guid, partition_id)
+        slapos.slap.ComputerPartition(computer_guid, partition_id)
         return (404, {}, '')
       else:
         return (0, {}, '')
@@ -299,7 +298,6 @@ class TestComputer(SlapMixin):
     slap = self.slap
     slap.initializeConnection(self.server_url)
 
-    partition_id = 'PARTITION_01'
     def server_response(self, path, method, body, header):
       parsed_url = urlparse.urlparse(path.lstrip('/'))
       parsed_qs = urlparse.parse_qs(parsed_url.query)
@@ -419,7 +417,6 @@ class TestComputerPartition(SlapMixin):
 
   def test_request_sends_request(self):
     partition_id = 'PARTITION_01'
-    request_called_amount = 0
     def server_response(self, path, method, body, header):
       parsed_url = urlparse.urlparse(path.lstrip('/'))
       parsed_qs = urlparse.parse_qs(parsed_url.query)
@@ -775,7 +772,6 @@ class TestOpenOrder(SlapMixin):
     computer_guid = self._getTestComputerId()
     requested_partition_id = 'PARTITION_01'
     def server_response(self, path, method, body, header):
-      parsed_url = urlparse.urlparse(path.lstrip('/'))
       from slapos.slap.slap import SoftwareInstance
       slap_partition = SoftwareInstance(
         slap_computer_id=computer_guid,

slapos/tests/slapgrid.py

@@ -430,7 +430,7 @@ class TestSlapgridCPWithMaster(MasterMixin, unittest.TestCase):
 
   def test_nothing_to_do(self):
 
-    computer = ComputerForTest(self.software_root,self.instance_root,0,0)
+    ComputerForTest(self.software_root,self.instance_root, 0, 0)
 
     self.assertEqual(self.grid.processComputerPartitionList(), slapgrid.SLAPGRID_SUCCESS)
     self.assertSortedListEqual(os.listdir(self.instance_root), ['etc', 'var'])

slapos/tests/slapobject.py

@@ -173,7 +173,7 @@ class TestSoftwareSlapObject(BasicMixin, unittest.TestCase):
     )
     software.install()
 
-  def test_software_install_networkcache_upload_blacklist(self):
+  def test_software_install_networkcache_upload_blacklist_side_effect(self):
     """
       Check if the networkcache upload blacklist parameters only prevent
       blacklisted Software Release to be uploaded.