Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
38a97197
Commit
38a97197
authored
Jan 30, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix disable storing of sensitive information when importing a new repo
parent
6aec85ac
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
22 additions
and
4 deletions
+22
-4
app/views/shared/_import_form.html.haml
app/views/shared/_import_form.html.haml
+1
-1
changelogs/unreleased/23767-disable-storing-of-sensitive-information.yml
...leased/23767-disable-storing-of-sensitive-information.yml
+4
-0
spec/features/projects/new_project_spec.rb
spec/features/projects/new_project_spec.rb
+17
-3
No files found.
app/views/shared/_import_form.html.haml
View file @
38a97197
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
=
f
.
label
:import_url
,
class:
'control-label'
do
=
f
.
label
:import_url
,
class:
'control-label'
do
%span
Git repository URL
%span
Git repository URL
.col-sm-10
.col-sm-10
=
f
.
text_field
:import_url
,
class:
'form-control'
,
placeholder:
'https://username:password@gitlab.company.com/group/project.git'
,
disabled:
true
=
f
.
text_field
:import_url
,
autocomplete:
'off'
,
class:
'form-control'
,
placeholder:
'https://username:password@gitlab.company.com/group/project.git'
,
disabled:
true
.well.prepend-top-20
.well.prepend-top-20
%ul
%ul
...
...
changelogs/unreleased/23767-disable-storing-of-sensitive-information.yml
0 → 100644
View file @
38a97197
---
title
:
Fix disable storing of sensitive information when importing a new repo
merge_request
:
8885
author
:
Bernard Pietraga
spec/features/projects/new_project_spec.rb
View file @
38a97197
require
"spec_helper"
require
"spec_helper"
feature
"New project"
,
feature:
true
do
feature
"New project"
,
feature:
true
do
context
"Visibility level selector"
do
let
(
:user
)
{
create
(
:admin
)
}
let
(
:user
)
{
create
(
:admin
)
}
before
{
login_as
(
user
)
}
before
do
login_as
(
user
)
end
context
"Visibility level selector"
do
Gitlab
::
VisibilityLevel
.
options
.
each
do
|
key
,
level
|
Gitlab
::
VisibilityLevel
.
options
.
each
do
|
key
,
level
|
it
"sets selector to
#{
key
}
"
do
it
"sets selector to
#{
key
}
"
do
stub_application_setting
(
default_project_visibility:
level
)
stub_application_setting
(
default_project_visibility:
level
)
...
@@ -16,4 +18,16 @@ feature "New project", feature: true do
...
@@ -16,4 +18,16 @@ feature "New project", feature: true do
end
end
end
end
end
end
context
'Import project options'
do
before
do
visit
new_project_path
end
it
'does not autocomplete sensitive git repo URL'
do
autocomplete
=
find
(
'#project_import_url'
)[
'autocomplete'
]
expect
(
autocomplete
).
to
eq
(
'off'
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment