Commit 7891aec0 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Refactor merge requests bulk update spec

Signed-off-by: default avatarDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
parent 1a18eb59
...@@ -16,11 +16,7 @@ feature 'Multiple merge requests updating from merge_requests#index', feature: t ...@@ -16,11 +16,7 @@ feature 'Multiple merge requests updating from merge_requests#index', feature: t
it 'sets to closed' do it 'sets to closed' do
visit namespace_project_merge_requests_path(project.namespace, project) visit namespace_project_merge_requests_path(project.namespace, project)
find('#check_all_issues').click change_status('Closed')
find('.js-issue-status').click
find('.dropdown-menu-status a', text: 'Closed').click
click_update_merge_requests_button
expect(page).to have_selector('.merge-request', count: 0) expect(page).to have_selector('.merge-request', count: 0)
end end
...@@ -28,80 +24,92 @@ feature 'Multiple merge requests updating from merge_requests#index', feature: t ...@@ -28,80 +24,92 @@ feature 'Multiple merge requests updating from merge_requests#index', feature: t
merge_request.close merge_request.close
visit namespace_project_merge_requests_path(project.namespace, project, state: 'closed') visit namespace_project_merge_requests_path(project.namespace, project, state: 'closed')
find('#check_all_issues').click change_status('Open')
find('.js-issue-status').click
find('.dropdown-menu-status a', text: 'Open').click
click_update_merge_requests_button
expect(page).to have_selector('.merge-request', count: 0) expect(page).to have_selector('.merge-request', count: 0)
end end
end end
context 'assignee', js: true do context 'assignee', js: true do
it 'updates to current user' do context 'set assignee' do
before do
visit namespace_project_merge_requests_path(project.namespace, project) visit namespace_project_merge_requests_path(project.namespace, project)
end
find('#check_all_issues').click it "should update merge request with assignee" do
click_update_assignee_button change_assignee(user.name)
find('.dropdown-menu-user-link', text: user.username).click
click_update_merge_requests_button
page.within('.merge-request .controls') do page.within('.merge-request .controls') do
expect(find('.author_link')["title"]).to have_content(user.name) expect(find('.author_link')["title"]).to have_content(user.name)
end end
end end
end
it 'updates to unassigned' do context 'remove assignee' do
before do
merge_request.assignee = user merge_request.assignee = user
merge_request.save merge_request.save
visit namespace_project_merge_requests_path(project.namespace, project) visit namespace_project_merge_requests_path(project.namespace, project)
end
find('#check_all_issues').click it "should remove assignee from the merge request" do
click_update_assignee_button change_assignee('Unassigned')
expect(find('.merge-request .controls')).not_to have_css('.author_link')
click_link 'Unassigned' end
click_update_merge_requests_button
expect(find('.merge-request:first-child .controls')).not_to have_css('.author_link')
end end
end end
context 'milestone', js: true do context 'milestone', js: true do
let(:milestone) { create(:milestone, project: project) } let(:milestone) { create(:milestone, project: project) }
it 'updates milestone' do context 'set milestone' do
before do
visit namespace_project_merge_requests_path(project.namespace, project) visit namespace_project_merge_requests_path(project.namespace, project)
end
find('#check_all_issues').click it "should update merge request with milestone" do
find('.issues_bulk_update .js-milestone-select').click change_milestone(milestone.title)
find('.dropdown-menu-milestone a', text: milestone.title).click
click_update_merge_requests_button
expect(find('.merge-request')).to have_content milestone.title expect(find('.merge-request')).to have_content milestone.title
end end
end
it 'sets to no milestone' do context 'unset milestone' do
before do
merge_request.milestone = milestone merge_request.milestone = milestone
merge_request.save merge_request.save
visit namespace_project_merge_requests_path(project.namespace, project) visit namespace_project_merge_requests_path(project.namespace, project)
end
expect(first('.merge-request')).to have_content milestone.title it "should remove milestone from the merge request" do
change_milestone("No Milestone")
expect(find('.merge-request')).not_to have_content milestone.title
end
end
end
def change_status(text)
find('#check_all_issues').click find('#check_all_issues').click
find('.issues_bulk_update .js-milestone-select').click find('.js-issue-status').click
find('.dropdown-menu-status a', text: text).click
find('.dropdown-menu-milestone a', text: "No Milestone").click
click_update_merge_requests_button click_update_merge_requests_button
expect(find('.merge-request:first-child')).not_to have_content milestone.title
end
end end
def click_update_assignee_button def change_assignee(text)
find('#check_all_issues').click
find('.js-update-assignee').click find('.js-update-assignee').click
wait_for_ajax wait_for_ajax
page.within '.dropdown-menu-user' do
click_link text
end
click_update_merge_requests_button
end
def change_milestone(text)
find('#check_all_issues').click
find('.issues_bulk_update .js-milestone-select').click
find('.dropdown-menu-milestone a', text: text).click
click_update_merge_requests_button
end end
def click_update_merge_requests_button def click_update_merge_requests_button
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment