Commit 91480e5e authored by Sean McGivern's avatar Sean McGivern

Tidy up IssuesFinder specs

- Don't do setup in spec bodies.
- Don't `describe` a symbol.
- Don't use 'should'.
parent 78a67fc4
require 'spec_helper' require 'spec_helper'
describe IssuesFinder do describe IssuesFinder do
let(:user) { create :user } let(:user) { create(:user) }
let(:user2) { create :user } let(:user2) { create(:user) }
let(:project1) { create(:project) } let(:project1) { create(:empty_project) }
let(:project2) { create(:project) } let(:project2) { create(:empty_project) }
let(:milestone) { create(:milestone, project: project1) } let(:milestone) { create(:milestone, project: project1) }
let(:label) { create(:label, project: project2) } let(:label) { create(:label, project: project2) }
let(:issue1) { create(:issue, author: user, assignee: user, project: project1, milestone: milestone) } let(:issue1) { create(:issue, author: user, assignee: user, project: project1, milestone: milestone) }
...@@ -16,101 +16,113 @@ describe IssuesFinder do ...@@ -16,101 +16,113 @@ describe IssuesFinder do
project1.team << [user, :master] project1.team << [user, :master]
project2.team << [user, :developer] project2.team << [user, :developer]
project2.team << [user2, :developer] project2.team << [user2, :developer]
end
describe :execute do
before :each do
issue1 issue1
issue2 issue2
issue3 issue3
end end
describe '#execute' do
let(:search_user) { user }
let(:params) { {} }
let(:issues) { IssuesFinder.new(search_user, params.merge(scope: scope, state: 'opened')).execute }
context 'scope: all' do context 'scope: all' do
it 'should filter by all' do let(:scope) { 'all' }
params = { scope: "all", state: 'opened' }
issues = IssuesFinder.new(user, params).execute
expect(issues.size).to eq(3)
end
it 'should filter by assignee id' do it 'returns all issues' do
params = { scope: "all", assignee_id: user.id, state: 'opened' } expect(issues).to contain_exactly(issue1, issue2, issue3)
issues = IssuesFinder.new(user, params).execute
expect(issues.size).to eq(2)
end end
it 'should filter by author id' do context 'filtering by assignee ID' do
params = { scope: "all", author_id: user2.id, state: 'opened' } let(:params) { { assignee_id: user.id } }
issues = IssuesFinder.new(user, params).execute
expect(issues).to eq([issue3]) it 'returns issues assigned to that user' do
expect(issues).to contain_exactly(issue1, issue2)
end
end end
it 'should filter by milestone id' do context 'filtering by author ID' do
params = { scope: "all", milestone_title: milestone.title, state: 'opened' } let(:params) { { author_id: user2.id } }
issues = IssuesFinder.new(user, params).execute
expect(issues).to eq([issue1]) it 'returns issues created by that user' do
expect(issues).to contain_exactly(issue3)
end end
end
context 'filtering by milestone' do
let(:params) { { milestone_title: milestone.title } }
it 'should filter by no milestone id' do it 'returns issues assigned to that milestone' do
params = { scope: "all", milestone_title: Milestone::None.title, state: 'opened' } expect(issues).to contain_exactly(issue1)
issues = IssuesFinder.new(user, params).execute end
expect(issues).to match_array([issue2, issue3])
end end
it 'should filter by label name' do context 'filtering by no milestone' do
params = { scope: "all", label_name: label.title, state: 'opened' } let(:params) { { milestone_title: Milestone::None.title } }
issues = IssuesFinder.new(user, params).execute
expect(issues).to eq([issue2]) it 'returns issues with no milestone' do
expect(issues).to contain_exactly(issue2, issue3)
end
end end
it 'returns unique issues when filtering by multiple labels' do context 'filtering by label' do
label2 = create(:label, project: project2) let(:params) { { label_name: label.title } }
create(:label_link, label: label2, target: issue2) it 'returns issues with that label' do
expect(issues).to contain_exactly(issue2)
end
end
params = { context 'filtering by multiple labels' do
scope: 'all', let(:params) { { label_name: [label.title, label2.title].join(',') } }
label_name: [label.title, label2.title].join(','), let(:label2) { create(:label, project: project2) }
state: 'opened'
}
issues = IssuesFinder.new(user, params).execute before { create(:label_link, label: label2, target: issue2) }
expect(issues).to eq([issue2]) it 'returns the unique issues with any of those labels' do
expect(issues).to contain_exactly(issue2)
end
end end
it 'should filter by no label name' do context 'filtering by no label' do
params = { scope: "all", label_name: Label::None.title, state: 'opened' } let(:params) { { label_name: Label::None.title } }
issues = IssuesFinder.new(user, params).execute
expect(issues).to match_array([issue1, issue3]) it 'returns issues with no labels' do
expect(issues).to contain_exactly(issue1, issue3)
end end
end
context 'when the user is unauthorized' do
let(:search_user) { nil }
it 'should be empty for unauthorized user' do it 'returns no results' do
params = { scope: "all", state: 'opened' } expect(issues).to be_empty
issues = IssuesFinder.new(nil, params).execute end
expect(issues.size).to be_zero
end end
it 'should not include unauthorized issues' do context 'when the user can see some, but not all, issues' do
params = { scope: "all", state: 'opened' } let(:search_user) { user2 }
issues = IssuesFinder.new(user2, params).execute
expect(issues.size).to eq(2) it 'returns only issues they can see' do
expect(issues).not_to include(issue1) expect(issues).to contain_exactly(issue2, issue3)
expect(issues).to include(issue2) end
expect(issues).to include(issue3)
end end
end end
context 'personal scope' do context 'personal scope' do
it 'should filter by assignee' do let(:scope) { 'assigned-to-me' }
params = { scope: "assigned-to-me", state: 'opened' }
issues = IssuesFinder.new(user, params).execute it 'returns issue assigned to the user' do
expect(issues.size).to eq(2) expect(issues).to contain_exactly(issue1, issue2)
end end
it 'should filter by project' do context 'filtering by project' do
params = { scope: "assigned-to-me", state: 'opened', project_id: project1.id } let(:params) { { project_id: project1.id } }
issues = IssuesFinder.new(user, params).execute
expect(issues.size).to eq(1) it 'returns issues assigned to the user in that project' do
expect(issues).to contain_exactly(issue1)
end
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment