Fix updating settings for pipelines

app/controllers/projects/pipelines_controller.rb

@@ -50,20 +50,14 @@ class Projects::PipelinesController < Projects::ApplicationController
   end
 
   def update_settings
-    status = ::Projects::UpdateService.new(@project, current_user, pipelines_settings_params).execute
-
-    respond_to do |format|
-      if status
+    if @project.update_attributes(pipelines_settings_params)
       flash[:notice] = "CI/CD Pipelines settings for '#{@project.name}' was successfully updated."
-        format.html do
       redirect_to(
         settings_namespace_project_pipelines_path(@project.namespace, @project),
         notice: "CI/CD Pipelines settings for '#{@project.name}' was successfully updated."
       )
-        end
     else
-        format.html { render 'settings' }
-      end
+      render 'settings'
     end
   end
 

app/services/projects/update_service.rb

@@ -23,7 +23,6 @@ module Projects
         if project.previous_changes.include?('path')
           project.rename_repo
         end
-        true
       end
     end
   end