Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
ab0af562
Commit
ab0af562
authored
Mar 13, 2016
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use Capybara find methods and remove sleeps in feature specs in "All Issues" filter
parent
30ab290b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
9 deletions
+6
-9
app/views/shared/issuable/_filter.html.haml
app/views/shared/issuable/_filter.html.haml
+1
-1
features/steps/dashboard/issues.rb
features/steps/dashboard/issues.rb
+5
-8
No files found.
app/views/shared/issuable/_filter.html.haml
View file @
ab0af562
...
@@ -15,7 +15,7 @@
...
@@ -15,7 +15,7 @@
.filter-item.inline
.filter-item.inline
-
if
params
[
:assignee_id
]
-
if
params
[
:assignee_id
]
=
hidden_field_tag
(
:assignee_id
,
params
[
:assignee_id
])
=
hidden_field_tag
(
:assignee_id
,
params
[
:assignee_id
])
=
dropdown_tag
(
"Assignee"
,
options:
{
toggle_class:
"js-user-search js-filter-submit"
,
title:
"Filter by assignee"
,
filter:
true
,
dropdown_class:
"dropdown-menu-user dropdown-menu-selectable"
,
=
dropdown_tag
(
"Assignee"
,
options:
{
toggle_class:
"js-user-search js-filter-submit
js-assignee-search
"
,
title:
"Filter by assignee"
,
filter:
true
,
dropdown_class:
"dropdown-menu-user dropdown-menu-selectable"
,
placeholder:
"Search assignee"
,
data:
{
any_user:
"Any Author"
,
first_user:
(
current_user
.
username
if
current_user
),
null_user:
true
,
current_user:
true
,
project_id:
(
@project
.
id
if
@project
),
selected:
params
[
:assignee_id
],
field_name:
"assignee_id"
}
})
placeholder:
"Search assignee"
,
data:
{
any_user:
"Any Author"
,
first_user:
(
current_user
.
username
if
current_user
),
null_user:
true
,
current_user:
true
,
project_id:
(
@project
.
id
if
@project
),
selected:
params
[
:assignee_id
],
field_name:
"assignee_id"
}
})
.filter-item.inline.milestone-filter
.filter-item.inline.milestone-filter
...
...
features/steps/dashboard/issues.rb
View file @
ab0af562
...
@@ -44,14 +44,11 @@ class Spinach::Features::DashboardIssues < Spinach::FeatureSteps
...
@@ -44,14 +44,11 @@ class Spinach::Features::DashboardIssues < Spinach::FeatureSteps
end
end
step
'I click "All" link'
do
step
'I click "All" link'
do
execute_script
(
'$(".js-user-search").first().click()'
)
find
(
'.js-author-search'
).
click
sleep
1
find
(
'.dropdown-menu-user-full-name'
,
match: :first
).
click
execute_script
(
'$(".js-user-search").first().parent().find("li a").first().click()'
)
sleep
1
find
(
'.js-assignee-search'
).
click
execute_script
(
'$(".js-user-search").eq(1).click()'
)
find
(
'.dropdown-menu-user-full-name'
,
match: :first
).
click
sleep
1
execute_script
(
'$(".js-user-search").eq(1).parent().find("li a").first().click()'
)
sleep
1
end
end
def
should_see
(
issue
)
def
should_see
(
issue
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment