Commit b9ac56f0 authored by Jérome Perrin's avatar Jérome Perrin

check_software: fix a wrong condition making the check ignore .so

fnmatch.fnmatch signature is path, pattern, we were passing arguments in
reverse order, so effectively we were only checking executable files.
Several .so are executable, so we were checking many .so anyway.
parent 5c938a8d
...@@ -188,7 +188,7 @@ def checkSoftware(slap, software_url): ...@@ -188,7 +188,7 @@ def checkSoftware(slap, software_url):
if any(fnmatch.fnmatch(f, ignored_pattern) if any(fnmatch.fnmatch(f, ignored_pattern)
for ignored_pattern in ignored_file_patterns): for ignored_pattern in ignored_file_patterns):
continue continue
if os.access(f, os.X_OK) or fnmatch.fnmatch('*.so', f): if os.access(f, os.X_OK) or fnmatch.fnmatch(f, '*.so'):
try: try:
libs = getLddOutput(f) libs = getLddOutput(f)
except DynamicLibraryNotFound as e: except DynamicLibraryNotFound as e:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment