Commit e70e2c32 authored by Vincent Pelletier's avatar Vincent Pelletier

Make new_session default to True.

This way, we can effectively kill all subprocesses. This worked for
slapproxy because Flask calls setsid internally, but slapgrid-* doesn't, so
they wouldn't be killed by killpg.
parent c6cd38b3
...@@ -104,7 +104,7 @@ class ProcessManager(object): ...@@ -104,7 +104,7 @@ class ProcessManager(object):
raise CancellationError("Test Result was cancelled") raise CancellationError("Test Result was cancelled")
get_output = kw.pop('get_output', True) get_output = kw.pop('get_output', True)
log_prefix = kw.pop('log_prefix', '') log_prefix = kw.pop('log_prefix', '')
new_session = kw.pop('new_session', False) new_session = kw.pop('new_session', True)
subprocess_kw = {} subprocess_kw = {}
cwd = kw.pop('cwd', None) cwd = kw.pop('cwd', None)
if cwd: if cwd:
......
...@@ -340,7 +340,7 @@ branch = %(branch)s ...@@ -340,7 +340,7 @@ branch = %(branch)s
# result. We only do cleanup if the test runner itself is not able # result. We only do cleanup if the test runner itself is not able
# to run. # to run.
process_manager.spawn(*invocation_list, process_manager.spawn(*invocation_list,
cwd=config['test_suite_directory'], new_session=True, cwd=config['test_suite_directory'],
log_prefix='runTestSuite', get_output=False) log_prefix='runTestSuite', get_output=False)
if remote_logger: if remote_logger:
remote_logger.quit = True remote_logger.quit = True
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment