getLocalRolesGroupIdDict is supposed to return sorted & cast
allowed_roles_and_users value already.
Also, use "x in y" pattern over y.has_key(x) for readability.

Fix a misnamed local.
Use iteritems.
Move variables next to the loop they act on.
Rewrite comments to better reflect the intention when it is not obvious in
the implementation.
Move a loop-invariant out of loop ((user, role) not in optimized_role_set).
Do not use set.update on an iterable constructed just for the call, call
set.add on each item.

Global role computation is very expensive, don't do it when all we are
interested in is user existence.
Also, list all users having local roles in one call to reduce the effect
of per-call overhead.
This should improve indexation speed by a large fraction: pprofile
statistical run on and activity node busy reindexing objects shows:
- 57% of time spend generating (13%) and executing (44%) SQL
- 42% of time spent preparing object for indexation:
  - 29% in _getSecurityParameterList, all in getUserById
  - 12% in getCatalogVariablesFor (workflow variables to index)
So an improvement of close to 30% is expected.

Its parameter is a loop invariant, so avoid looking the same user up once
per local role.

Also cleanup existing documents

Sometimes, we need to generate amounts with and without aggregation.
With this new method, we avoid duplicate computation.

The purpose is to generate amounts only once and

multiplyQuantity() is dead code since
commit 74838d44

- In-browser jslint does not warn about it.
- It's like C/C++ and 'gcc -Wall' does not warn either.

Similar to commit e1d57590

This restore the previous behaviour which has been dropped by nexedi/erp5@63c3da2b

Because getSecurityManager().getUser() always returns "Anonymous User" when Base_getAutoLogoutSessionKey is called (from CookieCrumbler.modifyRequest), all users were sharing the same session which leads to user being all the time logged out.

User may lose test if he/she continues on typing

When used, it will crop the image around the center to the expected size

/reviewed-on nexedi/erp5!117

Makes future table structure changes easier.

instead of class gadget field

- Respect run_only/remote_code_url_list if given.
- When page templates have errors, there may be no Zuite Results, in which case
  testFunctionalTestRunner waits forever, until it gets killed (after a few
  hours). It's easier to fix this issue by check PT at the beginning of
  testFunctionalTestRunner, instead of doing it in a separate test method.

The validation state "hidden" put a class "hidden" on the field. And then field was hidden.

8ba29de3

/reviewed-on !113

in order to avoid timing attacks

/reviewed-on nexedi/erp5!115

When changing listbox display mode (ex: from domain tree to flat list),
remove domain tree from selection, so filtering comming from domain tree
does not apply.
Requested-by: Thierry Brettnacher <tb@nexedi.com>