2010-09-28 tatuya

* Fix a issue that all the base contribution are not copied when change the resource on a movement.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@38773 20353a03-c40f-0410-a6d1-a30d3c3de9de

bt5/erp5_base/WorkflowTemplateItem/portal_workflow/movement_resource_interaction_workflow/scripts/Movement_copyBaseContributionFromResource.xml

@@ -54,12 +54,10 @@
 \n
 resource = movement.getResourceValue()\n
 if resource is not None:\n
-  # if the movement already have a base contribution which is valid for this resource, don\'t change it\n
-  movement_base_contribution = movement.getBaseContribution()\n
-  if movement_base_contribution and movement_base_contribution in resource.getBaseContributionList():\n
-    return\n
-  # otherwise initialise to the default base contribution\n
-  movement.setBaseContribution(resource.getDefaultBaseContribution())\n
+  # We can over-write base contribution list always.\n
+  # Because when we change the resource, we need to set all the base contribution into movement.\n
+  # Imagine that we buy a product which have complex tax definitions with discounting.\n
+  movement.setBaseContributionList(resource.getBaseContributionList())\n
 </string> </value>
         </item>
         <item>
@@ -110,7 +108,6 @@ if resource is not None:\n
                             <string>_getattr_</string>
                             <string>resource</string>
                             <string>None</string>
-                            <string>movement_base_contribution</string>
                           </tuple>
                         </value>
                     </item>

bt5/erp5_base/bt/change_log

+2010-09-28 tatuya
+* Fix a issue that all the base contribution are not copied when change the resource on a movement.
+
 2010-09-28 tatuya
 * Stop overwriting a value by movement_resource_interaraction_workflow when the categories are already set a valid value as the new resource.
 

bt5/erp5_base/bt/revision

-867
+868
\ No newline at end of file