client_spec.rb 2.19 KB
Newer Older
1 2
require 'spec_helper'

Douwe Maan's avatar
Douwe Maan committed
3
describe Gitlab::GithubImport::Client, lib: true do
4
  let(:token) { '123456' }
5 6 7
  let(:github_provider) { Settingslogic.new('app_id' => 'asd123', 'app_secret' => 'asd123', 'name' => 'github', 'args' => { 'client_options' => {} }) }

  subject(:client) { described_class.new(token) }
8 9

  before do
10
    allow(Gitlab.config.omniauth).to receive(:providers).and_return([github_provider])
11 12
  end

13
  it 'convert OAuth2 client options to symbols' do
14 15 16 17
    client.client.options.keys.each do |key|
      expect(key).to be_kind_of(Symbol)
    end
  end
18 19 20 21 22

  it 'does not crash (e.g. Settingslogic::MissingSetting) when verify_ssl config is not present' do
    expect { client.api }.not_to raise_error
  end

23 24 25 26 27 28 29 30 31 32 33 34 35 36
  context 'when config is missing' do
    before do
      allow(Gitlab.config.omniauth).to receive(:providers).and_return([])
    end

    it 'is still possible to get an Octokit client' do
      expect { client.api }.not_to raise_error
    end

    it 'is not be possible to get an OAuth2 client' do
      expect { client.client }.to raise_error(Projects::ImportService::Error)
    end
  end

37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63
  context 'allow SSL verification to be configurable on API' do
    before do
      github_provider['verify_ssl'] = false
    end

    it 'uses supplied value' do
      expect(client.client.options[:connection_opts][:ssl]).to eq({ verify: false })
      expect(client.api.connection_options[:ssl]).to eq({ verify: false })
    end
  end

  context 'when provider does not specity an API endpoint' do
    it 'uses GitHub root API endpoint' do
      expect(client.api.api_endpoint).to eq 'https://api.github.com/'
    end
  end

  context 'when provider specify a custom API endpoint' do
    before do
      github_provider['args']['client_options']['site'] = 'https://github.company.com/'
    end

    it 'uses the custom API endpoint' do
      expect(OmniAuth::Strategies::GitHub).not_to receive(:default_options)
      expect(client.api.api_endpoint).to eq 'https://github.company.com/'
    end
  end
64

65 66 67
  it 'does not raise error when rate limit is disabled' do
    stub_request(:get, /api.github.com/)
    allow(client.api).to receive(:rate_limit!).and_raise(Octokit::NotFound)
68

69
    expect { client.issues }.not_to raise_error
70
  end
71
end