note_spec.rb 3.82 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1 2 3 4 5
require 'spec_helper'

describe Note do
  describe "Associations" do
    it { should belong_to(:project) }
6 7
    it { should belong_to(:noteable) }
    it { should belong_to(:author).class_name('User') }
gitlabhq's avatar
gitlabhq committed
8 9 10 11 12 13 14
  end

  describe "Validation" do
    it { should validate_presence_of(:note) }
    it { should validate_presence_of(:project) }
  end

Drew's avatar
Drew committed
15 16 17 18 19
  describe "Scopes" do
    it "should have a today named scope that returns ..." do
      Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
    end
  end
20

21 22 23 24
  describe "Voting score" do
    let(:project) { Factory(:project) }

    it "recognizes a neutral note" do
25
      note = Factory(:note, note: "This is not a +1 note")
26 27 28 29
      note.should_not be_upvote
    end

    it "recognizes a +1 note" do
30
      note = Factory(:note, note: "+1 for this")
31 32 33 34
      note.should be_upvote
    end

    it "recognizes a -1 note as no vote" do
35
      note = Factory(:note, note: "-1 for this")
36 37 38 39
      note.should_not be_upvote
    end
  end

40 41
  let(:project) { create(:project) }
  let(:commit) { project.commit }
42

43
  describe "Commit notes" do
44
    before do
45
      @note = Factory :note,
46 47
        noteable_id: commit.id,
        noteable_type: "Commit"
48 49 50 51 52 53 54 55
    end

    it "should save a valid note" do
      @note.noteable_id.should == commit.id
      @note.target.id.should == commit.id
    end
  end

56 57
  describe "Pre-line commit notes" do
    before do
58
      @note = Factory :note,
59 60 61
        noteable_id: commit.id,
        noteable_type: "Commit",
        line_code: "0_16_1"
62 63 64 65 66 67 68 69
    end

    it "should save a valid note" do
      @note.noteable_id.should == commit.id
      @note.target.id.should == commit.id
    end
  end

70 71
  describe '#create_status_change_note' do
    let(:project)  { Factory.create(:project) }
72
    let(:thing)    { Factory.create(:issue, project: project) }
73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88
    let(:author)   { Factory(:user) }
    let(:status)   { 'new_status' }

    subject { Note.create_status_change_note(thing, author, status) }

    it 'creates and saves a Note' do
      should be_a Note
      subject.id.should_not be_nil
    end

    its(:noteable) { should == thing }
    its(:project)  { should == thing.project }
    its(:author)   { should == author }
    its(:note)     { should =~ /Status changed to #{status}/ }
  end

Nihad Abbasov's avatar
Nihad Abbasov committed
89 90
  describe :authorization do
    before do
91 92
      @p1 = create(:project)
      @p2 = Factory :project
gitlabhq's avatar
gitlabhq committed
93 94 95 96 97 98 99
      @u1 = Factory :user
      @u2 = Factory :user
      @u3 = Factory :user
      @abilities = Six.new
      @abilities << Ability
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
100 101
    describe :read do
      before do
102 103
        @p1.users_projects.create(user: @u2, project_access: UsersProject::GUEST)
        @p2.users_projects.create(user: @u3, project_access: UsersProject::GUEST)
gitlabhq's avatar
gitlabhq committed
104 105 106 107 108 109 110
      end

      it { @abilities.allowed?(@u1, :read_note, @p1).should be_false }
      it { @abilities.allowed?(@u2, :read_note, @p1).should be_true }
      it { @abilities.allowed?(@u3, :read_note, @p1).should be_false }
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
111 112
    describe :write do
      before do
113 114
        @p1.users_projects.create(user: @u2, project_access: UsersProject::DEVELOPER)
        @p2.users_projects.create(user: @u3, project_access: UsersProject::DEVELOPER)
gitlabhq's avatar
gitlabhq committed
115 116 117 118 119 120 121
      end

      it { @abilities.allowed?(@u1, :write_note, @p1).should be_false }
      it { @abilities.allowed?(@u2, :write_note, @p1).should be_true }
      it { @abilities.allowed?(@u3, :write_note, @p1).should be_false }
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
122 123
    describe :admin do
      before do
124 125 126
        @p1.users_projects.create(user: @u1, project_access: UsersProject::REPORTER)
        @p1.users_projects.create(user: @u2, project_access: UsersProject::MASTER)
        @p2.users_projects.create(user: @u3, project_access: UsersProject::MASTER)
gitlabhq's avatar
gitlabhq committed
127 128 129 130 131 132 133 134
      end

      it { @abilities.allowed?(@u1, :admin_note, @p1).should be_false }
      it { @abilities.allowed?(@u2, :admin_note, @p1).should be_true }
      it { @abilities.allowed?(@u3, :admin_note, @p1).should be_false }
    end
  end
end