project_spec.rb 42.7 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1 2
require 'spec_helper'

Douwe Maan's avatar
Douwe Maan committed
3
describe Project, models: true do
4
  describe 'associations' do
5 6 7 8 9 10 11 12 13
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
14 15
    it { is_expected.to have_many(:users).through(:project_members) }
    it { is_expected.to have_many(:requesters).dependent(:destroy) }
16 17 18 19 20 21 22 23 24 25
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
26
    it { is_expected.to have_many(:commit_statuses) }
27
    it { is_expected.to have_many(:pipelines) }
28 29 30 31 32
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
33 34
    it { is_expected.to have_many(:environments).dependent(:destroy) }
    it { is_expected.to have_many(:deployments).dependent(:destroy) }
35
    it { is_expected.to have_many(:todos).dependent(:destroy) }
36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63

    describe '#members & #requesters' do
      let(:project) { create(:project) }
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

      describe '#members' do
        it 'includes members and exclude requesters' do
          member_user_ids = project.members.pluck(:user_id)

          expect(member_user_ids).to include(developer.id)
          expect(member_user_ids).not_to include(requester.id)
        end
      end

      describe '#requesters' do
        it 'does not include requesters' do
          requester_user_ids = project.requesters.pluck(:user_id)

          expect(requester_user_ids).to include(requester.id)
          expect(requester_user_ids).not_to include(developer.id)
        end
      end
    end
gitlabhq's avatar
gitlabhq committed
64 65
  end

66 67 68 69 70 71 72 73
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
74 75
  end

76
  describe 'validation' do
77 78
    let!(:project) { create(:project) }

79 80
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
81
    it { is_expected.to validate_length_of(:name).is_within(0..255) }
82

83 84
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
85 86
    it { is_expected.to validate_length_of(:path).is_within(0..255) }
    it { is_expected.to validate_length_of(:description).is_within(0..2000) }
87 88
    it { is_expected.to validate_presence_of(:creator) }
    it { is_expected.to validate_presence_of(:namespace) }
89
    it { is_expected.to validate_presence_of(:repository_storage) }
90

91
    it 'should not allow new projects beyond user limits' do
92
      project2 = build(:project)
93 94
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
Phil Hughes's avatar
Phil Hughes committed
95
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
96
    end
97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
        it 'should have an error on the name attribute' do
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
        it 'should have an error on the name attribute' do
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
118 119 120 121 122 123 124 125 126 127 128 129 130 131

    context 'repository storages inclussion' do
      let(:project2) { build(:project, repository_storage: 'missing') }

      before do
        storages = { 'custom' => 'tmp/tests/custom_repositories' }
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

      it "should not allow repository storages that don't match a label in the configuration" do
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
132

133
    it 'does not allow an invalid URI as import_url' do
James Lopez's avatar
James Lopez committed
134 135 136 137 138
      project2 = build(:project, import_url: 'invalid://')

      expect(project2).not_to be_valid
    end

139
    it 'does allow a valid URI as import_url' do
James Lopez's avatar
James Lopez committed
140 141
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')

142 143
      expect(project2).to be_valid
    end
144

145
    it 'allows an empty URI' do
146 147
      project2 = build(:project, import_url: '')

148
      expect(project2).to be_valid
149 150 151 152 153 154 155 156 157 158 159 160 161
    end

    it 'does not produce import data on an empty URI' do
      project2 = build(:project, import_url: '')

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
      project2 = build(:project, import_url: 'test://')

      expect(project2.import_data).to be_nil
    end
gitlabhq's avatar
gitlabhq committed
162
  end
163

164 165 166 167 168 169 170 171 172
  describe 'default_scope' do
    it 'excludes projects pending deletion from the results' do
      project = create(:empty_project)
      create(:empty_project, pending_delete: true)

      expect(Project.all).to eq [project]
    end
  end

173 174
  describe 'project token' do
    it 'should set an random token if none provided' do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
175 176
      project = FactoryGirl.create :empty_project, runners_token: ''
      expect(project.runners_token).not_to eq('')
177 178 179
    end

    it 'should not set an random toke if one provided' do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
180 181
      project = FactoryGirl.create :empty_project, runners_token: 'my-token'
      expect(project.runners_token).to eq('my-token')
182 183
    end
  end
gitlabhq's avatar
gitlabhq committed
184

185
  describe 'Respond to' do
186 187 188 189 190 191
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:update_merge_requests) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
gitlabhq's avatar
gitlabhq committed
192 193
  end

194 195 196 197 198 199 200
  describe '#name_with_namespace' do
    let(:project) { build_stubbed(:empty_project) }

    it { expect(project.name_with_namespace).to eq "#{project.namespace.human_name} / #{project.name}" }
    it { expect(project.human_name).to eq project.name_with_namespace }
  end

201 202 203 204 205 206 207 208
  describe '#to_reference' do
    let(:project) { create(:empty_project) }

    it 'returns a String reference to the object' do
      expect(project.to_reference).to eq project.path_with_namespace
    end
  end

209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226
  describe '#repository_storage_path' do
    let(:project) { create(:project, repository_storage: 'custom') }

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
      storages = { 'custom' => 'tmp/tests/custom_repositories' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

227 228
  it 'should return valid url to repo' do
    project = Project.new(path: 'somewhere')
229
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
gitlabhq's avatar
gitlabhq committed
230 231
  end

Douwe Maan's avatar
Douwe Maan committed
232 233 234 235 236 237
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
238 239
  end

Douwe Maan's avatar
Douwe Maan committed
240 241 242 243 244 245
  describe "#web_url_without_protocol" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the web URL without the protocol for this repo' do
      expect(project.web_url_without_protocol).to eq("#{Gitlab.config.gitlab.url.split('://')[1]}/#{project.namespace.path}/somewhere")
    end
246 247
  end

248
  describe 'last_activity methods' do
249
    let(:project) { create(:project) }
250
    let(:last_event) { double(created_at: Time.now) }
gitlabhq's avatar
gitlabhq committed
251

252 253
    describe 'last_activity' do
      it 'should alias last_activity to last_event' do
254
        allow(project).to receive(:last_event).and_return(last_event)
255
        expect(project.last_activity).to eq(last_event)
256
      end
gitlabhq's avatar
gitlabhq committed
257 258
    end

259 260
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
261
        create(:event, project: project)
262
        expect(project.last_activity_at.to_i).to eq(last_event.created_at.to_i)
263
      end
264

265
      it 'returns the project\'s last update date if it has no events' do
266
        expect(project.last_activity_date).to eq(project.updated_at)
267
      end
268 269
    end
  end
270

271 272
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
273
    let!(:issue)  { create(:issue, project: project) }
274 275 276 277 278 279

    context 'with default issues tracker' do
      it 'returns an issue' do
        expect(project.get_issue(issue.iid)).to eq issue
      end

280 281 282 283
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316
      it 'returns nil when no issue found' do
        expect(project.get_issue(999)).to be_nil
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
        issue = project.get_issue('FOO-1234')
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

317
  describe '#update_merge_requests' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
318
    let(:project) { create(:project) }
319 320 321 322
    let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
    let(:key) { create(:key, user_id: project.owner.id) }
    let(:prev_commit_id) { merge_request.commits.last.id }
    let(:commit_id) { merge_request.commits.first.id }
323

324
    it 'should close merge request if last commit from source branch was pushed to target branch' do
325 326
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.target_branch}", key.user)
      merge_request.reload
327
      expect(merge_request.merged?).to be_truthy
328 329
    end

330
    it 'should update merge request commits with new one if pushed to source branch' do
331 332
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.source_branch}", key.user)
      merge_request.reload
333
      expect(merge_request.diff_head_sha).to eq(commit_id)
334 335
    end
  end
336

337
  describe '.find_with_namespace' do
338 339 340
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
341
        @project = create(:project, name: 'gitlabhq', namespace: @group)
342 343
      end

344
      it { expect(Project.find_with_namespace('gitlab/gitlabhq')).to eq(@project) }
345
      it { expect(Project.find_with_namespace('GitLab/GitlabHQ')).to eq(@project) }
346
      it { expect(Project.find_with_namespace('gitlab-ci')).to be_nil }
347
    end
348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363

    context 'when multiple projects using a similar name exist' do
      let(:group) { create(:group, name: 'gitlab') }

      let!(:project1) do
        create(:empty_project, name: 'gitlab1', path: 'gitlab', namespace: group)
      end

      let!(:project2) do
        create(:empty_project, name: 'gitlab2', path: 'GITLAB', namespace: group)
      end

      it 'returns the row where the path matches literally' do
        expect(Project.find_with_namespace('gitlab/GITLAB')).to eq(project2)
      end
    end
364 365
  end

366
  describe '#to_param' do
367 368 369
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
370
        @project = create(:project, name: 'gitlabhq', namespace: @group)
371 372
      end

Vinnie Okada's avatar
Vinnie Okada committed
373
      it { expect(@project.to_param).to eq('gitlabhq') }
374 375
    end
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
376

377
  describe '#repository' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
378 379
    let(:project) { create(:project) }

380
    it 'returns valid repo' do
381
      expect(project.repository).to be_kind_of(Repository)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
382 383
    end
  end
384

385
  describe '#default_issues_tracker?' do
386 387 388 389
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    it "should be true if used internal tracker" do
390
      expect(project.default_issues_tracker?).to be_truthy
391 392 393
    end

    it "should be false if used other tracker" do
394
      expect(ext_project.default_issues_tracker?).to be_falsey
395 396 397
    end
  end

398
  describe '#external_issue_tracker' do
399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
      before(:each) do
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      project.build_missing_services
      project.reload

      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      ext_project.build_missing_services
      ext_project.reload

      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

439
  describe '#cache_has_external_issue_tracker' do
440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
    let(:project) { create(:project) }

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

461
  describe '#external_wiki' do
462 463
    let(:project) { create(:project) }

464 465 466 467 468
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
469

470 471 472
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
473

474 475
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
476

477 478 479 480
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
481 482
    end

483 484 485 486
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
487

488 489 490
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
491 492
    end

493 494 495 496
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
497

498 499 500 501 502 503 504 505 506 507 508
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
509 510 511
    end
  end

512
  describe '#open_branches' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
513
    let(:project) { create(:project) }
514 515 516 517 518

    before do
      project.protected_branches.create(name: 'master')
    end

519 520
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
521

522
    it "includes branches matching a protected branch wildcard" do
523 524 525 526
      expect(project.open_branches.map(&:name)).to include('feature')

      create(:protected_branch, name: 'feat*', project: project)

527
      expect(Project.find(project.id).open_branches.map(&:name)).to include('feature')
528
    end
529
  end
Ciro Santilli's avatar
Ciro Santilli committed
530

531 532
  describe '#star_count' do
    it 'counts stars from multiple users' do
Ciro Santilli's avatar
Ciro Santilli committed
533 534 535 536 537
      user1 = create :user
      user2 = create :user
      project = create :project, :public

      expect(project.star_count).to eq(0)
538

Ciro Santilli's avatar
Ciro Santilli committed
539
      user1.toggle_star(project)
540 541
      expect(project.reload.star_count).to eq(1)

Ciro Santilli's avatar
Ciro Santilli committed
542
      user2.toggle_star(project)
543 544 545
      project.reload
      expect(project.reload.star_count).to eq(2)

Ciro Santilli's avatar
Ciro Santilli committed
546
      user1.toggle_star(project)
547 548 549
      project.reload
      expect(project.reload.star_count).to eq(1)

Ciro Santilli's avatar
Ciro Santilli committed
550
      user2.toggle_star(project)
551 552 553 554
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

555
    it 'counts stars on the right project' do
556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
Ciro Santilli's avatar
Ciro Santilli committed
586 587
    end
  end
588

589
  describe '#avatar_type' do
590 591 592 593
    let(:project) { create(:project) }

    it 'should be true if avatar is image' do
      project.update_attribute(:avatar, 'uploads/avatar.png')
594
      expect(project.avatar_type).to be_truthy
595 596 597 598
    end

    it 'should be false if avatar is html page' do
      project.update_attribute(:avatar, 'uploads/avatar.html')
599
      expect(project.avatar_type).to eq(['only images allowed'])
600 601
    end
  end
sue445's avatar
sue445 committed
602

603
  describe '#avatar_url' do
sue445's avatar
sue445 committed
604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631
    subject { project.avatar_url }

    let(:project) { create(:project) }

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end
632 633 634 635 636 637

    context 'when git repo is empty' do
      let(:project) { create(:empty_project) }

      it { should eq nil }
    end
sue445's avatar
sue445 committed
638
  end
639

640
  describe '#pipeline' do
641
    let(:project) { create :project }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
642
    let(:pipeline) { create :ci_pipeline, project: project, ref: 'master' }
643

644
    subject { project.pipeline(pipeline.sha, 'master') }
645

646
    it { is_expected.to eq(pipeline) }
647 648

    context 'return latest' do
649
      let(:pipeline2) { create :ci_pipeline, project: project, ref: 'master' }
650 651

      before do
652 653
        pipeline
        pipeline2
654 655
      end

656
      it { is_expected.to eq(pipeline2) }
657
    end
658
  end
659

660
  describe '#builds_enabled' do
661 662
    let(:project) { create :project }

663
    before { project.builds_enabled = true }
664

665 666 667
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
668
  end
669 670

  describe '.trending' do
Felipe Artur's avatar
Felipe Artur committed
671
    let(:group)    { create(:group, :public) }
672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)
    end

    describe 'without an explicit start date' do
      subject { described_class.trending.to_a }

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project1, project2])
      end
    end

    describe 'with an explicit start date' do
      let(:date) { 2.months.ago }

      subject { described_class.trending(date).to_a }

      before do
        2.times do
698 699 700
          # Little fix for special issue related to Fractional Seconds support for MySQL.
          # See: https://github.com/rails/rails/pull/14359/files
          create(:note_on_commit, project: project2, created_at: date + 1)
701 702 703 704 705 706 707 708
        end
      end

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project2, project1])
      end
    end
  end
709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727

  describe '.visible_to_user' do
    let!(:project) { create(:project, :private) }
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
        project.team.add_user(user, Gitlab::Access::MASTER)
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
728

729 730 731 732 733 734 735 736 737 738 739 740 741 742 743
  context 'repository storage by default' do
    let(:project) { create(:empty_project) }

    subject { project.repository_storage }

    before do
      storages = { 'alternative_storage' => '/some/path' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      stub_application_setting(repository_storage: 'alternative_storage')
      allow_any_instance_of(Project).to receive(:ensure_dir_exist).and_return(true)
    end

    it { is_expected.to eq('alternative_storage') }
  end

744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761
  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

762
  describe '#any_runners' do
763
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
764 765
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
766 767 768

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
769

770 771 772
      it 'there are no runners available' do
        expect(project.any_runners?).to be_falsey
      end
773

774
      it 'there is a specific runner' do
775
        project.runners << specific_runner
776 777
        expect(project.any_runners?).to be_truthy
      end
778

779 780 781 782
      it 'there is a shared runner, but they are prohibited to use' do
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
783

784
      it 'checks the presence of specific runner' do
785
        project.runners << specific_runner
786 787 788
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
789

790 791
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
792

793 794 795 796 797 798 799 800 801 802 803
      it 'there is a shared runner' do
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
804 805

  describe '#visibility_level_allowed?' do
806
    let(:project) { create(:project, :internal) }
807 808 809 810 811 812 813 814

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
815 816
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
817 818 819 820 821

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
822
  end
823

824 825
  describe '.search' do
    let(:project) { create(:project, description: 'kitten mittens') }
826

827 828 829
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
830

831 832 833
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
834

835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
874 875 876 877 878

    it 'returns projects when eager loading namespaces' do
      relation = described_class.all.includes(:namespace)

      expect(relation.search(project.namespace.name)).to eq([project])
879
    end
880
  end
881 882 883 884 885 886 887 888 889 890 891

  describe '#rename_repo' do
    let(:project) { create(:project) }
    let(:gitlab_shell) { Gitlab::Shell.new }

    before do
      # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
      # call. This makes testing a bit easier.
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

      allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
Kamil Trzcinski's avatar
Kamil Trzcinski committed
892
    end
893

Kamil Trzcinski's avatar
Kamil Trzcinski committed
894
    it 'renames a repository' do
895 896 897 898
      ns = project.namespace_dir

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
899
        with(project.repository_storage_path, "#{ns}/foo", "#{ns}/#{project.path}").
900 901 902 903
        and_return(true)

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
904
        with(project.repository_storage_path, "#{ns}/foo.wiki", "#{ns}/#{project.path}.wiki").
905 906 907 908 909 910 911 912 913 914 915 916 917 918
        and_return(true)

      expect_any_instance_of(SystemHooksService).
        to receive(:execute_hooks_for).
        with(project, :rename)

      expect_any_instance_of(Gitlab::UploadsTransfer).
        to receive(:rename_project).
        with('foo', project.path, ns)

      expect(project).to receive(:expire_caches_before_rename)

      project.rename_repo
    end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
919 920 921 922 923 924 925 926 927 928 929

    context 'container registry with tags' do
      before do
        stub_container_registry_config(enabled: true)
        stub_container_registry_tags('tag')
      end

      subject { project.rename_repo }

      it { expect{subject}.to raise_error(Exception) }
    end
930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945
  end

  describe '#expire_caches_before_rename' do
    let(:project) { create(:project) }
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
      allow(Repository).to receive(:new).
        with('foo', project).
        and_return(repo)

      allow(Repository).to receive(:new).
        with('foo.wiki', project).
        and_return(wiki)

946 947
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
948 949 950 951

      project.expire_caches_before_rename('foo')
    end
  end
952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967

  describe '.search_by_title' do
    let(:project) { create(:project, name: 'kittens') }

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
968 969 970 971 972

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

Douwe Maan's avatar
Douwe Maan committed
973 974
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
975 976 977 978 979 980 981 982 983

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
984

985 986 987 988 989 990 991 992 993 994 995
  describe '#create_repository' do
    let(:project) { create(:project) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
        expect(shell).to receive(:add_repository).
996
          with(project.repository_storage_path, project.path_with_namespace).
997 998 999 1000 1001 1002 1003 1004 1005
          and_return(true)

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
        expect(shell).to receive(:add_repository).
1006
          with(project.repository_storage_path, project.path_with_namespace).
1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024
          and_return(false)

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1025 1026 1027 1028

  describe '#protected_branch?' do
    let(:project) { create(:empty_project) }

1029
    it 'returns true when the branch matches a protected branch via direct match' do
1030 1031 1032 1033 1034
      project.protected_branches.create!(name: 'foo')

      expect(project.protected_branch?('foo')).to eq(true)
    end

1035 1036 1037 1038 1039 1040 1041
    it 'returns true when the branch matches a protected branch via wildcard match' do
      project.protected_branches.create!(name: 'production/*')

      expect(project.protected_branch?('production/some-branch')).to eq(true)
    end

    it 'returns false when the branch does not match a protected branch via direct match' do
1042 1043
      expect(project.protected_branch?('foo')).to eq(false)
    end
1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089

    it 'returns false when the branch does not match a protected branch via wildcard match' do
      project.protected_branches.create!(name: 'production/*')

      expect(project.protected_branch?('staging/some-branch')).to eq(false)
    end
  end

  describe "#developers_can_push_to_protected_branch?" do
    let(:project) { create(:empty_project) }

    context "when the branch matches a protected branch via direct match" do
      it "returns true if 'Developers can Push' is turned on" do
        create(:protected_branch, name: "production", project: project, developers_can_push: true)

        expect(project.developers_can_push_to_protected_branch?('production')).to be true
      end

      it "returns false if 'Developers can Push' is turned off" do
        create(:protected_branch, name: "production", project: project, developers_can_push: false)

        expect(project.developers_can_push_to_protected_branch?('production')).to be false
      end
    end

    context "when the branch matches a protected branch via wilcard match" do
      it "returns true if 'Developers can Push' is turned on" do
        create(:protected_branch, name: "production/*", project: project, developers_can_push: true)

        expect(project.developers_can_push_to_protected_branch?('production/some-branch')).to be true
      end

      it "returns false if 'Developers can Push' is turned off" do
        create(:protected_branch, name: "production/*", project: project, developers_can_push: false)

        expect(project.developers_can_push_to_protected_branch?('production/some-branch')).to be false
      end
    end

    context "when the branch does not match a protected branch" do
      it "returns false" do
        create(:protected_branch, name: "production/*", project: project, developers_can_push: true)

        expect(project.developers_can_push_to_protected_branch?('staging/some-branch')).to be false
      end
    end
1090
  end
1091

1092 1093 1094 1095 1096 1097 1098 1099 1100
  describe '#container_registry_path_with_namespace' do
    let(:project) { create(:empty_project, path: 'PROJECT') }

    subject { project.container_registry_path_with_namespace }

    it { is_expected.not_to eq(project.path_with_namespace) }
    it { is_expected.to eq(project.path_with_namespace.downcase) }
  end

1101 1102 1103
  describe '#container_registry_repository' do
    let(:project) { create(:empty_project) }

Kamil Trzcinski's avatar
Kamil Trzcinski committed
1104 1105
    before { stub_container_registry_config(enabled: true) }

1106 1107
    subject { project.container_registry_repository }

1108
    it { is_expected.not_to be_nil }
1109 1110 1111 1112 1113 1114 1115
  end

  describe '#container_registry_repository_url' do
    let(:project) { create(:empty_project) }

    subject { project.container_registry_repository_url }

1116
    before { stub_container_registry_config(**registry_settings) }
1117 1118 1119 1120 1121 1122 1123 1124 1125

    context 'for enabled registry' do
      let(:registry_settings) do
        {
          enabled: true,
          host_port: 'example.com',
        }
      end

1126
      it { is_expected.not_to be_nil }
1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145
    end

    context 'for disabled registry' do
      let(:registry_settings) do
        {
          enabled: false
        }
      end

      it { is_expected.to be_nil }
    end
  end

  describe '#has_container_registry_tags?' do
    let(:project) { create(:empty_project) }

    subject { project.has_container_registry_tags? }

    context 'for enabled registry' do
1146
      before { stub_container_registry_config(enabled: true) }
1147 1148

      context 'with tags' do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1149
        before { stub_container_registry_tags('test', 'test2') }
1150 1151 1152 1153 1154

        it { is_expected.to be_truthy }
      end

      context 'when no tags' do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
1155
        before { stub_container_registry_tags }
1156 1157 1158 1159 1160 1161

        it { is_expected.to be_falsey }
      end
    end

    context 'for disabled registry' do
1162
      before { stub_container_registry_config(enabled: false) }
1163 1164 1165 1166

      it { is_expected.to be_falsey }
    end
  end
1167

1168
  describe '#latest_successful_builds_for' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1169
    def create_pipeline(status = 'success')
1170
      create(:ci_pipeline, project: project,
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1171
                           sha: project.commit.sha,
1172
                           ref: project.default_branch,
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1173
                           status: status)
1174 1175
    end

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1176 1177 1178
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1179
             status: new_pipeline.status,
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1180
             name: name)
1181 1182
    end

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1183 1184
    let(:project) { create(:project) }
    let(:pipeline) { create_pipeline }
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1185 1186

    context 'with many builds' do
1187
      it 'gives the latest builds from latest pipeline' do
1188 1189
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1190
        build1_p2 = create_build(pipeline2, 'test')
1191 1192
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1193
        build2_p2 = create_build(pipeline2, 'test2')
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1194 1195 1196

        latest_builds = project.latest_successful_builds_for

1197
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1198 1199
      end
    end
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1200

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1201
    context 'with succeeded pipeline' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1202
      let!(:build) { create_build }
1203

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1204
      context 'standalone pipeline' do
1205 1206 1207 1208 1209 1210 1211 1212
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1213

1214 1215 1216
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1217 1218
      end

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1219
      context 'with some pending pipeline' do
1220
        before do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1221
          create_build(create_pipeline('pending'))
1222 1223
        end

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1224 1225
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1226

Lin Jen-Shin's avatar
Lin Jen-Shin committed
1227
          expect(latest_build).to contain_exactly(build)
1228
        end
1229 1230 1231 1232 1233 1234
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
Lin Jen-Shin's avatar
Lin Jen-Shin committed
1235
        create_build(pipeline)
1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278
  describe '.where_paths_in' do
    context 'without any paths' do
      it 'returns an empty relation' do
        expect(Project.where_paths_in([])).to eq([])
      end
    end

    context 'without any valid paths' do
      it 'returns an empty relation' do
        expect(Project.where_paths_in(%w[foo])).to eq([])
      end
    end

    context 'with valid paths' do
      let!(:project1) { create(:project) }
      let!(:project2) { create(:project) }

      it 'returns the projects matching the paths' do
        projects = Project.where_paths_in([project1.path_with_namespace,
                                           project2.path_with_namespace])

        expect(projects).to contain_exactly(project1, project2)
      end

      it 'returns projects regardless of the casing of paths' do
        projects = Project.where_paths_in([project1.path_with_namespace.upcase,
                                           project2.path_with_namespace.upcase])

        expect(projects).to contain_exactly(project1, project2)
      end
    end
  end
1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327

  describe 'authorized_for_user' do
    let(:group) { create(:group) }
    let(:developer) { create(:user) }
    let(:master) { create(:user) }
    let(:personal_project) { create(:project, namespace: developer.namespace) }
    let(:group_project) { create(:project, namespace: group) }
    let(:members_project) { create(:project) }
    let(:shared_project) { create(:project) }

    before do
      group.add_master(master)
      group.add_developer(developer)

      members_project.team << [developer, :developer]
      members_project.team << [master, :master]

      create(:project_group_link, project: shared_project, group: group)
    end

    it 'returns false for no user' do
      expect(personal_project.authorized_for_user?(nil)).to be(false)
    end

    it 'returns true for personal projects of the user' do
      expect(personal_project.authorized_for_user?(developer)).to be(true)
    end

    it 'returns true for projects of groups the user is a member of' do
      expect(group_project.authorized_for_user?(developer)).to be(true)
    end

    it 'returns true for projects for which the user is a member of' do
      expect(members_project.authorized_for_user?(developer)).to be(true)
    end

    it 'returns true for projects shared on a group the user is a member of' do
      expect(shared_project.authorized_for_user?(developer)).to be(true)
    end

    it 'checks for the correct minimum level access' do
      expect(group_project.authorized_for_user?(developer, Gitlab::Access::MASTER)).to be(false)
      expect(group_project.authorized_for_user?(master, Gitlab::Access::MASTER)).to be(true)
      expect(members_project.authorized_for_user?(developer, Gitlab::Access::MASTER)).to be(false)
      expect(members_project.authorized_for_user?(master, Gitlab::Access::MASTER)).to be(true)
      expect(shared_project.authorized_for_user?(developer, Gitlab::Access::MASTER)).to be(false)
      expect(shared_project.authorized_for_user?(master, Gitlab::Access::MASTER)).to be(true)
    end
  end
gitlabhq's avatar
gitlabhq committed
1328
end