Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
11ba5ccd
Commit
11ba5ccd
authored
Oct 24, 2018
by
Heinrich Lee Yu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Always show new issue in Open list
parent
54db08f2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
10 deletions
+15
-10
app/views/shared/boards/components/_board.html.haml
app/views/shared/boards/components/_board.html.haml
+7
-8
spec/features/boards/new_issue_spec.rb
spec/features/boards/new_issue_spec.rb
+8
-2
No files found.
app/views/shared/boards/components/_board.html.haml
View file @
11ba5ccd
...
...
@@ -39,14 +39,13 @@
{{ list.issuesSize }}
=
render_if_exists
"shared/boards/components/list_weight"
-
if
can?
(
current_user
,
:admin_list
,
current_board_parent
)
%button
.issue-count-badge-add-button.btn.btn-sm.btn-default.ml-1.has-tooltip.js-no-trigger-collapse
{
type:
"button"
,
"@click"
=>
"showNewIssueForm"
,
"v-if"
=>
'list.type !== "closed"'
,
"aria-label"
=>
_
(
"New issue"
),
"title"
=>
_
(
"New issue"
),
data:
{
placement:
"top"
,
container:
"body"
}
}
=
icon
(
"plus"
,
class:
"js-no-trigger-collapse"
)
%button
.issue-count-badge-add-button.btn.btn-sm.btn-default.ml-1.has-tooltip.js-no-trigger-collapse
{
type:
"button"
,
"@click"
=>
"showNewIssueForm"
,
"v-if"
=>
'list.type == "backlog" || (!disabled && list.type !== "closed")'
,
"aria-label"
=>
_
(
"New issue"
),
"title"
=>
_
(
"New issue"
),
data:
{
placement:
"top"
,
container:
"body"
}
}
=
icon
(
"plus"
,
class:
"js-no-trigger-collapse"
)
%board-list
{
"v-if"
=>
'list.type !== "blank" && list.type !== "promotion"'
,
":list"
=>
"list"
,
...
...
spec/features/boards/new_issue_spec.rb
View file @
11ba5ccd
...
...
@@ -94,8 +94,14 @@ describe 'Issue Boards new issue', :js do
wait_for_requests
end
it
'does not display new issue button'
do
expect
(
page
).
to
have_selector
(
'.issue-count-badge-add-button'
,
count:
0
)
it
'displays new issue button in open list'
do
expect
(
first
(
'.board'
)).
to
have_selector
(
'.issue-count-badge-add-button'
,
count:
1
)
end
it
'does not display new issue button in label list'
do
page
.
within
(
'.board:nth-child(2)'
)
do
expect
(
page
).
not_to
have_selector
(
'.issue-count-badge-add-button'
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment