Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
17a73017
Commit
17a73017
authored
Apr 18, 2016
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove additional misuse of `data-original-title` attribute
parent
7cc23952
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
app/helpers/projects_helper.rb
app/helpers/projects_helper.rb
+1
-1
app/views/shared/milestones/_issuable.html.haml
app/views/shared/milestones/_issuable.html.haml
+1
-1
spec/features/issues/update_issues_spec.rb
spec/features/issues/update_issues_spec.rb
+1
-1
No files found.
app/helpers/projects_helper.rb
View file @
17a73017
...
@@ -52,7 +52,7 @@ module ProjectsHelper
...
@@ -52,7 +52,7 @@ module ProjectsHelper
link_to
(
author_html
,
user_path
(
author
),
class:
"author_link
#{
"
#{
opts
[
:mobile_classes
]
}
"
if
opts
[
:mobile_classes
]
}
"
).
html_safe
link_to
(
author_html
,
user_path
(
author
),
class:
"author_link
#{
"
#{
opts
[
:mobile_classes
]
}
"
if
opts
[
:mobile_classes
]
}
"
).
html_safe
else
else
title
=
opts
[
:title
].
sub
(
":name"
,
sanitize
(
author
.
name
))
title
=
opts
[
:title
].
sub
(
":name"
,
sanitize
(
author
.
name
))
link_to
(
author_html
,
user_path
(
author
),
class:
"author_link has-tooltip"
,
data:
{
'original-title'
.
to_sym
=>
title
,
container:
'body'
}
).
html_safe
link_to
(
author_html
,
user_path
(
author
),
class:
"author_link has-tooltip"
,
title:
title
,
data:
{
container:
'body'
}
).
html_safe
end
end
end
end
...
...
app/views/shared/milestones/_issuable.html.haml
View file @
17a73017
...
@@ -23,5 +23,5 @@
...
@@ -23,5 +23,5 @@
-
if
assignee
-
if
assignee
=
link_to
polymorphic_path
(
base_url_args
,
{
milestone_title:
@milestone
.
title
,
assignee_id:
issuable
.
assignee_id
,
state:
'all'
}),
=
link_to
polymorphic_path
(
base_url_args
,
{
milestone_title:
@milestone
.
title
,
assignee_id:
issuable
.
assignee_id
,
state:
'all'
}),
class:
'has-tooltip'
,
data:
{
'original-title'
=>
"Assigned to
#{
sanitize
(
assignee
.
name
)
}
"
,
container:
'body'
}
do
class:
'has-tooltip'
,
title:
"Assigned to
#{
assignee
.
name
}
"
,
data:
{
container:
'body'
}
do
-
image_tag
(
avatar_icon
(
issuable
.
assignee
,
16
),
class:
"avatar s16"
,
alt:
''
)
-
image_tag
(
avatar_icon
(
issuable
.
assignee
,
16
),
class:
"avatar s16"
,
alt:
''
)
spec/features/issues/update_issues_spec.rb
View file @
17a73017
...
@@ -48,7 +48,7 @@ feature 'Multiple issue updating from issues#index', feature: true do
...
@@ -48,7 +48,7 @@ feature 'Multiple issue updating from issues#index', feature: true do
click_update_issues_button
click_update_issues_button
page
.
within
(
'.issue .controls'
)
do
page
.
within
(
'.issue .controls'
)
do
expect
(
find
(
'.author_link'
)[
"
data-original-
title"
]).
to
have_content
(
user
.
name
)
expect
(
find
(
'.author_link'
)[
"title"
]).
to
have_content
(
user
.
name
)
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment