Extract Variable into separate JSON Schema

spec/controllers/groups/variables_controller_spec.rb

@@ -19,7 +19,7 @@ describe Groups::VariablesController do
     it 'renders the ci_group_variable as json' do
       subject
 
-      expect(response).to match_response_schema('variable')
+      expect(response).to match_response_schema('variables')
     end
   end
 
@@ -85,7 +85,7 @@ describe Groups::VariablesController do
       it 'has all variables in response' do
         subject
 
-        expect(response).to match_response_schema('variable')
+        expect(response).to match_response_schema('variables')
       end
     end
 
@@ -111,7 +111,7 @@ describe Groups::VariablesController do
       it 'has all variables in response' do
         subject
 
-        expect(json_response['variables'].count).to eq(0)
+        expect(response).to match_response_schema('variables')
       end
     end
   end

spec/controllers/projects/variables_controller_spec.rb

@@ -24,7 +24,7 @@ describe Projects::VariablesController do
     it 'renders the ci_variable as json' do
       subject
 
-      expect(response).to match_response_schema('variable')
+      expect(response).to match_response_schema('variables')
     end
   end
 
@@ -94,7 +94,7 @@ describe Projects::VariablesController do
       it 'has all variables in response' do
         subject
 
-        expect(response).to match_response_schema('variable')
+        expect(response).to match_response_schema('variables')
       end
     end
 
@@ -120,7 +120,7 @@ describe Projects::VariablesController do
       it 'has all variables in response' do
         subject
 
-        expect(json_response['variables'].count).to eq(0)
+        expect(response).to match_response_schema('variables')
       end
     end
   end

spec/fixtures/api/schemas/variable.json

 {
   "type": "object",
-  "required": ["variables"],
+  "required": [
+    "id",
+    "key",
+    "value",
+    "protected"
+  ],
   "properties": {
-    "variables": {
-      "type": "array",
-      "items": {
-        "required": [
-          "id",
-          "key",
-          "value",
-          "protected"
-        ],
-        "properties": {
-          "id": { "type": "integer" },
-          "key": { "type": "string" },
-          "value": { "type": "string" },
-          "protected": { "type": "boolean" }
-        }
-      }
-    }
+    "id": { "type": "integer" },
+    "key": { "type": "string" },
+    "value": { "type": "string" },
+    "protected": { "type": "boolean" }
   },
   "additionalProperties": false
 }

spec/fixtures/api/schemas/variables.json

+{
+  "type": "object",
+  "required": ["variables"],
+  "properties": {
+    "variables": {
+      "type": "array",
+      "items": { "$ref": "variable.json" }
+    }
+  },
+  "additionalProperties": false
+}