Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
1fa7274c
Commit
1fa7274c
authored
Aug 03, 2016
by
Douglas Barbosa Alexandre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename `list_id` param to `id` in Boards::Issues::ListService
parent
64d75595
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
app/services/boards/issues/list_service.rb
app/services/boards/issues/list_service.rb
+1
-1
spec/services/boards/issues/list_service_spec.rb
spec/services/boards/issues/list_service_spec.rb
+4
-4
No files found.
app/services/boards/issues/list_service.rb
View file @
1fa7274c
...
@@ -10,7 +10,7 @@ module Boards
...
@@ -10,7 +10,7 @@ module Boards
private
private
def
list
def
list
@list
||=
board
.
lists
.
find
(
params
[
:
list_
id
])
@list
||=
board
.
lists
.
find
(
params
[
:id
])
end
end
def
filter_params
def
filter_params
...
...
spec/services/boards/issues/list_service_spec.rb
View file @
1fa7274c
...
@@ -37,7 +37,7 @@ describe Boards::Issues::ListService, services: true do
...
@@ -37,7 +37,7 @@ describe Boards::Issues::ListService, services: true do
end
end
it
'delegates search to IssuesFinder'
do
it
'delegates search to IssuesFinder'
do
params
=
{
list_
id:
list1
.
id
}
params
=
{
id:
list1
.
id
}
expect_any_instance_of
(
IssuesFinder
).
to
receive
(
:execute
).
once
expect_any_instance_of
(
IssuesFinder
).
to
receive
(
:execute
).
once
...
@@ -46,7 +46,7 @@ describe Boards::Issues::ListService, services: true do
...
@@ -46,7 +46,7 @@ describe Boards::Issues::ListService, services: true do
context
'sets default order to priority'
do
context
'sets default order to priority'
do
it
'returns opened issues when listing issues from Backlog'
do
it
'returns opened issues when listing issues from Backlog'
do
params
=
{
list_
id:
backlog
.
id
}
params
=
{
id:
backlog
.
id
}
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
...
@@ -54,7 +54,7 @@ describe Boards::Issues::ListService, services: true do
...
@@ -54,7 +54,7 @@ describe Boards::Issues::ListService, services: true do
end
end
it
'returns closed issues when listing issues from Done'
do
it
'returns closed issues when listing issues from Done'
do
params
=
{
list_
id:
done
.
id
}
params
=
{
id:
done
.
id
}
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
...
@@ -62,7 +62,7 @@ describe Boards::Issues::ListService, services: true do
...
@@ -62,7 +62,7 @@ describe Boards::Issues::ListService, services: true do
end
end
it
'returns opened issues that have label list applied when listing issues from a label list'
do
it
'returns opened issues that have label list applied when listing issues from a label list'
do
params
=
{
list_
id:
list1
.
id
}
params
=
{
id:
list1
.
id
}
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment