Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
2e182f33
Commit
2e182f33
authored
Feb 14, 2019
by
Takuya Noguchi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix alignment of dropdown icon on issuable on mobile
Signed-off-by:
Takuya Noguchi
<
takninnovationresearch@gmail.com
>
parent
bd17881b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
22 deletions
+6
-22
app/views/shared/issuable/_sort_dropdown.html.haml
app/views/shared/issuable/_sort_dropdown.html.haml
+1
-1
changelogs/unreleased/57582-dropdown-icon-misalignment-on-issues-list-on-mobile-screen.yml
...own-icon-misalignment-on-issues-list-on-mobile-screen.yml
+5
-0
spec/features/issues/filtered_search/visual_tokens_spec.rb
spec/features/issues/filtered_search/visual_tokens_spec.rb
+0
-21
No files found.
app/views/shared/issuable/_sort_dropdown.html.haml
View file @
2e182f33
...
@@ -5,7 +5,7 @@
...
@@ -5,7 +5,7 @@
.dropdown.inline.prepend-left-10.issue-sort-dropdown
.dropdown.inline.prepend-left-10.issue-sort-dropdown
.btn-group
{
role:
'group'
}
.btn-group
{
role:
'group'
}
.btn-group
{
role:
'group'
}
.btn-group
{
role:
'group'
}
%button
.dropdown-toggle
{
type:
'button'
,
data:
{
toggle:
'dropdown'
,
display:
'static'
},
class:
'btn btn-default'
}
%button
.dropdown-
menu-
toggle
{
type:
'button'
,
data:
{
toggle:
'dropdown'
,
display:
'static'
},
class:
'btn btn-default'
}
=
sort_title
=
sort_title
=
icon
(
'chevron-down'
)
=
icon
(
'chevron-down'
)
%ul
.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
%ul
.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
...
...
changelogs/unreleased/57582-dropdown-icon-misalignment-on-issues-list-on-mobile-screen.yml
0 → 100644
View file @
2e182f33
---
title
:
Fix alignment of dropdown icon on issuable on mobile
merge_request
:
25205
author
:
Takuya Noguchi
type
:
fixed
spec/features/issues/filtered_search/visual_tokens_spec.rb
View file @
2e182f33
...
@@ -59,13 +59,6 @@ describe 'Visual tokens', :js do
...
@@ -59,13 +59,6 @@ describe 'Visual tokens', :js do
expect
(
page
).
to
have_css
(
'#js-dropdown-author'
,
visible:
false
)
expect
(
page
).
to
have_css
(
'#js-dropdown-author'
,
visible:
false
)
end
end
it
'ends editing mode when scroll container is clicked'
do
find
(
'.scroll-container'
).
click
expect_filtered_search_input_empty
expect
(
page
).
to
have_css
(
'#js-dropdown-author'
,
visible:
false
)
end
describe
'selecting different author from dropdown'
do
describe
'selecting different author from dropdown'
do
before
do
before
do
filter_author_dropdown
.
find
(
'.filter-dropdown-item .dropdown-light-content'
,
text:
"@
#{
user_rock
.
username
}
"
).
click
filter_author_dropdown
.
find
(
'.filter-dropdown-item .dropdown-light-content'
,
text:
"@
#{
user_rock
.
username
}
"
).
click
...
@@ -109,13 +102,6 @@ describe 'Visual tokens', :js do
...
@@ -109,13 +102,6 @@ describe 'Visual tokens', :js do
expect
(
page
).
to
have_css
(
'#js-dropdown-assignee'
,
visible:
false
)
expect
(
page
).
to
have_css
(
'#js-dropdown-assignee'
,
visible:
false
)
end
end
it
'ends editing mode when scroll container is clicked'
do
find
(
'.scroll-container'
).
click
expect_filtered_search_input_empty
expect
(
page
).
to
have_css
(
'#js-dropdown-assignee'
,
visible:
false
)
end
describe
'selecting static option from dropdown'
do
describe
'selecting static option from dropdown'
do
before
do
before
do
find
(
"#js-dropdown-assignee"
).
find
(
'.filter-dropdown-item'
,
text:
'None'
).
click
find
(
"#js-dropdown-assignee"
).
find
(
'.filter-dropdown-item'
,
text:
'None'
).
click
...
@@ -167,13 +153,6 @@ describe 'Visual tokens', :js do
...
@@ -167,13 +153,6 @@ describe 'Visual tokens', :js do
expect_filtered_search_input_empty
expect_filtered_search_input_empty
expect
(
page
).
to
have_css
(
'#js-dropdown-milestone'
,
visible:
false
)
expect
(
page
).
to
have_css
(
'#js-dropdown-milestone'
,
visible:
false
)
end
end
it
'ends editing mode when scroll container is clicked'
do
find
(
'.scroll-container'
).
click
expect_filtered_search_input_empty
expect
(
page
).
to
have_css
(
'#js-dropdown-milestone'
,
visible:
false
)
end
end
end
describe
'editing label token'
do
describe
'editing label token'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment