Make notes for merge requests include commit notes and add helpers

app/contexts/notes/load_context.rb

@@ -13,7 +13,7 @@ module Notes
                when "issue"
                  project.issues.find(target_id).notes.inc_author.fresh.limit(20)
                when "merge_request"
-                 project.merge_requests.find(target_id).notes.inc_author.fresh.limit(20)
+                 project.merge_requests.find(target_id).mr_and_commit_notes.inc_author.fresh.limit(20)
                when "snippet"
                  project.snippets.find(target_id).notes.fresh
                when "wall"

app/controllers/notes_controller.rb

@@ -7,6 +7,11 @@ class NotesController < ProjectResourceController
 
   def index
     notes
+    if params[:target_type] == "merge_request"
+      @mixed_targets = true
+      @main_target_type = params[:target_type].camelize
+    end
+
     respond_with(@notes)
   end
 

app/helpers/notes_helper.rb

@@ -7,6 +7,11 @@ module NotesHelper
     params[:loading_new].present?
   end
 
+   # Helps to distinguish e.g. commit notes in mr notes list
+  def note_for_main_target?(note)
+    !@mixed_targets || @main_target_type == note.noteable_type
+  end
+
   def note_vote_class(note)
     if note.upvote?
       "vote upvote"

app/models/note.rb

@@ -49,7 +49,7 @@ class Note < ActiveRecord::Base
   end
 
   def target
-    if noteable_type == "Commit"
+    if commit?
       project.commit(noteable_id)
     else
       noteable
@@ -82,6 +82,10 @@ class Note < ActiveRecord::Base
     noteable_type == "Commit"
   end
 
+  def line_note?
+    line_code.present?
+  end
+
   def commit_author
     @commit_author ||=
       project.users.find_by_email(target.author_email) ||