Merge branch 'after-script' into make-before-after-overridable

doc/ci/yaml/README.md

@@ -126,6 +126,9 @@ builds, including deploy builds. This can be an array or a multi-line string.
 
 ### after_script
 
+>**Note:**
+Introduced in GitLab 8.7 and GitLab Runner v1.2.
+
 `after_script` is used to define the command that will be run after for all
 builds. This has to be an array or a multi-line string.
 

lib/ci/gitlab_ci_yaml_processor.rb

@@ -92,6 +92,29 @@ module Ci
     end
 
     def validate!
+      validate_global!
+
+      @jobs.each do |name, job|
+        validate_job!(name, job)
+      end
+
+      true
+    end
+
+    def validate_job!(name, job)
+      validate_job_name!(name)
+      validate_job_keys!(name, job)
+      validate_job_types!(name, job)
+
+      validate_job_stage!(name, job) if job[:stage]
+      validate_job_cache!(name, job) if job[:cache]
+      validate_job_artifacts!(name, job) if job[:artifacts]
+      validate_job_dependencies!(name, job) if job[:dependencies]
+    end
+
+    private
+
+    def validate_global!
       unless validate_array_of_strings(@before_script)
         raise ValidationError, "before_script should be an array of strings"
       end
@@ -116,40 +139,23 @@ module Ci
         raise ValidationError, "variables should be a map of key-valued strings"
       end
 
-      if @cache
-        if @cache[:key] && !validate_string(@cache[:key])
-          raise ValidationError, "cache:key parameter should be a string"
-        end
-
-        if @cache[:untracked] && !validate_boolean(@cache[:untracked])
-          raise ValidationError, "cache:untracked parameter should be an boolean"
-        end
+      validate_global_cache! if @cache
+    end
 
-        if @cache[:paths] && !validate_array_of_strings(@cache[:paths])
-          raise ValidationError, "cache:paths parameter should be an array of strings"
-        end
+    def validate_global_cache!
+      if @cache[:key] && !validate_string(@cache[:key])
+        raise ValidationError, "cache:key parameter should be a string"
       end
 
-      @jobs.each do |name, job|
-        validate_job!(name, job)
+      if @cache[:untracked] && !validate_boolean(@cache[:untracked])
+        raise ValidationError, "cache:untracked parameter should be an boolean"
       end
 
-      true
-    end
-
-    def validate_job!(name, job)
-      validate_job_name!(name)
-      validate_job_keys!(name, job)
-      validate_job_types!(name, job)
-
-      validate_job_stage!(name, job) if job[:stage]
-      validate_job_cache!(name, job) if job[:cache]
-      validate_job_artifacts!(name, job) if job[:artifacts]
-      validate_job_dependencies!(name, job) if job[:dependencies]
+      if @cache[:paths] && !validate_array_of_strings(@cache[:paths])
+        raise ValidationError, "cache:paths parameter should be an array of strings"
+      end
     end
 
-    private
-
     def validate_job_name!(name)
       if name.blank? || !validate_string(name)
         raise ValidationError, "job name should be non-empty string"

spec/lib/ci/gitlab_ci_yaml_processor_spec.rb

@@ -335,12 +335,12 @@ module Ci
 
       describe "after_script" do
         context "in global context" do
-          let(:config) {
+          let(:config) do
             {
               after_script: ["after_script"],
               test: { script: ["script"] }
             }
-          }
+          end
 
           it "return after_script in options" do
             expect(subject[:options][:after_script]).to eq(["after_script"])