Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
44cb5803
Commit
44cb5803
authored
Jul 14, 2016
by
Phil Hughes
Committed by
Douwe Maan
Jul 24, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Seperated resolve all button from reply button
parent
c1fe066b
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
25 additions
and
20 deletions
+25
-20
app/assets/stylesheets/pages/note_form.scss
app/assets/stylesheets/pages/note_form.scss
+20
-15
app/views/discussions/_diff_discussion.html.haml
app/views/discussions/_diff_discussion.html.haml
+3
-3
app/views/projects/notes/_note.html.haml
app/views/projects/notes/_note.html.haml
+1
-1
app/views/projects/notes/discussions/_resolve_all.html.haml
app/views/projects/notes/discussions/_resolve_all.html.haml
+1
-1
No files found.
app/assets/stylesheets/pages/note_form.scss
View file @
44cb5803
...
@@ -156,28 +156,33 @@
...
@@ -156,28 +156,33 @@
.discussion-reply-holder
{
.discussion-reply-holder
{
background-color
:
$white-light
;
background-color
:
$white-light
;
padding
:
10px
16px
;
padding
:
10px
16px
;
}
}
.btn-group-justified
{
.discussion-with-resolve-btn
{
table-layout
:
auto
;
display
:
table
;
}
width
:
100%
;
border-collapse
:
separate
;
table-layout
:
auto
;
.btn-group
{
display
:
table-cell
;
float
:
none
;
width
:
1%
;
.btn-group
:first-child
{
&
:first-child
{
width
:
100%
;
width
:
100%
;
padding-right
:
5px
;
}
}
.discussion-with-resolve-btn
{
&
:last-child
{
.btn-group
:first-child
.btn
{
padding-left
:
5px
;
border-top-right-radius
:
0
;
border-bottom-right-radius
:
0
;
}
.btn-group
:last-child
.btn
{
margin-left
:
-1px
;
border-top-left-radius
:
0
;
border-bottom-left-radius
:
0
;
}
}
}
}
}
.btn
{
width
:
100%
;
}
}
}
.discussion-notes-count
{
.discussion-notes-count
{
...
...
app/views/discussions/_diff_discussion.html.haml
View file @
44cb5803
...
@@ -5,8 +5,8 @@
...
@@ -5,8 +5,8 @@
=
render
partial:
"projects/notes/note"
,
collection:
discussion
.
notes
,
as: :note
=
render
partial:
"projects/notes/note"
,
collection:
discussion
.
notes
,
as: :note
.discussion-reply-holder
.discussion-reply-holder
.
btn-group-justified.
discussion-with-resolve-btn
{
role:
"group"
}
.discussion-with-resolve-btn
{
role:
"group"
}
.btn-group
{
role:
"group"
}
.btn-group
=
link_to_reply_discussion
(
note
)
=
link_to_reply_discussion
(
note
)
.btn-group
{
role:
"group"
}
.btn-group
=
render
"projects/notes/discussions/resolve_all"
,
note:
note
=
render
"projects/notes/discussions/resolve_all"
,
note:
note
app/views/projects/notes/_note.html.haml
View file @
44cb5803
...
@@ -20,7 +20,7 @@
...
@@ -20,7 +20,7 @@
-
access
=
note_max_access_for_user
(
note
)
-
access
=
note_max_access_for_user
(
note
)
-
if
access
and
not
note
.
system
-
if
access
and
not
note
.
system
%span
.note-role.hidden-xs
=
access
%span
.note-role.hidden-xs
=
access
-
if
!
note
.
system
&&
current_user
-
if
!
note
.
system
&&
note
.
discussion_id
&&
current_user
%resolve-btn
{
":namespace"
=>
"'#{note.project.namespace.path}/#{note.project.path}'"
,
":discussion-id"
=>
"'#{note.discussion_id}'"
,
":note-id"
=>
note
.
id
,
":resolved"
=>
"false"
,
"inline-template"
=>
true
,
"v-ref:note_#{note.id}"
=>
true
}
%resolve-btn
{
":namespace"
=>
"'#{note.project.namespace.path}/#{note.project.path}'"
,
":discussion-id"
=>
"'#{note.discussion_id}'"
,
":note-id"
=>
note
.
id
,
":resolved"
=>
"false"
,
"inline-template"
=>
true
,
"v-ref:note_#{note.id}"
=>
true
}
.note-action-button
.note-action-button
=
icon
(
"spin spinner"
,
"v-show"
=>
"loading"
)
=
icon
(
"spin spinner"
,
"v-show"
=>
"loading"
)
...
...
app/views/projects/notes/discussions/_resolve_all.html.haml
View file @
44cb5803
%resolve-all
{
":namespace"
=>
"'#{note.project.namespace.path}/#{note.project.path}'"
,
":discussion-id"
=>
"'#{note.discussion_id}'"
,
"inline-template"
=>
true
,
"v-cloak"
=>
true
}
%resolve-all
{
":namespace"
=>
"'#{note.project.namespace.path}/#{note.project.path}'"
,
":discussion-id"
=>
"'#{note.discussion_id}'"
,
"inline-template"
=>
true
,
"v-cloak"
=>
true
}
%button
.btn.btn-
success
{
type:
"button"
,
"@click"
=>
"resolve"
,
":disabled"
=>
"loading"
}
%button
.btn.btn-
default
{
type:
"button"
,
"@click"
=>
"resolve"
,
":disabled"
=>
"loading"
}
=
icon
(
"spinner spin"
,
"v-show"
=>
"loading"
)
=
icon
(
"spinner spin"
,
"v-show"
=>
"loading"
)
{{ buttonText }}
{{ buttonText }}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment