Skip to content

G
gitlab-ce
Commit 4ce9f2fd authored by Marin Jankovski's avatar Marin Jankovski
Browse files
Options

Merge branch 'upgrade-eslint' into 'master' 

Upgrade eslint to v5.x

See merge request gitlab-org/gitlab-ce!21825
parents 17a4f24c aef686d4
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 428 additions and 324 deletions
.eslintrc.yml
View file @ 4ce9f2fd
......@@ -56,6 +56,10 @@ rules:
component: always
svg: always
math: always
camelcase:
- error
- properties: never
ignoreDestructuring: true
## Conflicting rules with prettier:
space-before-function-paren: off
curly: off
......@@ -63,7 +67,7 @@ rules:
function-paren-newline: off
object-curly-newline: off
padded-blocks: off
# Disabled for now, to make the eslint 3 -> eslint 4 update smoother
# Disabled for now, to make the eslint 3 -> eslint 5 update smoother
## Indent rule. We are using the old for now: https://eslint.org/docs/user-guide/migrating-to-4.0.0#indent-rewrite
indent: off
indent-legacy:
......@@ -78,3 +82,18 @@ rules:
FunctionExpression:
parameters: 1
body: 1
# Disabled for now, to make the airbnb-base 12.1.0 -> 13.1.0 update smoother
operator-linebreak: off
implicit-arrow-linebreak: off
no-else-return:
- error
- allowElseIf: true
import/no-useless-path-segments: off
lines-between-class-members: off
# Disabled for now, to make the plugin-vue 4.5 -> 5.0 update smoother
vue/html-closing-bracket-newline: off
vue/html-closing-bracket-spacing: off
vue/no-confusing-v-for-v-if: error
vue/no-unused-components: off
vue/no-use-v-if-with-v-for: off
vue/no-v-html: off
app/assets/javascripts/badges/components/badge.vue
View file @ 4ce9f2fd
......@@ -103,8 +103,8 @@ export default {
</div>
<button
v-tooltip
v-show="hasError"
v-tooltip
:title="s__('Badges|Reload badge image')"
class="btn btn-transparent btn-sm text-primary"
type="button"
......
app/assets/javascripts/boards/components/board_list.vue
View file @ 4ce9f2fd
......@@ -231,14 +231,14 @@ export default {
<board-card
v-for="(issue, index) in issues"
ref="issue"
:key="issue.id"
:index="index"
:list="list"
:issue="issue"
:issue-link-base="issueLinkBase"
:group-id="groupId"
:root-path="rootPath"
:disabled="disabled"
:key="issue.id" />
:disabled="disabled" />
<li
v-if="showCount"
class="board-list-count text-center"
......
app/assets/javascripts/boards/components/board_new_issue.vue
View file @ 4ce9f2fd
......@@ -110,9 +110,9 @@ export default {
Title
</label>
<input
:id="list.id + '-title'"
ref="input"
v-model="title"
:id="list.id + '-title'"
class="form-control"
type="text"
name="issue_title"
......
app/assets/javascripts/boards/components/issue_card_inner.vue
View file @ 4ce9f2fd
......@@ -170,8 +170,8 @@
tooltip-placement="bottom"
/>
<span
v-tooltip
v-if="shouldRenderCounter"
v-tooltip
:title="assigneeCounterTooltip"
class="avatar-counter"
>
......@@ -184,10 +184,10 @@
class="board-card-footer"
>
<button
v-tooltip
v-for="label in issue.labels"
v-if="showLabel(label)"
:key="label.id"
v-tooltip
:style="labelStyle(label)"
:title="label.description"
class="badge color-label"
......
app/assets/javascripts/boards/index.js
View file @ 4ce9f2fd
......@@ -9,7 +9,7 @@ import '~/vue_shared/models/assignee';
import FilteredSearchBoards from './filtered_search_boards';
import eventHub from './eventhub';
import sidebarEventHub from '~/sidebar/event_hub'; // eslint-disable-line import/first
import sidebarEventHub from '~/sidebar/event_hub';
import './models/issue';
import './models/list';
import './models/milestone';
......@@ -24,7 +24,7 @@ import './components/board';
import './components/board_sidebar';
import './components/new_list_dropdown';
import BoardAddIssuesModal from './components/modal/index.vue';
import '~/vue_shared/vue_resource_interceptor'; // eslint-disable-line import/first
import '~/vue_shared/vue_resource_interceptor';
export default () => {
const $boardApp = document.getElementById('board-app');
......
app/assets/javascripts/deploy_keys/components/key.vue
View file @ 4ce9f2fd
......@@ -145,8 +145,8 @@ export default {
<icon :name="firstProject.can_push ? 'lock-open' : 'lock'"/>
</a>
<a
v-tooltip
v-if="isExpandable"
v-tooltip
:title="restProjectsTooltip"
class="label deploy-project-label"
@click="toggleExpanded"
......@@ -154,10 +154,10 @@ export default {
<span>{{ restProjectsLabel }}</span>
</a>
<a
v-tooltip
v-for="deployKeysProject in restProjects"
v-else-if="isExpanded"
:key="deployKeysProject.project.full_path"
v-tooltip
:href="deployKeysProject.project.full_path"
:title="projectTooltipTitle(deployKeysProject)"
class="label deploy-project-label"
......@@ -198,8 +198,8 @@ export default {
{{ __('Enable') }}
</action-btn>
<a
v-tooltip
v-if="deployKey.can_edit"
v-tooltip
:href="editDeployKeyPath"
:title="__('Edit')"
class="btn btn-default text-secondary"
......@@ -208,8 +208,8 @@ export default {
<icon name="pencil"/>
</a>
<action-btn
v-tooltip
v-if="isRemovable"
v-tooltip
:deploy-key="deployKey"
:title="__('Remove')"
btn-css-class="btn-danger"
......@@ -219,8 +219,8 @@ export default {
<icon name="remove"/>
</action-btn>
<action-btn
v-tooltip
v-else-if="isEnabled"
v-tooltip
:deploy-key="deployKey"
:title="__('Disable')"
btn-css-class="btn-warning"
......
app/assets/javascripts/diffs/components/diff_file_header.vue
View file @ 4ce9f2fd
......@@ -181,8 +181,8 @@ export default {
</span>
<strong
v-tooltip
v-else
v-tooltip
:title="filePath"
class="file-title-name"
data-container="body"
......@@ -255,8 +255,8 @@ export default {
</a>
<a
v-tooltip
v-if="diffFile.externalUrl"
v-tooltip
:href="diffFile.externalUrl"
:title="`View on ${diffFile.formattedExternalUrl}`"
target="_blank"
......
app/assets/javascripts/diffs/components/diff_gutter_avatars.vue
View file @ 4ce9f2fd
......@@ -87,8 +87,8 @@ export default {
@click.native="toggleDiscussions"
/>
<span
v-gl-tooltip
v-if="moreText"
v-gl-tooltip
:title="moreText"
class="diff-comments-more-count js-diff-comment-avatar js-diff-comment-plus"
data-container="body"
......
app/assets/javascripts/diffs/components/inline_diff_view.vue
View file @ 4ce9f2fd
......@@ -43,18 +43,18 @@ export default {
v-for="(line, index) in diffLines"
>
<inline-diff-table-row
:key="line.lineCode"
:file-hash="diffFile.fileHash"
:context-lines-path="diffFile.contextLinesPath"
:line="line"
:is-bottom="index + 1 === diffLinesLength"
:key="line.lineCode"
/>
<inline-diff-comment-row
v-if="shouldRenderInlineCommentRow(line)"
:key="index"
:diff-file-hash="diffFile.fileHash"
:line="line"
:line-index="index"
:key="index"
/>
</template>
</tbody>
......
app/assets/javascripts/diffs/components/parallel_diff_view.vue
View file @ 4ce9f2fd
......@@ -45,11 +45,11 @@ export default {
v-for="(line, index) in diffLines"
>
<parallel-diff-table-row
:key="index"
:file-hash="diffFile.fileHash"
:context-lines-path="diffFile.contextLinesPath"
:line="line"
:is-bottom="index + 1 === diffLinesLength"
:key="index"
/>
<parallel-diff-comment-row
v-if="shouldRenderParallelCommentRow(line)"
......
app/assets/javascripts/environments/components/environments_table.vue
View file @ 4ce9f2fd
......@@ -83,10 +83,10 @@ export default {
:model="model">
<div
is="environment-item"
:key="`environment-item-${i}`"
:model="model"
:can-create-deployment="canCreateDeployment"
:can-read-environment="canReadEnvironment"
:key="`environment-item-${i}`"
/>
<template
......@@ -102,10 +102,10 @@ export default {
<div
is="environment-item"
v-for="(children, index) in model.children"
:key="`env-item-${i}-${index}`"
:model="children"
:can-create-deployment="canCreateDeployment"
:can-read-environment="canReadEnvironment"
:key="`env-item-${i}-${index}`"
/>
<div :key="`sub-div-${i}`">
......
app/assets/javascripts/filtered_search/components/recent_searches_dropdown_content.vue
View file @ 4ce9f2fd
......@@ -72,8 +72,8 @@ export default {
@click="onItemActivated(item.text)">
<span>
<span
v-for="(token, index) in item.tokens"
:key="`dropdown-token-${index}`"
v-for="(token, tokenIndex) in item.tokens"
:key="`dropdown-token-${tokenIndex}`"
class="filtered-search-history-dropdown-token"
>
<span class="name">{{ token.prefix }}</span>
......
app/assets/javascripts/frequent_items/components/frequent_items_list_item.vue
View file @ 4ce9f2fd
<script>
/* eslint-disable vue/require-default-prop, vue/require-prop-types */
/* eslint-disable vue/require-default-prop */
import Identicon from '../../vue_shared/components/identicon.vue';
export default {
......
app/assets/javascripts/groups/components/item_actions.vue
View file @ 4ce9f2fd
......@@ -46,8 +46,8 @@ export default {
<template>
<div class="controls">
<a
v-tooltip
v-if="group.canEdit"
v-tooltip
:href="group.editPath"
:title="editBtnTitle"
:aria-label="editBtnTitle"
......@@ -57,8 +57,8 @@ export default {
<icon name="settings"/>
</a>
<a
v-tooltip
v-if="group.canLeave"
v-tooltip
:href="group.leavePath"
:title="leaveBtnTitle"
:aria-label="leaveBtnTitle"
......
app/assets/javascripts/ide/components/branches/search_list.vue
View file @ 4ce9f2fd
......@@ -60,8 +60,8 @@ export default {
<div class="position-relative">
<input
ref="searchInput"
:placeholder="__('Search branches')"
v-model="search"
:placeholder="__('Search branches')"
type="search"
class="form-control dropdown-input-field"
@input="searchBranches"
......
app/assets/javascripts/ide/components/commit_sidebar/list.vue
View file @ 4ce9f2fd
......@@ -113,8 +113,8 @@ export default {
</strong>
<div class="d-flex ml-auto">
<button
v-tooltip
ref="actionBtn"
v-tooltip
:title="actionBtnText"
:aria-label="actionBtnText"
:disabled="!filesLength"
......@@ -135,8 +135,8 @@ export default {
/>
</button>
<button
v-tooltip
v-if="!stagedList"
v-tooltip
:title="__('Discard all changes')"
:aria-label="__('Discard all changes')"
:disabled="!filesLength"
......
app/assets/javascripts/ide/components/file_finder/index.vue
View file @ 4ce9f2fd
......@@ -174,8 +174,8 @@ export default {
<div class="dropdown-input">
<input
ref="searchInput"
:placeholder="__('Search files')"
v-model="searchText"
:placeholder="__('Search files')"
type="search"
class="dropdown-input-field"
autocomplete="off"
......
app/assets/javascripts/ide/components/file_finder/item.vue
View file @ 4ce9f2fd
......@@ -78,10 +78,10 @@ export default {
class="diff-changed-file-name"
>
<span
v-for="(char, index) in file.name.split('')"
:key="index + char"
v-for="(char, charIndex) in file.name.split('')"
:key="charIndex + char"
:class="{
highlighted: nameSearchTextOccurences.indexOf(index) >= 0,
highlighted: nameSearchTextOccurences.indexOf(charIndex) >= 0,
}"
v-text="char"
>
......@@ -91,10 +91,10 @@ export default {
class="diff-changed-file-path prepend-top-5"
>
<span
v-for="(char, index) in pathWithEllipsis.split('')"
:key="index + char"
v-for="(char, charIndex) in pathWithEllipsis.split('')"
:key="charIndex + char"
:class="{
highlighted: pathSearchTextOccurences.indexOf(index) >= 0,
highlighted: pathSearchTextOccurences.indexOf(charIndex) >= 0,
}"
v-text="char"
>
......
app/assets/javascripts/ide/components/jobs/stage.vue
View file @ 4ce9f2fd
......@@ -69,8 +69,8 @@ export default {
:size="24"
/>
<strong
v-tooltip="showTooltip"
ref="stageTitle"
v-tooltip="showTooltip"
:title="showTooltip ? stage.name : null"
data-container="body"
class="prepend-left-8 ide-stage-title"
......
app/assets/javascripts/ide/components/repo_file_status_icon.vue
View file @ 4ce9f2fd
......@@ -26,8 +26,8 @@ export default {
<template>
<span
v-tooltip
v-if="file.file_lock"
v-tooltip
:title="lockTooltip"
data-container="body"
>
......
app/assets/javascripts/issue_show/components/title.vue
View file @ 4ce9f2fd
......@@ -76,8 +76,8 @@ export default {
>
</h2>
<button
v-tooltip
v-if="showInlineEditButton && canUpdate"
v-tooltip
type="button"
class="btn btn-default btn-edit btn-svg js-issuable-edit"
title="Edit title and description"
......
app/assets/javascripts/jobs/components/job_log_controllers.vue
View file @ 4ce9f2fd
......@@ -78,8 +78,8 @@
<div class="controllers float-right">
<!-- links -->
<a
v-tooltip
v-if="rawTracePath"
v-tooltip
:title="s__('Job|Show complete raw')"
:href="rawTracePath"
class="js-raw-link-controller controllers-buttons"
......@@ -89,8 +89,8 @@
</a>
<button
v-tooltip
v-if="canEraseJob"
v-tooltip
:title="s__('Job|Erase job log')"
type="button"
class="js-erase-link controllers-buttons"
......
app/assets/javascripts/jobs/components/jobs_container.vue
View file @ 4ce9f2fd
......@@ -25,9 +25,9 @@
class="build-job"
>
<a
v-tooltip
v-for="job in jobs"
:key="job.id"
v-tooltip
:href="job.path"
:title="job.tooltip"
:class="{ active: job.active, retried: job.retried }"
......
app/assets/javascripts/merge_request_tabs.js
View file @ 4ce9f2fd
......@@ -115,8 +115,9 @@ export default class MergeRequestTabs {
this.mergeRequestTabs &&
this.mergeRequestTabs.querySelector(`a[data-action='${action}']`) &&
this.mergeRequestTabs.querySelector(`a[data-action='${action}']`).click
)
) {
this.mergeRequestTabs.querySelector(`a[data-action='${action}']`).click();
}
this.initAffix();
}
......
app/assets/javascripts/monitoring/components/dashboard.vue
View file @ 4ce9f2fd
......@@ -214,8 +214,8 @@ export default {
:show-panels="showPanels"
>
<graph
v-for="(graphData, index) in groupData.metrics"
:key="index"
v-for="(graphData, graphIndex) in groupData.metrics"
:key="graphIndex"
:graph-data="graphData"
:hover-data="hoverData"
:update-aspect-ratio="updateAspectRatio"
......
app/assets/javascripts/monitoring/components/graph/legend.vue
View file @ 4ce9f2fd
......@@ -58,8 +58,8 @@ export default {
</td>
<template v-for="(track, trackIndex) in series.tracksLegend">
<track-line
:track="track"
:key="`track-line-${trackIndex}`"/>
:key="`track-line-${trackIndex}`"
:track="track"/>
<td :key="`track-info-${trackIndex}`">
<track-info
:track="track"
......
app/assets/javascripts/notebook/index.vue
View file @ 4ce9f2fd
......@@ -51,10 +51,10 @@
<template>
<div v-if="hasNotebook">
<component
v-for="(cell, index) in cells"
:is="cellType(cell.cell_type)"
:cell="cell"
v-for="(cell, index) in cells"
:key="index"
:cell="cell"
:code-css-class="codeCssClass" />
</div>
</template>
......
app/assets/javascripts/notes/components/diff_file_header.vue
View file @ 4ce9f2fd
......@@ -41,8 +41,8 @@ export default {
</div>
<template v-else>
<component
ref="titleWrapper"
:is="titleTag"
ref="titleWrapper"
:href="diffFile.discussionPath"
>
<span v-html="diffFile.blobIcon"></span>
......
app/assets/javascripts/notes/components/note_awards_list.vue
View file @ 4ce9f2fd
......@@ -182,9 +182,9 @@ export default {
<div class="note-awards">
<div class="awards js-awards-block">
<button
v-tooltip
v-for="(awardList, awardName, index) in groupedAwards"
:key="index"
v-tooltip
:class="getAwardClassBindings(awardList)"
:title="awardTitle(awardList)"
class="btn award-control"
......
app/assets/javascripts/notes/components/note_form.vue
View file @ 4ce9f2fd
......@@ -171,8 +171,8 @@ export default {
id="note_note"
ref="textarea"
slot="textarea"
:data-supports-quick-actions="!isEditing"
v-model="updatedNoteBody"
:data-supports-quick-actions="!isEditing"
name="note[note]"
class="note-textarea js-gfm-input js-note-text
js-autosize markdown-area js-vue-issue-note-form js-vue-textarea"
......
app/assets/javascripts/notes/components/noteable_discussion.vue
View file @ 4ce9f2fd
......@@ -348,10 +348,10 @@ Please check your network connection and try again.`;
<div class="discussion-notes">
<ul class="notes">
<component
v-for="note in discussion.notes"
:is="componentName(note)"
:note="componentData(note)"
v-for="note in discussion.notes"
:key="note.id"
:note="componentData(note)"
@handleDeleteNote="deleteNoteHandler"
/>
</ul>
......
app/assets/javascripts/notes/components/notes_app.vue
View file @ 4ce9f2fd
......@@ -187,10 +187,10 @@ export default {
class="notes main-notes-list timeline"
>
<component
v-for="discussion in allDiscussions"
:is="getComponentName(discussion)"
v-bind="getComponentData(discussion)"
v-for="discussion in allDiscussions"
:key="discussion.id"
v-bind="getComponentData(discussion)"
/>
</ul>
......
app/assets/javascripts/pages/admin/users/components/delete_user_modal.vue
View file @ 4ce9f2fd
......@@ -155,10 +155,7 @@
/>
</form>
</template>
<template
slot="secondary-button"
slot-scope="props"
>
<template slot="secondary-button">
<button
:disabled="!canSubmit"
type="button"
......
app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/interval_pattern_input.vue
View file @ 4ce9f2fd
......@@ -147,8 +147,8 @@
<div class="cron-interval-input-wrapper">
<input
id="schedule_cron"
:placeholder="__('Define a custom pattern with cron syntax')"
v-model="cronInterval"
:placeholder="__('Define a custom pattern with cron syntax')"
:name="inputNameAttribute"
:disabled="!isEditable"
class="form-control inline cron-interval-input"
......
app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
View file @ 4ce9f2fd
......@@ -240,8 +240,8 @@
help-text="Lightweight issue tracking system for this project"
>
<project-feature-setting
:options="featureAccessLevelOptions"
v-model="issuesAccessLevel"
:options="featureAccessLevelOptions"
name="project[project_feature_attributes][issues_access_level]"
/>
</project-setting-row>
......@@ -250,8 +250,8 @@
help-text="View and edit files in this project"
>
<project-feature-setting
:options="featureAccessLevelOptions"
v-model="repositoryAccessLevel"
:options="featureAccessLevelOptions"
name="project[project_feature_attributes][repository_access_level]"
/>
</project-setting-row>
......@@ -261,8 +261,8 @@
help-text="Submit changes to be merged upstream"
>
<project-feature-setting
:options="repoFeatureAccessLevelOptions"
v-model="mergeRequestsAccessLevel"
:options="repoFeatureAccessLevelOptions"
:disabled-input="!repositoryEnabled"
name="project[project_feature_attributes][merge_requests_access_level]"
/>
......@@ -272,8 +272,8 @@
help-text="Build, test, and deploy your changes"
>
<project-feature-setting
:options="repoFeatureAccessLevelOptions"
v-model="buildsAccessLevel"
:options="repoFeatureAccessLevelOptions"
:disabled-input="!repositoryEnabled"
name="project[project_feature_attributes][builds_access_level]"
/>
......@@ -308,8 +308,8 @@
help-text="Pages for project documentation"
>
<project-feature-setting
:options="featureAccessLevelOptions"
v-model="wikiAccessLevel"
:options="featureAccessLevelOptions"
name="project[project_feature_attributes][wiki_access_level]"
/>
</project-setting-row>
......@@ -318,8 +318,8 @@
help-text="Share code pastes with others out of Git repository"
>
<project-feature-setting
:options="featureAccessLevelOptions"
v-model="snippetsAccessLevel"
:options="featureAccessLevelOptions"
name="project[project_feature_attributes][snippets_access_level]"
/>
</project-setting-row>
......
app/assets/javascripts/performance_bar/components/performance_bar_app.vue
View file @ 4ce9f2fd
......@@ -130,8 +130,8 @@ export default {
</div>
<simple-metric
v-for="metric in $options.simpleMetrics"
:current-request="currentRequest"
:key="metric"
:current-request="currentRequest"
:metric="metric"
/>
<div
......
app/assets/javascripts/pipelines/components/graph/graph_component.vue
View file @ 4ce9f2fd
......@@ -68,9 +68,9 @@ export default {
class="stage-column-list">
<stage-column-component
v-for="(stage, index) in graph"
:key="stage.name"
:title="capitalizeStageName(stage.name)"
:jobs="stage.groups"
:key="stage.name"
:stage-connector-class="stageConnectorClass(index, stage)"
:is-first-column="isFirstColumn(index)"
@refreshPipelineGraph="refreshPipelineGraph"
......
app/assets/javascripts/pipelines/components/graph/job_component.vue
View file @ 4ce9f2fd
......@@ -98,8 +98,8 @@ export default {
<template>
<div class="ci-job-component">
<a
v-tooltip
v-if="status.has_details"
v-tooltip
:href="status.details_path"
:title="tooltipText"
:class="cssClassJobName"
......@@ -115,8 +115,8 @@ export default {
</a>
<div
v-tooltip
v-else
v-tooltip
:title="tooltipText"
:class="cssClassJobName"
class="js-job-component-tooltip non-details-job-component"
......
app/assets/javascripts/pipelines/components/graph/stage_column_component.vue
View file @ 4ce9f2fd
......@@ -62,9 +62,9 @@ export default {
<ul>
<li
v-for="(job, index) in jobs"
:id="jobId(job)"
:key="job.id"
:class="buildConnnectorClass(index)"
:id="jobId(job)"
class="build"
>
......
app/assets/javascripts/pipelines/components/pipeline_url.vue
View file @ 4ce9f2fd
......@@ -67,29 +67,29 @@ export default {
</span>
<div class="label-container">
<span
v-tooltip
v-if="pipeline.flags.latest"
v-tooltip
class="js-pipeline-url-latest badge badge-success"
title="Latest pipeline for this branch">
latest
</span>
<span
v-tooltip
v-if="pipeline.flags.yaml_errors"
v-tooltip
:title="pipeline.yaml_errors"
class="js-pipeline-url-yaml badge badge-danger">
yaml invalid
</span>
<span
v-tooltip
v-if="pipeline.flags.failure_reason"
v-tooltip
:title="pipeline.failure_reason"
class="js-pipeline-url-failure badge badge-danger">
error
</span>
<a
v-popover="popoverOptions"
v-if="pipeline.flags.auto_devops"
v-popover="popoverOptions"
tabindex="0"
class="js-pipeline-url-autodevops badge badge-info autodevops-badge"
role="button">
......
app/assets/javascripts/pipelines/components/stage.vue
View file @ 4ce9f2fd
......@@ -155,9 +155,9 @@ export default {
<template>
<div class="dropdown">
<button
v-tooltip
id="stageDropdown"
ref="dropdown"
v-tooltip
:class="triggerButtonClass"
:title="stage.title"
class="mini-pipeline-graph-dropdown-toggle js-builds-dropdown-button"
......
app/assets/javascripts/registry/components/collapsible_container.vue
View file @ 4ce9f2fd
......@@ -88,8 +88,8 @@
<div class="controls d-none d-sm-block float-right">
<button
v-tooltip
v-if="repo.canDelete"
v-tooltip
:title="s__('ContainerRegistry|Remove repository')"
:aria-label="s__('ContainerRegistry|Remove repository')"
type="button"
......
app/assets/javascripts/registry/components/table_registry.vue
View file @ 4ce9f2fd
......@@ -118,8 +118,8 @@
<td class="content">
<button
v-tooltip
v-if="item.canDelete"
v-tooltip
:title="s__('ContainerRegistry|Remove tag')"
:aria-label="s__('ContainerRegistry|Remove tag')"
type="button"
......
app/assets/javascripts/reports/components/grouped_test_reports_app.vue
View file @ 4ce9f2fd
......@@ -92,16 +92,16 @@
v-for="(report, i) in reports"
>
<summary-row
:key="`summary-row-${i}`"
:summary="reportText(report)"
:status-icon="getReportIcon(report)"
:key="`summary-row-${i}`"
/>
<issues-list
v-if="shouldRenderIssuesList(report)"
:key="`issues-list-${i}`"
:unresolved-issues="report.existing_failures"
:new-issues="report.new_failures"
:resolved-issues="report.resolved_failures"
:key="`issues-list-${i}`"
:component="$options.componentNames.TestIssueBody"
class="report-block-group-list"
/>
......
app/assets/javascripts/reports/components/report_issues.vue
View file @ 4ce9f2fd
......@@ -37,8 +37,8 @@ export default {
<ul class="report-block-list">
<li
v-for="(issue, index) in issues"
:class="{ 'is-dismissed': issue.isDismissed }"
:key="index"
:class="{ 'is-dismissed': issue.isDismissed }"
class="report-block-list-issue"
>
<issue-status-icon
......@@ -47,8 +47,8 @@ export default {
/>
<component
v-if="component"
:is="component"
v-if="component"
:issue="issue"
:status="issue.status || status"
:is-new="isNew"
......
app/assets/javascripts/sidebar/components/time_tracking/time_tracker.vue
View file @ 4ce9f2fd
......@@ -19,19 +19,23 @@ export default {
TimeTrackingHelpState,
},
props: {
// eslint-disable-next-line vue/prop-name-casing
time_estimate: {
type: Number,
required: true,
},
// eslint-disable-next-line vue/prop-name-casing
time_spent: {
type: Number,
required: true,
},
// eslint-disable-next-line vue/prop-name-casing
human_time_estimate: {
type: String,
required: false,
default: '',
},
// eslint-disable-next-line vue/prop-name-casing
human_time_spent: {
type: String,
required: false,
......
app/assets/javascripts/vue_merge_request_widget/components/deployment.vue
View file @ 4ce9f2fd
......@@ -106,8 +106,8 @@ export default {
</tooltip-on-truncate>
</template>
<span
v-tooltip
v-if="hasDeploymentTime"
v-tooltip
:title="deployment.deployed_at_formatted"
class="js-deploy-time"
>
......
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue
View file @ 4ce9f2fd
......@@ -114,8 +114,8 @@
:date-readable="mr.metrics.readableMergedAt"
/>
<a
v-tooltip
v-if="mr.canRevertInCurrentMR"
v-tooltip
:title="revertTitle"
class="btn btn-close btn-sm"
href="#modal-revert-commit"
......@@ -125,8 +125,8 @@
{{ revertLabel }}
</a>
<a
v-tooltip
v-else-if="mr.revertInForkPath"
v-tooltip
:href="mr.revertInForkPath"
:title="revertTitle"
class="btn btn-close btn-sm"
......@@ -135,8 +135,8 @@
{{ revertLabel }}
</a>
<a
v-tooltip
v-if="mr.canCherryPickInCurrentMR"
v-tooltip
:title="cherryPickTitle"
class="btn btn-default btn-sm"
href="#modal-cherry-pick-commit"
......@@ -146,8 +146,8 @@
{{ cherryPickLabel }}
</a>
<a
v-tooltip
v-else-if="mr.cherryPickInForkPath"
v-tooltip
:href="mr.cherryPickInForkPath"
:title="cherryPickTitle"
class="btn btn-default btn-sm"
......
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_squash_before_merge.vue
View file @ 4ce9f2fd
......@@ -37,8 +37,8 @@ export default {
<div class="accept-control inline">
<label class="merge-param-checkbox">
<input
:disabled="isMergeButtonDisabled"
v-model="squashBeforeMerge"
:disabled="isMergeButtonDisabled"
type="checkbox"
name="squash"
class="qa-squash-checkbox"
......
app/assets/javascripts/vue_shared/components/bar_chart.vue
View file @ 4ce9f2fd
......@@ -291,8 +291,8 @@ export default {
<template
v-for="(data, index) in graphData">
<rect
v-tooltip
:key="index"
v-tooltip
:width="xScale.bandwidth()"
:x="xScale(data.name)"
:y="yScale(data.value)"
......
app/assets/javascripts/vue_shared/components/file_row.vue
View file @ 4ce9f2fd
......@@ -135,8 +135,8 @@ export default {
{{ file.name }}
</span>
<component
v-if="extraComponent"
:is="extraComponent"
v-if="extraComponent"
:file="file"
:mouse-over="mouseOver"
/>
......
app/assets/javascripts/vue_shared/components/header_ci_component.vue
View file @ 4ce9f2fd
......@@ -126,18 +126,18 @@ export default {
>
<a
v-if="action.type === 'link'"
:key="i"
:href="action.path"
:class="action.cssClass"
:key="i"
>
{{ action.label }}
</a>
<a
v-else-if="action.type === 'ujs-link'"
:key="i"
:href="action.path"
:class="action.cssClass"
:key="i"
data-method="post"
rel="nofollow"
>
......@@ -146,9 +146,9 @@ export default {
<button
v-else-if="action.type === 'button'"
:key="i"
:disabled="action.isLoading"
:class="action.cssClass"
:key="i"
type="button"
@click="onClickAction(action)"
>
......
app/assets/javascripts/vue_shared/components/stacked_progress_bar.vue
View file @ 4ce9f2fd
......@@ -99,8 +99,8 @@ export default {
{{ __("Not available") }}
</span>
<span
v-tooltip
v-if="successPercent"
v-tooltip
:title="successTooltip"
:style="successBarStyle"
class="status-green"
......@@ -109,8 +109,8 @@ export default {
{{ successPercent }}%
</span>
<span
v-tooltip
v-if="neutralPercent"
v-tooltip
:title="neutralTooltip"
:style="neutralBarStyle"
class="status-neutral"
......@@ -119,8 +119,8 @@ export default {
{{ neutralPercent }}%
</span>
<span
v-tooltip
v-if="failurePercent"
v-tooltip
:title="failureTooltip"
:style="failureBarStyle"
class="status-red"
......
app/assets/javascripts/vue_shared/components/tooltip_on_truncate.vue
View file @ 4ce9f2fd
......@@ -51,8 +51,8 @@ export default {
<template>
<span
v-tooltip
v-if="showTooltip"
v-tooltip
:title="title"
:data-placement="placement"
class="js-show-tooltip"
......
app/assets/javascripts/vue_shared/components/user_avatar/user_avatar_link.vue
View file @ 4ce9f2fd
......@@ -94,8 +94,8 @@ export default {
:tooltip-text="avatarTooltipText"
:tooltip-placement="tooltipPlacement"
/><span
v-tooltip
v-if="shouldShowUsername"
v-tooltip
:title="tooltipText"
:tooltip-placement="tooltipPlacement"
>{{ username }}</span>
......
spec/javascripts/.eslintrc.yml
View file @ 4ce9f2fd
......@@ -35,3 +35,9 @@ rules:
- error
- ignore:
- 'fixtures/blob'
# Temporarily disabled to facilitate an upgrade to eslint-plugin-jasmine
jasmine/new-line-before-expect: off
jasmine/new-line-between-declarations: off
jasmine/no-promise-without-done-fail: off
jasmine/prefer-jasmine-matcher: off
jasmine/prefer-toHaveBeenCalledWith: off
spec/javascripts/close_reopen_report_toggle_spec.js
View file @ 4ce9f2fd
/* eslint-disable jasmine/no-unsafe-spy */
import CloseReopenReportToggle from '~/close_reopen_report_toggle';
import DropLab from '~/droplab/drop_lab';
......
spec/javascripts/lib/utils/poll_spec.js
View file @ 4ce9f2fd
/* eslint-disable jasmine/no-unsafe-spy */
import Poll from '~/lib/utils/poll';
import { successCodes } from '~/lib/utils/http_status';
......
spec/javascripts/right_sidebar_spec.js
View file @ 4ce9f2fd
/* eslint-disable no-var, one-var, one-var-declaration-per-line, no-return-assign, vars-on-top, max-len */
/* eslint-disable no-var, one-var, one-var-declaration-per-line, no-return-assign, vars-on-top, jasmine/no-unsafe-spy, max-len */
import $ from 'jquery';
import MockAdapter from 'axios-mock-adapter';
......
yarn.lock
View file @ 4ce9f2fd
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7