Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
51a9c549
Commit
51a9c549
authored
Jan 21, 2019
by
Martin Wortschack
Committed by
Phil Hughes
Jan 21, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Admin Settings: Cannot read property 'addEventListener' of null"
parent
466a7751
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
5 deletions
+10
-5
app/assets/javascripts/pages/admin/application_settings/show/index.js
...avascripts/pages/admin/application_settings/show/index.js
+3
-0
app/assets/javascripts/pages/admin/index.js
app/assets/javascripts/pages/admin/index.js
+1
-5
changelogs/unreleased/56622-admin-settings-cannot-read-property-addeventlistener-of-null.yml
...ettings-cannot-read-property-addeventlistener-of-null.yml
+5
-0
spec/javascripts/test_bundle.js
spec/javascripts/test_bundle.js
+1
-0
No files found.
app/assets/javascripts/pages/admin/application_settings/show/index.js
0 → 100644
View file @
51a9c549
import
initUserInternalRegexPlaceholder
from
'
../../application_settings/account_and_limits
'
;
document
.
addEventListener
(
'
DOMContentLoaded
'
,
initUserInternalRegexPlaceholder
());
app/assets/javascripts/pages/admin/index.js
View file @
51a9c549
import
initAdmin
from
'
./admin
'
;
import
initUserInternalRegexPlaceholder
from
'
./application_settings/account_and_limits
'
;
document
.
addEventListener
(
'
DOMContentLoaded
'
,
()
=>
{
initAdmin
();
initUserInternalRegexPlaceholder
();
});
document
.
addEventListener
(
'
DOMContentLoaded
'
,
initAdmin
());
changelogs/unreleased/56622-admin-settings-cannot-read-property-addeventlistener-of-null.yml
0 → 100644
View file @
51a9c549
---
title
:
Load initUserInternalRegexPlaceholder only when required
merge_request
:
24522
author
:
type
:
fixed
spec/javascripts/test_bundle.js
View file @
51a9c549
...
...
@@ -187,6 +187,7 @@ if (process.env.BABEL_ENV === 'coverage') {
'
./terminal/terminal_bundle.js
'
,
'
./users/users_bundle.js
'
,
'
./issue_show/index.js
'
,
'
./pages/admin/application_settings/show/index.js
'
,
];
describe
(
'
Uncovered files
'
,
function
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment