Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
578b2b2f
Commit
578b2b2f
authored
Mar 03, 2017
by
Regis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add grey lines - adequate spacing for action buttons
parent
5d2c70b1
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
104 additions
and
34 deletions
+104
-34
app/assets/stylesheets/pages/merge_requests.scss
app/assets/stylesheets/pages/merge_requests.scss
+41
-2
app/views/projects/merge_requests/widget/_merged.html.haml
app/views/projects/merge_requests/widget/_merged.html.haml
+47
-21
app/views/projects/merge_requests/widget/_merged_buttons.haml
...views/projects/merge_requests/widget/_merged_buttons.haml
+1
-1
app/views/projects/merge_requests/widget/open/_conflicts.html.haml
.../projects/merge_requests/widget/open/_conflicts.html.haml
+15
-10
No files found.
app/assets/stylesheets/pages/merge_requests.scss
View file @
578b2b2f
...
@@ -344,15 +344,54 @@
...
@@ -344,15 +344,54 @@
}
}
}
}
.remove-message-pipes
{
ul
{
margin-left
:
6px
;
margin-bottom
:
20px
;
padding-left
:
0
;
list-style
:
none
;
border-left
:
3px
solid
$border-color
;
}
ul
li
:last-child
{
margin-bottom
:
0
;
}
li
{
height
:
30px
;
position
:
relative
;
margin
:
-3px
;
padding-bottom
:
3px
;
}
li
span
{
width
:
20px
;
display
:
inline-block
;
height
:
3px
;
background
:
$border-color
;
margin-right
:
5px
;
top
:
16px
;
position
:
relative
;
}
li
p
{
display
:
inline-block
;
margin
:
0
;
margin-bottom
:
-3px
;
padding
:
0
;
position
:
relative
;
top
:
20px
;
}
}
.mr-source-target
{
.mr-source-target
{
background-color
:
#FAFAFA
;
background-color
:
$gray-light
;
line-height
:
31px
;
line-height
:
31px
;
border-style
:
solid
;
border-style
:
solid
;
border-width
:
1px
;
border-width
:
1px
;
border-color
:
$border-color
;
border-color
:
$border-color
;
border-top-right-radius
:
10px
;
border-top-right-radius
:
10px
;
border-top-left-radius
:
10px
;
border-top-left-radius
:
10px
;
border--radius
:
0px
;
padding
:
10px
;
padding
:
10px
;
margin-bottom
:
-1px
;
margin-bottom
:
-1px
;
}
}
...
...
app/views/projects/merge_requests/widget/_merged.html.haml
View file @
578b2b2f
...
@@ -7,28 +7,54 @@
...
@@ -7,28 +7,54 @@
by
#{
link_to_member
(
@project
,
@merge_request
.
merge_event
.
author
,
avatar:
true
)
}
by
#{
link_to_member
(
@project
,
@merge_request
.
merge_event
.
author
,
avatar:
true
)
}
#{
time_ago_with_tooltip
(
@merge_request
.
merge_event
.
created_at
)
}
#{
time_ago_with_tooltip
(
@merge_request
.
merge_event
.
created_at
)
}
-
if
!
@merge_request
.
source_branch_exists?
||
params
[
:deleted_source_branch
]
-
if
!
@merge_request
.
source_branch_exists?
||
params
[
:deleted_source_branch
]
%p
.remove-message-pipes
The changes were merged into
%ul
#{
link_to
@merge_request
.
target_branch
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@merge_request
.
target_branch
),
class:
"label-branch"
}
.
%li
The source branch has been removed.
%span
%p
The changes were merged into
#{
link_to
@merge_request
.
target_branch
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@merge_request
.
target_branch
),
class:
"label-branch"
}
.
%li
%span
%p
The source branch has been removed.
=
render
'projects/merge_requests/widget/merged_buttons'
=
render
'projects/merge_requests/widget/merged_buttons'
-
elsif
@merge_request
.
can_remove_source_branch?
(
current_user
)
-
elsif
@merge_request
.
can_remove_source_branch?
(
current_user
)
.remove_source_branch_widget
.remove_source_branch_widget.remove-message-pipes
%p
%ul
The changes were merged into
%li
#{
link_to
@merge_request
.
target_branch
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@merge_request
.
target_branch
),
class:
"label-branch"
}
.
%span
You can remove the source branch now.
%p
The changes were merged into
#{
link_to
@merge_request
.
target_branch
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@merge_request
.
target_branch
),
class:
"label-branch"
}
.
%li
%span
%p
You can remove the source branch now.
=
render
'projects/merge_requests/widget/merged_buttons'
,
source_branch_exists:
true
=
render
'projects/merge_requests/widget/merged_buttons'
,
source_branch_exists:
true
.remove_source_branch_widget.failed.hide
.remove_source_branch_widget.failed.remove-message-pipes.hide
%p
%ul
Failed to remove source branch '
#{
@merge_request
.
source_branch
}
'.
%li
%span
.remove_source_branch_in_progress.hide
%p
%p
Failed to remove source branch '
#{
@merge_request
.
source_branch
}
'.
=
icon
(
'spinner spin'
)
.remove_source_branch_in_progress.remove-message-pipes.hide
Removing source branch '
#{
@merge_request
.
source_branch
}
'. Please wait, this page will be automatically reloaded.
%ul
%li
%span
%p
=
icon
(
'spinner spin'
)
Removing source branch '
#{
@merge_request
.
source_branch
}
'.
%li
%span
%p
Please wait, this page will be automatically reloaded.
-
else
-
else
%p
.remove-message-pipes
The changes were merged into
%ul
#{
link_to
@merge_request
.
target_branch
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@merge_request
.
target_branch
),
class:
"label-branch"
}
.
%li
=
render
'projects/merge_requests/widget/merged_buttons'
%span
%p
The changes were merged into
#{
link_to
@merge_request
.
target_branch
,
namespace_project_commits_path
(
@project
.
namespace
,
@project
,
@merge_request
.
target_branch
),
class:
"label-branch"
}
.
=
render
'projects/merge_requests/widget/merged_buttons'
app/views/projects/merge_requests/widget/_merged_buttons.haml
View file @
578b2b2f
...
@@ -9,6 +9,6 @@
...
@@ -9,6 +9,6 @@
=
icon
(
'trash-o'
)
=
icon
(
'trash-o'
)
Remove Source Branch
Remove Source Branch
-
if
mr_can_be_reverted
-
if
mr_can_be_reverted
=
revert_commit_link
(
@merge_request
.
merge_commit
,
namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
),
btn_class:
"
warning
"
)
=
revert_commit_link
(
@merge_request
.
merge_commit
,
namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
),
btn_class:
"
close
"
)
-
if
mr_can_be_cherry_picked
-
if
mr_can_be_cherry_picked
=
cherry_pick_commit_link
(
@merge_request
.
merge_commit
,
namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
),
btn_class:
"default"
)
=
cherry_pick_commit_link
(
@merge_request
.
merge_commit
,
namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
),
btn_class:
"default"
)
app/views/projects/merge_requests/widget/open/_conflicts.html.haml
View file @
578b2b2f
...
@@ -3,17 +3,22 @@
...
@@ -3,17 +3,22 @@
-
can_merge
=
@merge_request
.
can_be_merged_via_command_line_by?
(
current_user
)
-
can_merge
=
@merge_request
.
can_be_merged_via_command_line_by?
(
current_user
)
%h4
.has-conflicts
%h4
.has-conflicts
=
icon
(
"exclamation-triangle"
)
%p
This merge request contains merge conflicts
=
icon
(
"exclamation-triangle"
)
This merge request contains merge conflicts
%p
.remove-message-pipes
To merge this request, resolve these conflicts
%ul
-
if
can_resolve
&&
!
can_resolve_in_ui
%li
locally
%span
or
%p
-
unless
can_merge
To merge this request, resolve these conflicts
ask someone with write access to this repository to
-
if
can_resolve
&&
!
can_resolve_in_ui
merge it locally.
locally
or
-
unless
can_merge
ask someone with write access to this repository to
merge it locally.
-
if
(
can_resolve
&&
can_resolve_in_ui
)
||
can_merge
-
if
(
can_resolve
&&
can_resolve_in_ui
)
||
can_merge
.btn-group
.btn-group
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment