Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
5b091c76
Commit
5b091c76
authored
Nov 03, 2013
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #5512 from jhollingsworth/feature/missing-group-500-fix
Fixes 500 error when user types in wrong group name.
parents
0f665f41
dfe19b2b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
1 deletion
+2
-1
CHANGELOG
CHANGELOG
+1
-0
app/controllers/groups_controller.rb
app/controllers/groups_controller.rb
+1
-1
No files found.
CHANGELOG
View file @
5b091c76
...
@@ -6,6 +6,7 @@ v 6.3.0
...
@@ -6,6 +6,7 @@ v 6.3.0
- Show branches list (which branches contains commit) on commit page (Andrew Kumanyaev)
- Show branches list (which branches contains commit) on commit page (Andrew Kumanyaev)
- Security improvements
- Security improvements
- Added support for GitLab CI 4.0
- Added support for GitLab CI 4.0
- Fixed issue with 500 error when group did not exist
v 6.2.0
v 6.2.0
- Public project pages are now visible to everyone (files, issues, wik, etc.)
- Public project pages are now visible to everyone (files, issues, wik, etc.)
...
...
app/controllers/groups_controller.rb
View file @
5b091c76
...
@@ -102,7 +102,7 @@ class GroupsController < ApplicationController
...
@@ -102,7 +102,7 @@ class GroupsController < ApplicationController
# Dont allow unauthorized access to group
# Dont allow unauthorized access to group
def
authorize_read_group!
def
authorize_read_group!
unless
projects
.
present?
or
can?
(
current_user
,
:read_group
,
@group
)
unless
@group
and
(
projects
.
present?
or
can?
(
current_user
,
:read_group
,
@group
)
)
return
render_404
return
render_404
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment