Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
6afcc4ef
Commit
6afcc4ef
authored
Feb 12, 2019
by
Marcel Amirault
Committed by
Filipa Lacerda
Feb 12, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Change unicode for non-standard spaces
parent
da1aaaf2
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
5 deletions
+10
-5
app/views/layouts/_mailer.html.haml
app/views/layouts/_mailer.html.haml
+1
-1
changelogs/unreleased/ravlen-fix-spaces-unicode.yml
changelogs/unreleased/ravlen-fix-spaces-unicode.yml
+5
-0
spec/features/dashboard/todos/todos_spec.rb
spec/features/dashboard/todos/todos_spec.rb
+4
-4
No files found.
app/views/layouts/_mailer.html.haml
View file @
6afcc4ef
...
@@ -49,7 +49,7 @@
...
@@ -49,7 +49,7 @@
%table
#body
{
border:
"0"
,
cellpadding:
"0"
,
cellspacing:
"0"
,
style:
"background-color:#fafafa;margin:0;padding:0;text-align:center;min-width:640px;width:100%;"
}
%table
#body
{
border:
"0"
,
cellpadding:
"0"
,
cellspacing:
"0"
,
style:
"background-color:#fafafa;margin:0;padding:0;text-align:center;min-width:640px;width:100%;"
}
%tbody
%tbody
%tr
.line
%tr
.line
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;background-color:#6b4fbb;height:4px;font-size:4px;line-height:4px;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;background-color:#6b4fbb;height:4px;font-size:4px;line-height:4px;"
}
%tr
.header
%tr
.header
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;padding:25px 0;font-size:13px;line-height:1.6;color:#5c5c5c;"
}
%td
{
style:
"font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;padding:25px 0;font-size:13px;line-height:1.6;color:#5c5c5c;"
}
=
header_logo
=
header_logo
...
...
changelogs/unreleased/ravlen-fix-spaces-unicode.yml
0 → 100644
View file @
6afcc4ef
---
title
:
Correct non-standard unicode spaces to regular unicode
merge_request
:
24795
author
:
Marcel Amirault
type
:
other
spec/features/dashboard/todos/todos_spec.rb
View file @
6afcc4ef
...
@@ -126,7 +126,7 @@ describe 'Dashboard Todos' do
...
@@ -126,7 +126,7 @@ describe 'Dashboard Todos' do
it
'shows you added a todo message'
do
it
'shows you added a todo message'
do
page
.
within
(
'.js-todos-all'
)
do
page
.
within
(
'.js-todos-all'
)
do
expect
(
page
).
to
have_content
(
"You added a todo for issue
#{
issue
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
to
have_content
(
"You added a todo for issue
#{
issue
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
end
end
end
end
...
@@ -140,7 +140,7 @@ describe 'Dashboard Todos' do
...
@@ -140,7 +140,7 @@ describe 'Dashboard Todos' do
it
'shows you mentioned yourself message'
do
it
'shows you mentioned yourself message'
do
page
.
within
(
'.js-todos-all'
)
do
page
.
within
(
'.js-todos-all'
)
do
expect
(
page
).
to
have_content
(
"You mentioned yourself on issue
#{
issue
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
to
have_content
(
"You mentioned yourself on issue
#{
issue
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
end
end
end
end
...
@@ -154,7 +154,7 @@ describe 'Dashboard Todos' do
...
@@ -154,7 +154,7 @@ describe 'Dashboard Todos' do
it
'shows you directly addressed yourself message'
do
it
'shows you directly addressed yourself message'
do
page
.
within
(
'.js-todos-all'
)
do
page
.
within
(
'.js-todos-all'
)
do
expect
(
page
).
to
have_content
(
"You directly addressed yourself on issue
#{
issue
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
to
have_content
(
"You directly addressed yourself on issue
#{
issue
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
end
end
end
end
...
@@ -170,7 +170,7 @@ describe 'Dashboard Todos' do
...
@@ -170,7 +170,7 @@ describe 'Dashboard Todos' do
it
'shows you set yourself as an approver message'
do
it
'shows you set yourself as an approver message'
do
page
.
within
(
'.js-todos-all'
)
do
page
.
within
(
'.js-todos-all'
)
do
expect
(
page
).
to
have_content
(
"You set yourself as an approver for merge request
#{
merge_request
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
to
have_content
(
"You set yourself as an approver for merge request
#{
merge_request
.
to_reference
(
full:
true
)
}
"
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
expect
(
page
).
not_to
have_content
(
'to yourself'
)
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment