Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
75b2c9bf
Commit
75b2c9bf
authored
Oct 06, 2018
by
Dmitriy Zaporozhets
Committed by
Douglas Barbosa Alexandre
Oct 06, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix invalid parent path on group settings page
parent
4c351e17
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
2 deletions
+23
-2
app/views/groups/settings/_advanced.html.haml
app/views/groups/settings/_advanced.html.haml
+2
-2
changelogs/unreleased/52242-ui-ux-bug-in-change-group-path.yml
...elogs/unreleased/52242-ui-ux-bug-in-change-group-path.yml
+5
-0
spec/features/groups/group_settings_spec.rb
spec/features/groups/group_settings_spec.rb
+16
-0
No files found.
app/views/groups/settings/_advanced.html.haml
View file @
75b2c9bf
...
...
@@ -12,8 +12,8 @@
.group-root-path.input-group-prepend.has-tooltip
{
title:
group_path
(
@group
),
:'data-placement'
=>
'bottom'
}
.input-group-text
%span
>=
root_url
-
if
parent
%strong
=
parent
.
full_path
+
'/'
-
if
@group
.
parent
%strong
=
@group
.
parent
.
full_path
+
'/'
=
f
.
hidden_field
:parent_id
=
f
.
text_field
:path
,
placeholder:
'open-source'
,
class:
'form-control'
,
autofocus:
local_assigns
[
:autofocus
]
||
false
,
required:
true
,
...
...
changelogs/unreleased/52242-ui-ux-bug-in-change-group-path.yml
0 → 100644
View file @
75b2c9bf
---
title
:
Fix incorrect parent path on group settings page
merge_request
:
22142
author
:
type
:
fixed
spec/features/groups/group_settings_spec.rb
View file @
75b2c9bf
...
...
@@ -98,6 +98,22 @@ describe 'Edit group settings' do
end
end
describe
'edit group path'
do
it
'has a root URL label for top-level group'
do
visit
edit_group_path
(
group
)
expect
(
find
(
:css
,
'.group-root-path'
).
text
).
to
eq
(
root_url
)
end
it
'has a parent group URL label for a subgroup group'
,
:postgresql
do
subgroup
=
create
(
:group
,
parent:
group
)
visit
edit_group_path
(
subgroup
)
expect
(
find
(
:css
,
'.group-root-path'
).
text
).
to
eq
(
group_url
(
subgroup
.
parent
)
+
'/'
)
end
end
def
update_path
(
new_group_path
)
visit
edit_group_path
(
group
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment