Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
7ac732a2
Commit
7ac732a2
authored
Mar 10, 2017
by
Jacob Schatz
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'fe-arch-step' into 'master'
Adds information about architecture step. See merge request !9844
parents
065825b7
85b96f14
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
2 deletions
+20
-2
doc/development/frontend.md
doc/development/frontend.md
+20
-2
No files found.
doc/development/frontend.md
View file @
7ac732a2
...
@@ -16,6 +16,22 @@ minification, and compression of our assets.
...
@@ -16,6 +16,22 @@ minification, and compression of our assets.
[
jQuery
][
jquery
]
is used throughout the application's JavaScript, with
[
jQuery
][
jquery
]
is used throughout the application's JavaScript, with
[
Vue.js
][
vue
]
for particularly advanced, dynamic elements.
[
Vue.js
][
vue
]
for particularly advanced, dynamic elements.
### Architecture
The Frontend Architect is an expert who makes high-level frontend design choices
and decides on technical standards, including coding standards, and frameworks.
When you are assigned a new feature that requires architectural design,
make sure it is discussed with one of the Frontend Architecture Experts.
This rule also applies if you plan to change the architecture of an existing feature.
These decisions should be accessible to everyone, so please document it on the Merge Request.
You can find the Frontend Architecture experts on the
[
team page
][
team-page
]
.
You can find documentation about the desired architecture for a new feature built with Vue.js in
[
here
][
vue-section
]
.
### Vue
### Vue
For more complex frontend features, we recommend using Vue.js. It shares
For more complex frontend features, we recommend using Vue.js. It shares
...
@@ -238,8 +254,8 @@ readability.
...
@@ -238,8 +254,8 @@ readability.
See the relevant style guides for our guidelines and for information on linting:
See the relevant style guides for our guidelines and for information on linting:
-
[
SCSS
][
scss-style-guide
]
-
[
SCSS
][
scss-style-guide
]
-
JavaScript - We defer to
[
AirBnb
][
airbnb-js-style-guide
]
on most style-related
-
JavaScript - We defer to
[
AirBnb
][
airbnb-js-style-guide
]
on most style-related
conventions and enforce them with eslint. See
[
our current .eslintrc
][
esli
strc
]
conventions and enforce them with eslint. See
[
our current .eslintrc
][
esli
ntrc
]
for specific rules and patterns.
for specific rules and patterns.
## Testing
## Testing
...
@@ -439,3 +455,5 @@ Scenario: Developer can approve merge request
...
@@ -439,3 +455,5 @@ Scenario: Developer can approve merge request
[
issue-boards-service
]:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/boards/services/board_service.js.es6
[
issue-boards-service
]:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/boards/services/board_service.js.es6
[
airbnb-js-style-guide
]:
https://github.com/airbnb/javascript
[
airbnb-js-style-guide
]:
https://github.com/airbnb/javascript
[
eslintrc
]:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc
[
eslintrc
]:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc
[
team-page
]:
https://about.gitlab.com/team
[
vue-section
]:
https://docs.gitlab.com/ce/development/frontend.html#how-to-build-a-new-feature-with-vue-js
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment