Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
8bd6f72e
Commit
8bd6f72e
authored
May 14, 2019
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disallow the review-deploy and review-qa-smoke jobs to fail
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
e5d2e7e6
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
3 deletions
+2
-3
.gitlab/ci/review.gitlab-ci.yml
.gitlab/ci/review.gitlab-ci.yml
+2
-3
No files found.
.gitlab/ci/review.gitlab-ci.yml
View file @
8bd6f72e
...
...
@@ -78,7 +78,6 @@ schedule:review-build-cng:
<<
:
*review-base
stage
:
review
retry
:
2
allow_failure
:
true
variables
:
HOST_SUFFIX
:
"
${CI_ENVIRONMENT_SLUG}"
DOMAIN
:
"
-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
...
...
@@ -130,7 +129,6 @@ review-stop:
.review-qa-base
:
&review-qa-base
<<
:
*review-docker
stage
:
qa
allow_failure
:
true
variables
:
<<
:
*review-docker-variables
QA_ARTIFACTS_DIR
:
"
${CI_PROJECT_DIR}/qa"
...
...
@@ -165,13 +163,14 @@ review-qa-smoke:
review-qa-all
:
<<
:
*review-qa-base
allow_failure
:
true
when
:
manual
script
:
-
gitlab-qa Test::Instance::Any "${QA_IMAGE}" "${CI_ENVIRONMENT_URL}"
.review-performance-base
:
&review-performance-base
<<
:
*review-qa-base
stage
:
qa
allow_failure
:
true
before_script
:
-
export CI_ENVIRONMENT_URL="$(cat review_app_url.txt)"
-
echo "${CI_ENVIRONMENT_URL}"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment