Commit 9a10098e authored by Dennis Tang's avatar Dennis Tang

Update invite_group_spec to be consistent with EE

The check for the "Invite member" tab for the test
where a project cannot be shared with groups isn't
relevant, and needs to be removed since in EE the
visibility rules for the tab are different due to
both the group and membership lock capabilities.
parent 79322c3c
...@@ -17,7 +17,6 @@ describe 'Project > Members > Invite group', :js do ...@@ -17,7 +17,6 @@ describe 'Project > Members > Invite group', :js do
shared_examples 'the project cannot be shared with groups' do shared_examples 'the project cannot be shared with groups' do
it 'the "Invite group" tab does not exist' do it 'the "Invite group" tab does not exist' do
visit project_settings_members_path(project) visit project_settings_members_path(project)
expect(page).to have_selector('#invite-member-tab')
expect(page).not_to have_selector('#invite-group-tab') expect(page).not_to have_selector('#invite-group-tab')
end end
end end
...@@ -31,7 +30,7 @@ describe 'Project > Members > Invite group', :js do ...@@ -31,7 +30,7 @@ describe 'Project > Members > Invite group', :js do
sign_in(maintainer) sign_in(maintainer)
end end
context 'when the group has "Invite group lock" disabled' do context 'when the group has "Share with group lock" disabled' do
it_behaves_like 'the project can be shared with groups' it_behaves_like 'the project can be shared with groups'
it 'the project can be shared with another group' do it 'the project can be shared with another group' do
...@@ -49,7 +48,7 @@ describe 'Project > Members > Invite group', :js do ...@@ -49,7 +48,7 @@ describe 'Project > Members > Invite group', :js do
end end
end end
context 'when the group has "Invite group lock" enabled' do context 'when the group has "Share with group lock" enabled' do
before do before do
project.namespace.update_column(:share_with_group_lock, true) project.namespace.update_column(:share_with_group_lock, true)
end end
...@@ -69,12 +68,12 @@ describe 'Project > Members > Invite group', :js do ...@@ -69,12 +68,12 @@ describe 'Project > Members > Invite group', :js do
sign_in(maintainer) sign_in(maintainer)
end end
context 'when the root_group has "Invite group lock" disabled' do context 'when the root_group has "Share with group lock" disabled' do
context 'when the subgroup has "Invite group lock" disabled' do context 'when the subgroup has "Share with group lock" disabled' do
it_behaves_like 'the project can be shared with groups' it_behaves_like 'the project can be shared with groups'
end end
context 'when the subgroup has "Invite group lock" enabled' do context 'when the subgroup has "Share with group lock" enabled' do
before do before do
subgroup.update_column(:share_with_group_lock, true) subgroup.update_column(:share_with_group_lock, true)
end end
...@@ -83,16 +82,16 @@ describe 'Project > Members > Invite group', :js do ...@@ -83,16 +82,16 @@ describe 'Project > Members > Invite group', :js do
end end
end end
context 'when the root_group has "Invite group lock" enabled' do context 'when the root_group has "Share with group lock" enabled' do
before do before do
root_group.update_column(:share_with_group_lock, true) root_group.update_column(:share_with_group_lock, true)
end end
context 'when the subgroup has "Invite group lock" disabled (parent overridden)' do context 'when the subgroup has "Share with group lock" disabled (parent overridden)' do
it_behaves_like 'the project can be shared with groups' it_behaves_like 'the project can be shared with groups'
end end
context 'when the subgroup has "Invite group lock" enabled' do context 'when the subgroup has "Share with group lock" enabled' do
before do before do
subgroup.update_column(:share_with_group_lock, true) subgroup.update_column(:share_with_group_lock, true)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment