Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
a3153984
Commit
a3153984
authored
Feb 01, 2018
by
Matija Čupić
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add specs for .auto_devops_warning_message
parent
5126b1c5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
48 additions
and
6 deletions
+48
-6
app/helpers/auto_devops_helper.rb
app/helpers/auto_devops_helper.rb
+13
-6
spec/helpers/auto_devops_helper_spec.rb
spec/helpers/auto_devops_helper_spec.rb
+35
-0
No files found.
app/helpers/auto_devops_helper.rb
View file @
a3153984
...
...
@@ -9,21 +9,28 @@ module AutoDevopsHelper
end
def
auto_devops_warning_message
(
project
)
missing_domain
=
!
project
.
auto_devops
&
.
has_domain?
missing_service
=
!
project
.
deployment_platform
&
.
active?
if
missing_service
if
missing_service?
params
=
{
kubernetes:
link_to
(
'Kubernetes cluster'
,
project_clusters_path
(
project
))
}
if
missing_domain
if
missing_domain
?
_
(
'Auto Review Apps and Auto Deploy need a domain name and a %{kubernetes} to work correctly.'
)
%
params
else
_
(
'Auto Review Apps and Auto Deploy need a %{kubernetes} to work correctly.'
)
%
params
end
elsif
missing_domain
elsif
missing_domain
?
_
(
'Auto Review Apps and Auto Deploy need a domain name to work correctly.'
)
end
end
private
def
missing_domain?
!
(
project
.
auto_devops
&
.
has_domain?
||
current_application_settings
.
auto_devops_domain
.
present?
)
end
def
missing_service?
!
project
.
deployment_platform
&
.
active?
end
end
spec/helpers/auto_devops_helper_spec.rb
View file @
a3153984
...
...
@@ -82,4 +82,39 @@ describe AutoDevopsHelper do
it
{
is_expected
.
to
eq
(
false
)
}
end
end
describe
'.auto_devops_warning_message'
do
subject
{
helper
.
auto_devops_warning_message
(
project
)
}
context
'when the service is missing'
do
before
do
allow
(
helper
).
to
receive
(
:missing_service?
).
and_return
(
true
)
end
context
'when the domain is missing'
do
before
do
allow
(
helper
).
to
receive
(
:missing_domain?
).
and_return
(
true
)
end
it
{
is_expected
.
to
match
(
/Auto Review Apps and Auto Deploy need a domain name and a .* to work correctly./
)
}
end
context
'when the domain is not missing'
do
before
do
allow
(
helper
).
to
receive
(
:missing_domain?
).
and_return
(
false
)
end
it
{
is_expected
.
to
match
(
/Auto Review Apps and Auto Deploy need a .* to work correctly./
)
}
end
end
context
'when the domain is missing'
do
before
do
allow
(
helper
).
to
receive
(
:missing_service?
).
and_return
(
false
)
allow
(
helper
).
to
receive
(
:missing_domain?
).
and_return
(
true
)
end
it
{
is_expected
.
to
eq
(
'Auto Review Apps and Auto Deploy need a domain name to work correctly.'
)
}
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment