fix the failing specs

app/controllers/concerns/send_file_upload.rb

@@ -8,7 +8,8 @@ module SendFileUpload
     if file_upload.file_storage?
       send_file file_upload.path, send_params
     elsif file_upload.class.proxy_download_enabled?
-      Gitlab::Workhorse.send_url(file_upload.url(**redirect_params))
+      headers.store(*Gitlab::Workhorse.send_url(file_upload.url(**redirect_params)))
+      head :ok
     else
       redirect_to file_upload.url(**redirect_params)
     end

doc/administration/job_artifacts.md

@@ -109,7 +109,7 @@ For source installations the following settings are nested under `artifacts:` an
 | `enabled` | Enable/disable object storage | `false` |
 | `remote_directory` | The bucket name where Artfacts will be stored| |
 | `background_upload` | Set to false to disable automatic upload. Option may be removed once upload is direct to S3 | `true` |
-| `proxy_download` | Set to false to disable proxying all files served. Option allows to reduce egress traffic as this allows clients to download directly from remote storage instead of proxying all data | `false` |
+| `proxy_download` | Set to true to enable proxying all files served. Option allows to reduce egress traffic as this allows clients to download directly from remote storage instead of proxying all data | `false` |
 | `connection` | Various connection options described below | |
 
 #### S3 compatible connection settings

doc/administration/uploads.md

@@ -66,7 +66,7 @@ For source installations the following settings are nested under `uploads:` and
 | `enabled` | Enable/disable object storage | `false` |
 | `remote_directory` | The bucket name where Uploads will be stored| |
 | `background_upload` | Set to false to disable automatic upload. Option may be removed once upload is direct to S3 | `true` |
-| `proxy_download` | Set to false to disable proxying all files served. Option allows to reduce egress traffic as this allows clients to download directly from remote storage instead of proxying all data | `false` |
+| `proxy_download` | Set to true to enable proxying all files served. Option allows to reduce egress traffic as this allows clients to download directly from remote storage instead of proxying all data | `false` |
 | `connection` | Various connection options described below | |
 
 #### S3 compatible connection settings

doc/workflow/lfs/lfs_administration.md

@@ -64,7 +64,7 @@ For source installations the following settings are nested under `lfs:` and then
 | `enabled` | Enable/disable object storage | `false` |
 | `remote_directory` | The bucket name where LFS objects will be stored| |
 | `background_upload` | Set to false to disable automatic upload. Option may be removed once upload is direct to S3 | `true` |
-| `proxy_download` | Set to false to disable proxying all files served. Option allows to reduce egress traffic as this allows clients to download directly from remote storage instead of proxying all data | `false` |
+| `proxy_download` | Set to true to enable proxying all files served. Option allows to reduce egress traffic as this allows clients to download directly from remote storage instead of proxying all data | `false` |
 | `connection` | Various connection options described below | |
 
 #### S3 compatible connection settings

spec/requests/api/jobs_spec.rb

@@ -21,7 +21,6 @@ describe API::Jobs do
   let(:guest) { create(:project_member, :guest, project: project).user }
 
   before do
-    stub_licensed_features(cross_project_pipelines: true)
     project.add_developer(user)
   end
 

spec/support/stub_object_storage.rb

 module StubConfiguration
-  def stub_object_storage_uploader(config:, uploader:, remote_directory:, enabled: true, background_upload: false)
+  def stub_object_storage_uploader(config:, uploader:, remote_directory:,
+                                   enabled: true,
+                                   proxy_download: false,
+                                   background_upload: false)
     Fog.mock!
 
     allow(config).to receive(:enabled) { enabled }
+    allow(config).to receive(:proxy_download) { proxy_download }
     allow(config).to receive(:background_upload) { background_upload }
 
     return unless enabled

spec/tasks/gitlab/artifacts/migrate_rake_spec.rb

@@ -2,7 +2,7 @@ require 'rake_helper'
 
 describe 'gitlab:artifacts namespace rake task' do
   before(:context) do
-    Rake.application.rake_require 'tasks/gitlab/artifacts'
+    Rake.application.rake_require 'tasks/gitlab/artifacts/migrate'
   end
 
   let(:object_storage_enabled) { false }