Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
c02baddf
Commit
c02baddf
authored
Oct 20, 2017
by
Clement Ho
Committed by
Winnie Hellmann
Oct 21, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Force non diff resolved discussion to display when collapse toggled
parent
018542b1
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
29 additions
and
7 deletions
+29
-7
app/views/discussions/_discussion.html.haml
app/views/discussions/_discussion.html.haml
+1
-1
changelogs/unreleased/fix-non-diff-resolved-discussion.yml
changelogs/unreleased/fix-non-diff-resolved-discussion.yml
+5
-0
spec/support/features/discussion_comments_shared_example.rb
spec/support/features/discussion_comments_shared_example.rb
+23
-6
No files found.
app/views/discussions/_discussion.html.haml
View file @
c02baddf
...
@@ -44,4 +44,4 @@
...
@@ -44,4 +44,4 @@
=
render
"discussions/diff_with_notes"
,
discussion:
discussion
=
render
"discussions/diff_with_notes"
,
discussion:
discussion
-
else
-
else
.panel.panel-default
.panel.panel-default
=
render
"discussions/notes"
,
discussion:
discussion
=
render
partial:
"discussions/notes"
,
locals:
{
discussion:
discussion
,
disable_collapse_class:
true
}
changelogs/unreleased/fix-non-diff-resolved-discussion.yml
0 → 100644
View file @
c02baddf
---
title
:
Force non diff resolved discussion to display when collapse toggled
merge_request
:
author
:
type
:
fixed
spec/support/features/discussion_comments_shared_example.rb
View file @
c02baddf
...
@@ -121,14 +121,31 @@ shared_examples 'discussion comments' do |resource_name|
...
@@ -121,14 +121,31 @@ shared_examples 'discussion comments' do |resource_name|
end
end
end
end
it
'clicking "Start discussion" will post a discussion'
do
describe
'creating a discussion'
do
find
(
submit_selector
).
click
before
do
find
(
submit_selector
).
click
find
(
comments_selector
,
match: :first
)
end
it
'clicking "Start discussion" will post a discussion'
do
new_comment
=
all
(
comments_selector
).
last
expect
(
new_comment
).
to
have_content
'a'
expect
(
new_comment
).
to
have_selector
'.discussion'
end
if
resource_name
==
'merge request'
it
'shows resolved discussion when toggled'
do
click_button
"Resolve discussion"
expect
(
page
).
to
have_selector
(
'.note-row-1'
,
visible:
true
)
find
(
comments_selector
,
match: :first
)
refresh
new_comment
=
all
(
comments_selector
).
last
click_button
"Toggle discussion"
expect
(
new_comment
).
to
have_content
'a'
expect
(
page
).
to
have_selector
(
'.note-row-1'
,
visible:
true
)
expect
(
new_comment
).
to
have_selector
'.discussion'
end
end
end
end
if
resource_name
==
'issue'
if
resource_name
==
'issue'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment