Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
ccd1d682
Commit
ccd1d682
authored
Nov 15, 2018
by
George Tsiolis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix typos in comments for js
parent
0f8251e7
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
9 additions
and
9 deletions
+9
-9
app/assets/javascripts/diff_notes/components/jump_to_discussion.js
...s/javascripts/diff_notes/components/jump_to_discussion.js
+1
-1
app/assets/javascripts/diffs/store/getters.js
app/assets/javascripts/diffs/store/getters.js
+1
-1
app/assets/javascripts/files_comment_button.js
app/assets/javascripts/files_comment_button.js
+1
-1
spec/javascripts/vue_shared/components/expand_button_spec.js
spec/javascripts/vue_shared/components/expand_button_spec.js
+1
-1
spec/lib/gitlab/import_export/project.json
spec/lib/gitlab/import_export/project.json
+5
-5
No files found.
app/assets/javascripts/diff_notes/components/jump_to_discussion.js
View file @
ccd1d682
...
...
@@ -112,7 +112,7 @@ const JumpToDiscussion = Vue.extend({
if
(
!
hasDiscussionsToJumpTo
)
{
// If there are no discussions to jump to on the current page,
// switch to the notes tab and jump to the first dis
uc
ssion there.
// switch to the notes tab and jump to the first dis
cu
ssion there.
window
.
mrTabs
.
activateTab
(
'
show
'
);
activeTab
=
'
show
'
;
jumpToFirstDiscussion
=
true
;
...
...
app/assets/javascripts/diffs/store/getters.js
View file @
ccd1d682
...
...
@@ -23,7 +23,7 @@ export const diffHasAllExpandedDiscussions = (state, getters) => diff => {
};
/**
* Checks if the diff has all discussions coll
pa
sed
* Checks if the diff has all discussions coll
ap
sed
* @param {Object} diff
* @returns {Boolean}
*/
...
...
app/assets/javascripts/files_comment_button.js
View file @
ccd1d682
/* Developer beware! Do not add logic to showButton or hideButton
* that will force a reflow. Doing so will create a signficant performance
* that will force a reflow. Doing so will create a sign
i
ficant performance
* bottleneck for pages with large diffs. For a comprehensive list of what
* causes reflows, visit https://gist.github.com/paulirish/5d52fb081b3570c81e3a
*/
...
...
spec/javascripts/vue_shared/components/expand_button_spec.js
View file @
ccd1d682
...
...
@@ -18,7 +18,7 @@ describe('expand button', () => {
vm
.
$destroy
();
});
it
(
'
renders a coll
pa
sed button
'
,
()
=>
{
it
(
'
renders a coll
ap
sed button
'
,
()
=>
{
expect
(
vm
.
$children
[
0
].
iconTestClass
).
toEqual
(
'
ic-ellipsis_h
'
);
});
...
...
spec/lib/gitlab/import_export/project.json
View file @
ccd1d682
...
...
@@ -2556,7 +2556,7 @@
"merge_request_diff_id"
:
27
,
"relative_order"
:
0
,
"sha"
:
"bb5206fee213d983da88c47f9cf4cc6caf9c66dc"
,
"message"
:
"Feature confl
ci
t added
\n\n
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
\n
"
,
"message"
:
"Feature confl
ic
t added
\n\n
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
\n
"
,
"authored_date"
:
"2014-08-06T08:35:52.000+02:00"
,
"author_name"
:
"Dmitriy Zaporozhets"
,
"author_email"
:
"dmitriy.zaporozhets@gmail.com"
,
...
...
@@ -3605,7 +3605,7 @@
"merge_request_diff_id"
:
14
,
"relative_order"
:
8
,
"sha"
:
"08f22f255f082689c0d7d39d19205085311542bc"
,
"message"
:
"remove em
tp
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"message"
:
"remove em
pt
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"authored_date"
:
"2015-11-13T06:00:16.000+01:00"
,
"author_name"
:
"윤민식"
,
"author_email"
:
"minsik.yoon@samsung.com"
,
...
...
@@ -4290,7 +4290,7 @@
"merge_request_diff_id"
:
13
,
"relative_order"
:
8
,
"sha"
:
"08f22f255f082689c0d7d39d19205085311542bc"
,
"message"
:
"remove em
tp
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"message"
:
"remove em
pt
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"authored_date"
:
"2015-11-13T06:00:16.000+01:00"
,
"author_name"
:
"윤민식"
,
"author_email"
:
"minsik.yoon@samsung.com"
,
...
...
@@ -4799,7 +4799,7 @@
"merge_request_diff_id"
:
12
,
"relative_order"
:
8
,
"sha"
:
"08f22f255f082689c0d7d39d19205085311542bc"
,
"message"
:
"remove em
tp
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"message"
:
"remove em
pt
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"authored_date"
:
"2015-11-13T06:00:16.000+01:00"
,
"author_name"
:
"윤민식"
,
"author_email"
:
"minsik.yoon@samsung.com"
,
...
...
@@ -5507,7 +5507,7 @@
"merge_request_diff_id"
:
10
,
"relative_order"
:
8
,
"sha"
:
"08f22f255f082689c0d7d39d19205085311542bc"
,
"message"
:
"remove em
tp
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"message"
:
"remove em
pt
y file.(beacase git ignore empty file)
\n
add whitespace test file.
\n
"
,
"authored_date"
:
"2015-11-13T06:00:16.000+01:00"
,
"author_name"
:
"윤민식"
,
"author_email"
:
"minsik.yoon@samsung.com"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment