Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
d92baff6
Commit
d92baff6
authored
Mar 12, 2018
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
address wording feedback
parent
43ceaf49
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
9 deletions
+9
-9
doc/development/fe_guide/performance.md
doc/development/fe_guide/performance.md
+9
-9
No files found.
doc/development/fe_guide/performance.md
View file @
d92baff6
...
@@ -51,18 +51,18 @@ properties once, and handle the actual animation with transforms.
...
@@ -51,18 +51,18 @@ properties once, and handle the actual animation with transforms.
Code that is contained within
`main.js`
and
`commons/index.js`
are loaded and
Code that is contained within
`main.js`
and
`commons/index.js`
are loaded and
run on _all_ pages.
**DO NOT ADD**
anything to these files unless it is truly
run on _all_ pages.
**DO NOT ADD**
anything to these files unless it is truly
needed _everywhere_. Th
is includes ubiquitous libraries like
`vue`
,
`axios
`
,
needed _everywhere_. Th
ese bundles include ubiquitous libraries like
`vue
`
,
and
`jQuery`
, as well as code for the main navigation and sidebar. Where
`axios`
, and
`jQuery`
, as well as code for the main navigation and sidebar.
possible we should aim to remove modules from these bundles to reduce our code
Where possible we should aim to remove modules from these bundles to reduce our
footprint.
code
footprint.
### Page-specific JavaScript
### Page-specific JavaScript
Webpack has been configured to automatically generate entry point bundles based
Webpack has been configured to automatically generate entry point bundles based
on the file structure within
`app/assets/javascripts/pages/*`
. The directories
on the file structure within
`app/assets/javascripts/pages/*`
. The directories
within the
`pages`
directory
are meant to correspond to Rails controllers and
within the
`pages`
directory
correspond to Rails controllers and actions. These
a
ctions. These auto-generated bundles will be automatically included on the
a
uto-generated bundles will be automatically included on the corresponding
corresponding
pages.
pages.
For example, if you were to visit
[
gitlab.com/gitlab-org/gitlab-ce/issues
](
https://gitlab.com/gitlab-org/gitlab-ce/issues
)
,
For example, if you were to visit
[
gitlab.com/gitlab-org/gitlab-ce/issues
](
https://gitlab.com/gitlab-org/gitlab-ce/issues
)
,
you would be accessing the
`app/controllers/projects/issues_controller.rb`
you would be accessing the
`app/controllers/projects/issues_controller.rb`
...
@@ -82,8 +82,8 @@ In addition to these page-specific bundles, the code within `main.js` and
...
@@ -82,8 +82,8 @@ In addition to these page-specific bundles, the code within `main.js` and
-
**Identifying Controller Paths:**
-
**Identifying Controller Paths:**
If you are unsure what controller and action corresponds to a given page, you
If you are unsure what controller and action corresponds to a given page, you
can find this out by
checking
`document.body.dataset.page`
while on any page
can find this out by
inspecting
`document.body.dataset.page`
within your
within gitlab.com
.
browser's developer console while on any page within gitlab
.
-
**Keep Entry Points Lite:**
-
**Keep Entry Points Lite:**
Page-specific javascript entry points should be as lite as possible. These
Page-specific javascript entry points should be as lite as possible. These
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment