Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
dda33bd7
Commit
dda33bd7
authored
Aug 21, 2017
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename JavaScript click -> click() to make karma tests pass
parent
4a4aae7f
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
18 additions
and
18 deletions
+18
-18
spec/javascripts/integrations/integration_settings_form_spec.js
...avascripts/integrations/integration_settings_form_spec.js
+1
-1
spec/javascripts/issue_spec.js
spec/javascripts/issue_spec.js
+5
-5
spec/javascripts/merge_request_notes_spec.js
spec/javascripts/merge_request_notes_spec.js
+1
-1
spec/javascripts/pipeline_schedules/setup_pipeline_variable_list_spec.js
...s/pipeline_schedules/setup_pipeline_variable_list_spec.js
+1
-1
spec/javascripts/u2f/authenticate_spec.js
spec/javascripts/u2f/authenticate_spec.js
+4
-4
spec/javascripts/u2f/register_spec.js
spec/javascripts/u2f/register_spec.js
+6
-6
No files found.
spec/javascripts/integrations/integration_settings_form_spec.js
View file @
dda33bd7
...
...
@@ -168,7 +168,7 @@ describe('IntegrationSettingsForm', () => {
expect
(
$flashAction
).
toBeDefined
();
spyOn
(
integrationSettingsForm
.
$form
,
'
submit
'
);
$flashAction
.
click
;
$flashAction
.
click
()
;
expect
(
integrationSettingsForm
.
$form
.
submit
).
toHaveBeenCalled
();
});
...
...
spec/javascripts/issue_spec.js
View file @
dda33bd7
...
...
@@ -128,7 +128,7 @@ describe('Issue', function() {
});
it
(
`
${
action
}
s the issue`
,
function
()
{
this
.
$triggeredButton
.
click
;
this
.
$triggeredButton
.
click
()
;
this
.
issueStateDeferred
.
resolve
({
id
:
34
});
...
...
@@ -143,7 +143,7 @@ describe('Issue', function() {
});
it
(
`fails to
${
action
}
the issue if saved:false`
,
function
()
{
this
.
$triggeredButton
.
click
;
this
.
$triggeredButton
.
click
()
;
this
.
issueStateDeferred
.
resolve
({
saved
:
false
});
...
...
@@ -159,7 +159,7 @@ describe('Issue', function() {
});
it
(
`fails to
${
action
}
the issue if HTTP error occurs`
,
function
()
{
this
.
$triggeredButton
.
click
;
this
.
$triggeredButton
.
click
()
;
this
.
issueStateDeferred
.
reject
();
this
.
canCreateBranchDeferred
.
resolve
({
can_create_branch
:
isIssueInitiallyOpen
...
...
@@ -173,7 +173,7 @@ describe('Issue', function() {
});
it
(
'
disables the new branch button if Ajax call fails
'
,
function
()
{
this
.
$triggeredButton
.
click
;
this
.
$triggeredButton
.
click
()
;
this
.
issueStateDeferred
.
reject
();
this
.
canCreateBranchDeferred
.
reject
();
...
...
@@ -184,7 +184,7 @@ describe('Issue', function() {
Issue
.
$btnNewBranch
=
$
();
this
.
canCreateBranchDeferred
=
null
;
this
.
$triggeredButton
.
click
;
this
.
$triggeredButton
.
click
()
;
this
.
issueStateDeferred
.
reject
();
});
});
...
...
spec/javascripts/merge_request_notes_spec.js
View file @
dda33bd7
...
...
@@ -84,7 +84,7 @@ describe('Merge request notes', () => {
spyOnEvent
(
'
.note:last .js-note-edit
'
,
'
click
'
);
$
(
'
.js-discussion-reply-button
'
).
click
;
$
(
'
.js-discussion-reply-button
'
).
click
()
;
setTimeout
(()
=>
{
$
(
'
.js-note-text
'
).
trigger
(
upArrowEvent
);
...
...
spec/javascripts/pipeline_schedules/setup_pipeline_variable_list_spec.js
View file @
dda33bd7
...
...
@@ -92,7 +92,7 @@ describe('Pipeline Variable List', () => {
});
it
(
'
should remove the row when clicking the remove button
'
,
()
=>
{
$markup
.
find
(
'
.js-row-remove-button
'
).
click
;
$markup
.
find
(
'
.js-row-remove-button
'
).
click
()
;
expect
(
$markup
.
find
(
'
.js-row
'
).
length
).
toBe
(
0
);
});
...
...
spec/javascripts/u2f/authenticate_spec.js
View file @
dda33bd7
...
...
@@ -44,7 +44,7 @@ import './mock_u2f_device';
it
(
"
displays an error message
"
,
function
()
{
var
errorMessage
,
setupButton
;
setupButton
=
this
.
container
.
find
(
"
#js-login-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToAuthenticateRequest
({
errorCode
:
"
error!
"
});
...
...
@@ -54,14 +54,14 @@ import './mock_u2f_device';
return
it
(
"
allows retrying authentication after an error
"
,
function
()
{
var
retryButton
,
setupButton
;
setupButton
=
this
.
container
.
find
(
"
#js-login-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToAuthenticateRequest
({
errorCode
:
"
error!
"
});
retryButton
=
this
.
container
.
find
(
"
#js-u2f-try-again
"
);
retryButton
.
click
;
retryButton
.
click
()
;
setupButton
=
this
.
container
.
find
(
"
#js-login-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToAuthenticateRequest
({
deviceData
:
"
this is data from the device
"
});
...
...
spec/javascripts/u2f/register_spec.js
View file @
dda33bd7
...
...
@@ -23,7 +23,7 @@ import './mock_u2f_device';
var
deviceResponse
,
inProgressMessage
,
registeredMessage
,
setupButton
;
setupButton
=
this
.
container
.
find
(
"
#js-setup-u2f-device
"
);
expect
(
setupButton
.
text
()).
toBe
(
'
Setup new U2F device
'
);
setupButton
.
click
;
setupButton
.
click
()
;
inProgressMessage
=
this
.
container
.
children
(
"
p
"
);
expect
(
inProgressMessage
.
text
()).
toContain
(
"
Trying to communicate with your device
"
);
this
.
u2fDevice
.
respondToRegisterRequest
({
...
...
@@ -38,7 +38,7 @@ import './mock_u2f_device';
it
(
"
doesn't allow the same device to be registered twice (for the same user
"
,
function
()
{
var
errorMessage
,
setupButton
;
setupButton
=
this
.
container
.
find
(
"
#js-setup-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToRegisterRequest
({
errorCode
:
4
});
...
...
@@ -48,7 +48,7 @@ import './mock_u2f_device';
it
(
"
displays an error message for other errors
"
,
function
()
{
var
errorMessage
,
setupButton
;
setupButton
=
this
.
container
.
find
(
"
#js-setup-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToRegisterRequest
({
errorCode
:
"
error!
"
});
...
...
@@ -58,14 +58,14 @@ import './mock_u2f_device';
return
it
(
"
allows retrying registration after an error
"
,
function
()
{
var
registeredMessage
,
retryButton
,
setupButton
;
setupButton
=
this
.
container
.
find
(
"
#js-setup-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToRegisterRequest
({
errorCode
:
"
error!
"
});
retryButton
=
this
.
container
.
find
(
"
#U2FTryAgain
"
);
retryButton
.
click
;
retryButton
.
click
()
;
setupButton
=
this
.
container
.
find
(
"
#js-setup-u2f-device
"
);
setupButton
.
click
;
setupButton
.
click
()
;
this
.
u2fDevice
.
respondToRegisterRequest
({
deviceData
:
"
this is data from the device
"
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment