Commit f3ed4763 authored by Phil Hughes's avatar Phil Hughes

Correctly scrolls to the line when clicking

parent 8a8d4c9b
...@@ -88,7 +88,6 @@ class @MergeRequestTabs ...@@ -88,7 +88,6 @@ class @MergeRequestTabs
navBarHeight = $('.navbar-gitlab').outerHeight() navBarHeight = $('.navbar-gitlab').outerHeight()
$el = $("#{container} #{window.location.hash}") $el = $("#{container} #{window.location.hash}")
$('body').scrollTo 0
$.scrollTo("#{container} #{window.location.hash}", offset: -navBarHeight) if $el.length $.scrollTo("#{container} #{window.location.hash}", offset: -navBarHeight) if $el.length
# Activate a tab based on the current action # Activate a tab based on the current action
...@@ -163,8 +162,17 @@ class @MergeRequestTabs ...@@ -163,8 +162,17 @@ class @MergeRequestTabs
@scrollToElement("#diffs") @scrollToElement("#diffs")
@highlighSelectedLine() @highlighSelectedLine()
$(document)
.off 'click', '.diff-content a'
.on 'click', '.diff-content a', (e) =>
e.preventDefault()
window.location.hash = $(e.currentTarget).attr 'href'
@highlighSelectedLine()
@scrollToElement("#diffs")
highlighSelectedLine: -> highlighSelectedLine: ->
locationHash = location.hash $('.hll').removeClass 'hll'
locationHash = window.location.hash
if locationHash isnt '' if locationHash isnt ''
hashClassString = ".#{locationHash.replace('#', '')}" hashClassString = ".#{locationHash.replace('#', '')}"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment