Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
f4e2bd17
Commit
f4e2bd17
authored
Jan 10, 2019
by
George Tsiolis
Committed by
Annabel Dunstone Gray
Jan 10, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused button classes `btn-create` and `comment-btn`
parent
9b9b9b91
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
11 additions
and
10 deletions
+11
-10
app/assets/javascripts/notes/components/comment_form.vue
app/assets/javascripts/notes/components/comment_form.vue
+2
-2
app/assets/stylesheets/pages/note_form.scss
app/assets/stylesheets/pages/note_form.scss
+2
-6
app/views/shared/notes/_comment_button.html.haml
app/views/shared/notes/_comment_button.html.haml
+2
-2
changelogs/unreleased/gt-remove-unused-button-class.yml
changelogs/unreleased/gt-remove-unused-button-class.yml
+5
-0
No files found.
app/assets/javascripts/notes/components/comment_form.vue
View file @
f4e2bd17
...
@@ -370,7 +370,7 @@ append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
...
@@ -370,7 +370,7 @@ append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
>
>
<button
<button
:disabled=
"isSubmitButtonDisabled"
:disabled=
"isSubmitButtonDisabled"
class=
"btn btn-
create comment-btn
js-comment-button js-comment-submit-button
class=
"btn btn-
success
js-comment-button js-comment-submit-button
qa-comment-button"
qa-comment-button"
type=
"submit"
type=
"submit"
@
click.prevent=
"handleSave();"
@
click.prevent=
"handleSave();"
...
@@ -381,7 +381,7 @@ append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
...
@@ -381,7 +381,7 @@ append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
:disabled=
"isSubmitButtonDisabled"
:disabled=
"isSubmitButtonDisabled"
name=
"button"
name=
"button"
type=
"button"
type=
"button"
class=
"btn
comment-btn
note-type-toggle js-note-new-discussion dropdown-toggle qa-note-dropdown"
class=
"btn
btn-success
note-type-toggle js-note-new-discussion dropdown-toggle qa-note-dropdown"
data-display=
"static"
data-display=
"static"
data-toggle=
"dropdown"
data-toggle=
"dropdown"
aria-label=
"Open comment type dropdown"
aria-label=
"Open comment type dropdown"
...
...
app/assets/stylesheets/pages/note_form.scss
View file @
f4e2bd17
/**
/**
* Note Form
* Note Form
*/
*/
.comment-btn
{
@extend
.btn-success
;
}
.diff-file
.diff-content
{
.diff-file
.diff-content
{
tr
.line_holder
:hover
>
td
.line_note_link
{
tr
.line_holder
:hover
>
td
.line_note_link
{
opacity
:
1
;
opacity
:
1
;
...
@@ -386,7 +382,7 @@ table {
...
@@ -386,7 +382,7 @@ table {
}
}
.comment-type-dropdown
{
.comment-type-dropdown
{
.
comment-btn
{
.
btn-success
{
width
:
auto
;
width
:
auto
;
}
}
...
@@ -417,7 +413,7 @@ table {
...
@@ -417,7 +413,7 @@ table {
width
:
100%
;
width
:
100%
;
margin-bottom
:
10px
;
margin-bottom
:
10px
;
.
comment-btn
{
.
btn-success
{
flex-grow
:
1
;
flex-grow
:
1
;
flex-shrink
:
0
;
flex-shrink
:
0
;
width
:
auto
;
width
:
auto
;
...
...
app/views/shared/notes/_comment_button.html.haml
View file @
f4e2bd17
-
noteable_name
=
@note
.
noteable
.
human_class_name
-
noteable_name
=
@note
.
noteable
.
human_class_name
.float-left.btn-group.append-right-10.droplab-dropdown.comment-type-dropdown.js-comment-type-dropdown
.float-left.btn-group.append-right-10.droplab-dropdown.comment-type-dropdown.js-comment-type-dropdown
%input
.btn.btn-nr.btn-success.
comment-btn.
js-comment-button.js-comment-submit-button
{
type:
'submit'
,
value:
_
(
'Comment'
)
}
%input
.btn.btn-nr.btn-success.js-comment-button.js-comment-submit-button
{
type:
'submit'
,
value:
_
(
'Comment'
)
}
-
if
@note
.
can_be_discussion_note?
-
if
@note
.
can_be_discussion_note?
=
button_tag
type:
'button'
,
class:
'btn btn-nr dropdown-toggle
comment-btn
js-note-new-discussion js-disable-on-submit'
,
data:
{
'dropdown-trigger'
=>
'#resolvable-comment-menu'
},
'aria-label'
=>
_
(
'Open comment type dropdown'
)
do
=
button_tag
type:
'button'
,
class:
'btn btn-nr dropdown-toggle
btn-success
js-note-new-discussion js-disable-on-submit'
,
data:
{
'dropdown-trigger'
=>
'#resolvable-comment-menu'
},
'aria-label'
=>
_
(
'Open comment type dropdown'
)
do
=
icon
(
'caret-down'
,
class:
'toggle-icon'
)
=
icon
(
'caret-down'
,
class:
'toggle-icon'
)
%ul
#resolvable-comment-menu
.dropdown-menu.dropdown-open-top
{
data:
{
dropdown:
true
}
}
%ul
#resolvable-comment-menu
.dropdown-menu.dropdown-open-top
{
data:
{
dropdown:
true
}
}
...
...
changelogs/unreleased/gt-remove-unused-button-class.yml
0 → 100644
View file @
f4e2bd17
---
title
:
Remove unused button classes `btn-create` and `comment-btn`
merge_request
:
23232
author
:
George Tsiolis
type
:
performance
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment