Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
f65d8eb3
Commit
f65d8eb3
authored
Aug 01, 2016
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Updated method name to be more descriptive
parent
9accca43
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
5 deletions
+4
-5
app/assets/javascripts/diff_notes/components/resolve_btn.js.es6
...sets/javascripts/diff_notes/components/resolve_btn.js.es6
+1
-1
app/assets/javascripts/diff_notes/services/resolve.js.es6
app/assets/javascripts/diff_notes/services/resolve.js.es6
+3
-4
No files found.
app/assets/javascripts/diff_notes/components/resolve_btn.js.es6
View file @
f65d8eb3
...
@@ -70,7 +70,7 @@
...
@@ -70,7 +70,7 @@
const resolved_by = data ? data.resolved_by : null;
const resolved_by = data ? data.resolved_by : null;
CommentsStore.update(this.discussionId, this.noteId, !this.isResolved, resolved_by);
CommentsStore.update(this.discussionId, this.noteId, !this.isResolved, resolved_by);
ResolveService.update
UpdatedHtml
(this.discussionId, data);
ResolveService.update
DiscussionHeadline
(this.discussionId, data);
} else {
} else {
new Flash('An error occurred when trying to resolve a comment. Please try again.', 'alert');
new Flash('An error occurred when trying to resolve a comment. Please try again.', 'alert');
}
}
...
...
app/assets/javascripts/diff_notes/services/resolve.js.es6
View file @
f65d8eb3
...
@@ -47,7 +47,6 @@
...
@@ -47,7 +47,6 @@
}
}
discussion.loading = true;
discussion.loading = true;
console.log(discussion.loading);
return this.discussionResource.save({
return this.discussionResource.save({
mergeRequestId,
mergeRequestId,
...
@@ -59,7 +58,7 @@
...
@@ -59,7 +58,7 @@
discussion.resolveAllNotes(resolved_by);
discussion.resolveAllNotes(resolved_by);
discussion.loading = false;
discussion.loading = false;
this.update
UpdatedHtml
(discussionId, data);
this.update
DiscussionHeadline
(discussionId, data);
} else {
} else {
new Flash('An error occurred when trying to resolve a discussion. Please try again.', 'alert');
new Flash('An error occurred when trying to resolve a discussion. Please try again.', 'alert');
}
}
...
@@ -83,14 +82,14 @@
...
@@ -83,14 +82,14 @@
discussion.unResolveAllNotes();
discussion.unResolveAllNotes();
discussion.loading = false;
discussion.loading = false;
this.update
UpdatedHtml
(discussionId, data);
this.update
DiscussionHeadline
(discussionId, data);
} else {
} else {
new Flash('An error occurred when trying to unresolve a discussion. Please try again.', 'alert');
new Flash('An error occurred when trying to unresolve a discussion. Please try again.', 'alert');
}
}
});
});
}
}
update
UpdatedHtml
(discussionId, data) {
update
DiscussionHeadline
(discussionId, data) {
const $discussionHeadline = $(`.discussion[data-discussion-id="${discussionId}"] .js-discussion-headline`);
const $discussionHeadline = $(`.discussion[data-discussion-id="${discussionId}"] .js-discussion-headline`);
if (data.discussion_headline_html) {
if (data.discussion_headline_html) {
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment