Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
fd27be93
Commit
fd27be93
authored
Dec 27, 2018
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make it clear that monkey patch is no longer needed in Rails 5.1
parent
77909a88
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
3 deletions
+6
-3
config/initializers/active_record_avoid_type_casting_in_uniqueness_validator.rb
...tive_record_avoid_type_casting_in_uniqueness_validator.rb
+1
-1
config/initializers/active_record_locking.rb
config/initializers/active_record_locking.rb
+5
-2
No files found.
config/initializers/active_record_avoid_type_casting_in_uniqueness_validator.rb
View file @
fd27be93
...
...
@@ -20,7 +20,7 @@
#
# This bug was fixed in Rails 5.1 by https://github.com/rails/rails/pull/24745/commits/aa062318c451512035c10898a1af95943b1a3803
if
Rails
.
version
.
start_with?
(
"5.1"
)
if
Rails
.
gem_version
>=
Gem
::
Version
.
new
(
"5.1"
)
raise
"Remove this monkey patch:
#{
__FILE__
}
"
end
...
...
config/initializers/active_record_locking.rb
View file @
fd27be93
# rubocop:disable Lint/RescueException
# Remove this monkey-patch when all lock_version values are converted from NULLs to zeros.
# See https://gitlab.com/gitlab-org/gitlab-ce/issues/25228
# Remove this monkey patch when we move to Rails 5.1, because the bug has been fixed in https://github.com/rails/rails/pull/26050.
if
Rails
.
gem_version
>=
Gem
::
Version
.
new
(
"5.1"
)
raise
"Remove this monkey patch:
#{
__FILE__
}
"
end
module
ActiveRecord
module
Locking
module
Optimistic
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment