- 26 May, 2015 15 commits
-
-
Dmitriy Zaporozhets authored
Better handle label references that aren't actually references Fixes #1690 See merge request !705
-
Dmitriy Zaporozhets authored
Fix Markdown preview not working in Edit Milestone page ### What does this MR do? This MR removes the automatic Zen Mode URL update when a hash is present and makes Markdown preview work again in the Edit Milestone page. I think the intent was to make it possible to link to a full-screen edit with a URL (e.g. http://foo/bar/issues/1/edit#fullscreen), but I don't this has ever worked. Perhaps a future MR can support this. ### Why was this MR needed? A JavaScript error would be seen in the Milestone Edit page: ```javascript Uncaught error, unrecognized expression: $('.zennable input[type=checkbox]##md-preview-holder') ``` In the Milestone Edit page, apparently the use of the hash `#md-preview-holder` causes the Zen Mode JavaScript to attempt to parse the hash for the `fullscreen_` prefix and look up the checkbox based on a unknown ID. ### Are there points in the code the reviewer needs to double check? If we want to keep this hash update, an alternative fix is to add an `if` check in the beginning of `checkboxFromLocationHash`: ```coffeescript if (window.location.hash.indexOf('#' + ZenMode.fullscreen_prefix) == -1) return null ``` ### What are the relevant issue numbers? * Closes #1687 * Closes https://github.com/gitlabhq/gitlabhq/issues/9325 See merge request !711
-
Dmitriy Zaporozhets authored
-
Douwe Maan authored
Refactor permission checks with issues and merge requests project settings Slight refinement for read/write permission checks for 04d44522 as discussed in !691. Currently it appears that there is [no role that only has read-only access to issues](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/permissions/permissions.md), but it could be possible. /cc: @DouweM See merge request !704
-
Douwe Maan authored
Remove Rack Attack monkey patches and bump to version 4.3.0 I finally got these monkey patches into Rack Attack v4.3.0, so GitLab no longer needs them. Hooray! See: https://github.com/kickstarter/rack-attack/pull/128 See merge request !693
-
Job van der Voort authored
Added documentation styleguide Hi. I added a documentation styleguide and linked it to https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides See merge request !709
-
Job van der Voort authored
Added note about backups for gitlab.com Added note about backups for Gitlab.com based on question on Twitter https://twitter.com/MarcelloLins/status/598544357294272513 See merge request !1828
-
Stan Hu authored
Closes #1687 Closes https://github.com/gitlabhq/gitlabhq/issues/9325
-
Karen Carias authored
-
Karen authored
-
Karen authored
-
Karen authored
-
Karen authored
-
Karen authored
-
Karen authored
-
- 25 May, 2015 13 commits
-
-
Stan Hu authored
-
Sytse Sijbrandij authored
-
Sytse Sijbrandij authored
Document expanded autolinking in doc/markdown/markdown.md See merge request !706
-
Robert Speicher authored
-
Douwe Maan authored
Time zone text fix Added small fix to /etc/gitlab/gitlab.rb See merge request !1830
-
Robert Speicher authored
Fixes #1690
-
Karen Carias authored
-
Sytse Sijbrandij authored
-
Douwe Maan authored
Disable "New Issue" and "New Merge Request" buttons when features are disabled in project settings Closes #1676 See merge request !691
-
Stan Hu authored
Closes #1676
-
Robert Schilling authored
-
Robert Schilling authored
Remove redundant CHANGELOG entry This was moved into v7.10.4, but I forgot to delete it from the v7.11 list. See merge request !692
-
Douwe Maan authored
Add support for Webhook note events This MR adds support for note events (comments) for WebHooks. Perhaps the only potential source of confusion is that the settings indicates "Note Events" instead of "Comments". What do you think? Screenshot after: ![image](https://gitlab.com/stanhu/gitlab-ce/uploads/299b141d82f7b14943a74258d5c57ca6/image.png) Closes https://github.com/gitlabhq/gitlabhq/issues/6745 See merge request !673
-
- 22 May, 2015 12 commits
-
-
Sytse Sijbrandij authored
Keyboard shortcuts Added doc about how to view keyboard shortcuts cc/ @sytse See merge request !1829
-
Karen Carias authored
-
Karen Carias authored
-
Patricio Cano authored
-
Karen Carias authored
-
Karen Carias authored
-
Patricio Cano authored
-
karen Carias authored
-
Stan Hu authored
-
Sytse Sijbrandij authored
-
Douwe Maan authored
Use the user list from the target project in a merge request ### What does this MR do? This MR derives the assignable users from the target project. ### Why was this MR needed? In a merge request, the assignable users uses the list from the forked project, not the target project where the merge request will be going. For example, if I fork a project from the gitlab-org namespace into my personal namespace, make some changes, and then create a merge request, the only users I see are me. I think it makes more sense to show all the users in gitlab-org. This is a regression caused by 1c2711f7. ### What are the relevant issue numbers? Closes #1535 See merge request !682
-
Job van der Voort authored
-