An error occurred fetching the project authors.
- 27 Jun, 2016 6 commits
-
-
Annabel Dunstone authored
-
Annabel Dunstone authored
-
winniehell authored
-
Connor Shea authored
Add max-height to prevent images from displaying larger than the provided screen size. Also fix a failing test and add a new one.
-
Connor Shea authored
-
Robert Schilling authored
-
- 26 Jun, 2016 1 commit
-
-
Robert Speicher authored
[ci skip]
-
- 25 Jun, 2016 2 commits
-
-
Simon Welsh authored
-
Simon Welsh authored
-
- 24 Jun, 2016 7 commits
-
-
Felipe Artur authored
-
Felipe Artur authored
-
Rémy Coutable authored
Fix a wrong MR status when merge_when_build_succeeds & project.only_allow_merge_if_build_succeeds are true The issue was that `MergeRequest#mergeable?` returns false when the CI state is not success and project.only_allow_merge_if_build_succeeds is true. In this case `Projects::MergeRequestsController#merge` would return the `:failed` status when enabling `merge_when_build_succeeds`, thus leading to a weird state and the MR never automatically merged. The fix is to disable the CI state check in the controller safeguard that early return the `:failed` status. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Yorick Peterse authored
This is meant to go in 8.9.1, not 8.10.0. [ci skip]
-
DJ Mountney authored
The email check used in the Heath Check doesn't properly make use of enough of the SMTP config options to be able to properly test the STMP connection, and as a result could cause a failure. In order to fix it we have overwritten the email_configured? method in the health check so that it does not check email status during the standard health check.
-
Yorick Peterse authored
[ci skip]
-
James Lopez authored
Fix tmp file being deleted after the request plus some cleanup and improved erroring for this situation
-
- 23 Jun, 2016 15 commits
-
-
Connor Shea authored
-
Annabel Dunstone authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Paco Guzman authored
-
Stan Hu authored
Closes #18690
-
Marc Siegfriedt authored
rely only on IssuesFinder docs and changelog
-
Alejandro Rodríguez authored
-
Nathan Bush authored
-
Steve Norman authored
-
Kamil Trzcinski authored
-
Sean McGivern authored
Postgres and MySQL don't guarantee that pagination with `LIMIT` and `OFFSET` will work if the ordering isn't unique. From the Postgres docs: > When using `LIMIT`, it is important to use an `ORDER BY` clause that > constrains the result rows into a unique order. Otherwise you will get > an unpredictable subset of the query's rows Before: [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten [2] pry(main)> issues.count => 81 [3] pry(main)> issues.uniq.count => 42 After: [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten [2] pry(main)> issues.count => 81 [3] pry(main)> issues.uniq.count => 81
-
James Lopez authored
-
Paco Guzman authored
-
Z.J. van de Weg authored
-
- 22 Jun, 2016 3 commits
-
-
Connor Shea authored
-
Connor Shea authored
-
Rémy Coutable authored
[ci skip] Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 21 Jun, 2016 6 commits
-
-
Sean McGivern authored
Rails's form helpers use the `$attr_before_type_cast` method where available, and this value only appears to be updated on assignment, not when the object is mutated in some other way: [1] pry(main)> mr = MergeRequest.new => #<MergeRequest:0x007fcf28395d88 ...> [2] pry(main)> mr.description = 'foo' => "foo" [3] pry(main)> mr.description << ' bar' => "foo bar" [4] pry(main)> mr.description => "foo bar" [5] pry(main)> mr.description_before_type_cast => "foo" [6] pry(main)> mr.description += ' bar' => "foo bar bar" [7] pry(main)> mr.description_before_type_cast => "foo bar bar"
-
Annabel Dunstone authored
-
Yorick Peterse authored
The method Banzai::Renderer.pre_process would always be called, regardless of whether the Markdown to render was already cached or not. In cache the document _was_ cached the output of the pre-processing pipeline was ignored resulting in it doing nothing but wasting CPU cycles. This commit moves Banzai::Renderer.pre_process into Banzai::Renderer.render_result so that it's _only_ used when needed.
-
Alejandro Rodríguez authored
A lot of git operations were being repeated, for example, to build a url you would ask if the path was a Tree, which would call a recursive routine in Gitlab::Git::Tree#where, then ask if the path was a Blob, which would call a recursive routine at Gitlab::Git::Blob#find, making reference to the same git objects several times. Now we call Rugged::Tree#path, which allows us to determine the type of the path in one pass. Some other minor improvement added, like saving commonly used references instead of calculating them each time.
-
Grzegorz Bizon authored
-
Kamil Trzcinski authored
-